[Bug 37307] New: Update And Run SQL function appends report ID to savedsql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 Bug ID: 37307 Summary: Update And Run SQL function appends report ID to savedsql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org Use of the Update And Run SQL button causes koha to append the report ID to the end of the query. It's commented out, so it doesn't break the query, but it's adding useless characters. To recreate: - save and run this report: SELECT id, savedsql FROM saved_sql WHERE savedsql like "%saved_sql.id: %" - see your report returns itself - click Edit - click Update and Run SQL without changing anything in your report - click Update and Run SQL again - look at your report results, notice that the saved query is now repeating "/* saved_sql.id: 1334 */" at the end -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that was an intentional addition - so we need to dig back on why it as added in the first place. If I remember correctly it might have been to be able to see in the server logs which reports a problematic query might belong to. Adding Kyle - maybe he knows. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #1)
I think that was an intentional addition - so we need to dig back on why it as added in the first place. If I remember correctly it might have been to be able to see in the server logs which reports a problematic query might belong to. Adding Kyle - maybe he knows.
I've got no quarrel with displaying that little note of the query ID as part of the report results. However this bug is for the fact that the string "/* saved_sql.id: XXX*/" is being actually saved as part of the query and gets repeated the more one used the Update and Run button. After clicking Update and Run 7 times, my original query has become: SELECT id, savedsql FROM saved_sql WHERE savedsql like "%saved_sql.id: %" /* saved_sql.id: 1336 */ /* saved_sql.id: 1336 */ /* saved_sql.id: 1336 */ /* saved_sql.id: 1336 */ /* saved_sql.id: 1336 */ /* saved_sql.id: 1336 */ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I bet THAT was not intentional! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37763 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- I noticed that when fixing bug_37763, the saved_sql.id repeating issue corrected itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37307 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- *** This bug has been marked as a duplicate of bug 37763 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org