[Bug 38330] New: Make bib-level suppression a biblio table field instead of part of a marc tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Bug ID: 38330 Summary: Make bib-level suppression a biblio table field instead of part of a marc tag Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: danielle.elder@law.utexas.edu QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Suppression should be a biblio table field instead of in a marc field. Running reports with it to extract that field each time is not optimal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #1 from Angela Berrett <angela.berrett@familysearch.org> --- +1 I like this idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28478 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175648&action=edit Bug 38330: DB changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175649&action=edit Bug 38330: DBIC updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175650&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175651&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- My two cents towards all this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175648|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175767&action=edit Bug 38330: DB changes Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175649|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175768&action=edit Bug 38330: DBIC updates Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175650|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175769&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175651|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175770&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175767|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179335&action=edit Bug 38330: DB changes Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175768|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179336&action=edit Bug 38330: DBIC updates Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175769|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179337&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175770|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179338&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is a great move in a positive direction.. it highlights a few API oversights though.. which I think should be corrected in a follow-up bug. Passing QA as it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39336 [Bug 39336] Public Biblio endpoint should honour OpacSuppression syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39337 [Bug 39337] Use SQL field to apply OpacSuppression in OAI-PMH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179339&action=edit Bug 38330: (QA follow-up) Remove use of metadata_extractor We had a local method for getting opac_suppressed in Koha::Biblio which relied on extracting from the MARC record. Now that we have an opac_suppressed field in the Biblio table, we no longer need this wrapper method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179339|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179340&action=edit Bug 38330: (QA follow-up) Remove use of metadata_extractor We had a local method for getting opac_suppressed in Koha::Biblio which relied on extracting from the MARC record. Now that we have an opac_suppressed field in the Biblio table, we no longer need this wrapper method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179341&action=edit Bug 38330: (QA follow-up) Add population of opac_suppressed from biblio_metadata This patch updates the database update to populate the new opac_suppressed field in the bilios table using the data in the biblio_metadata table. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Wouldn't be a bad idea for someone to have a final look at those follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from David Cook <dcook@prosentient.com.au> --- This is super exciting to see, but we've got a little problem in the QA follow-up, as it's using 952$n instead of 942$n. Marking Failed QA but hopefully will be in this status only for a short time. I'll try to take a look at this again shortly (once I've gotten through the rest of my emails...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #21 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #19)
Wouldn't be a bad idea for someone to have a final look at those follow-ups.
I'll fix up the 952$n to 942$n... and I might do a different UPDATE since historically any true 942$n value was valid to trigger suppression. I'll have a think about that one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #21)
(In reply to Martin Renvoize (ashimema) from comment #19)
Wouldn't be a bad idea for someone to have a final look at those follow-ups.
I'll fix up the 952$n to 942$n... and I might do a different UPDATE since historically any true 942$n value was valid to trigger suppression. I'll have a think about that one.
I'm thinking about using boolean() in the Xpath. The following returns 1 for any true value and should return 0 for any false value, so it'll return 1 for new value of 1 or old values like "YES" or "yes" or whatever. 0 will be returned for 0 or empty or non-existent. IF(ExtractValue(metadata,'//datafield[@tag="942"]/subfield[@code="n" and boolean(text())]/text()'),1,0) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Keeping in mind bug 39337 it might be worthwhile adding an index on the opac_suppressed column. That said, it might not be used by the query planner. I suppose that's something that we could explore later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179335|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182094&action=edit Bug 38330: DB changes Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179336|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182095&action=edit Bug 38330: DBIC updates Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179337|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182096&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179338|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182097&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179340|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182098&action=edit Bug 38330: (QA follow-up) Remove use of metadata_extractor We had a local method for getting opac_suppressed in Koha::Biblio which relied on extracting from the MARC record. Now that we have an opac_suppressed field in the Biblio table, we no longer need this wrapper method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179341|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182099&action=edit Bug 38330: (QA follow-up) Add population of opac_suppressed from biblio_metadata This patch updates the database update to populate the new opac_suppressed field in the bilios table using the data in the biblio_metadata table. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182100&action=edit Bug 38330: (QA follow-up) Correction to field extaction As pointed out by David.. it's the 942 not the 952 we have this data in. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182101&action=edit Bug 38330: (QA follow-up) Improve resilience of DB update David considered using boolean, but this would catch 'no' and 0 as truthy. I instead look for common values here more explicitly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182102&action=edit Bug 38330: (QA follow-up) Add index to opac_suppressed As suggested by David, this one adds an index on the new column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |dcook@prosentient.com.au |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Any chance of a final QA run on this David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #33)
Any chance of a final QA run on this David
Sure thing, mon ami. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- The /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_38330.pl has a syntax error in the SQL because of the ADD INDEX but I'll add a follow-up for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #36 from David Cook <dcook@prosentient.com.au> --- The test plan is missing a "koha-plack --restart kohadev", so the test actually uses the pre-patch behaviour it seems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #37 from David Cook <dcook@prosentient.com.au> --- So /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_38330.pl was bugging me... Why would it try to SET b.opac_suppressed AND say "You need to run the `maintenance/touch_all_biblios.pl` script"? And the reason is that the WHERE clause in the UPDATE SQL will never match. Currently it is this: '%<datafield tag="942">%' But it should be this: '%<datafield tag="942" %' There should be no reason to run maintenance/touch_all_biblios.pl, since we're just updating the database and not changing the indexing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- Funny enough... in ktd biblionumber 232 and 234 are already marked suppressed. The things we learn when all you need to find suppressed records is: select biblionumber,opac_suppressed from biblio where opac_suppressed <> 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- After applying the patch, and running running "reset_all", "opac_suppressed" is 0 for KTD test data (e.g. biblionumber 232 and 234), but it should be 1. I think this is a problem with the KTD tools though. They must be doing direct SQL inserts instead of using Koha's internal functions... (yeah see /koha-misc4dev/-/tree/main/data/sql/marc21/2412/after_26684). That means there will be some buggy OpacSuppression behaviour in KTD for a transitional time. I've raised issue #88 in koha-miscdev to address this. Fortunately, the MARC bibliographic frameworks are created correctly out of the box, which is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Worth noting that the "Suppressed in OPAC" in the search results still comes from the MARC rather than the DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #40)
Worth noting that the "Suppressed in OPAC" in the search results still comes from the MARC rather than the DB.
Same with the detail page actually. In future, we should probably move that out of the XSLT and into its own spot. Not a dealbreaker at this point though... There are references to 942$n in Koha/ILL/Backend/Standard.pm and Koha/Filter/MARC/ExpandCodedFields.pm but they both make sense and they're irrelevant for our work here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #42 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #37)
There should be no reason to run maintenance/touch_all_biblios.pl, since we're just updating the database and not changing the indexing.
Theoretically, this is true. However, practically/technically it is possible for there to be MARCXML in the database which isn't formed exactly as we expect. For instance, it could be '<datafield ind1="" ind2="" tag="942">'. From memory, I think that Koha will still work with that, and that would fail our WHERE clause test. It's totally an edge case... but it's technically possible. So... I'm changing the warning to the following: "The biblio.opac_suppressed column should be updated, but you can run the `maintenance/touch_all_biblios.pl` script to be certain" That lets people know that the data should be updated, but that if they have issues... just run touch_all_biblios.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37713 [Bug 37713] OAI-PMH - Honour OpacSuppression syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182094|0 |1 is obsolete| | --- Comment #43 from David Cook <dcook@prosentient.com.au> --- Created attachment 182135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182135&action=edit Bug 38330: DB changes Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182095|0 |1 is obsolete| | --- Comment #44 from David Cook <dcook@prosentient.com.au> --- Created attachment 182136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182136&action=edit Bug 38330: DBIC updates Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182096|0 |1 is obsolete| | --- Comment #45 from David Cook <dcook@prosentient.com.au> --- Created attachment 182137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182137&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182097|0 |1 is obsolete| | --- Comment #46 from David Cook <dcook@prosentient.com.au> --- Created attachment 182138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182138&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182098|0 |1 is obsolete| | --- Comment #47 from David Cook <dcook@prosentient.com.au> --- Created attachment 182139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182139&action=edit Bug 38330: (QA follow-up) Remove use of metadata_extractor We had a local method for getting opac_suppressed in Koha::Biblio which relied on extracting from the MARC record. Now that we have an opac_suppressed field in the Biblio table, we no longer need this wrapper method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182099|0 |1 is obsolete| | --- Comment #48 from David Cook <dcook@prosentient.com.au> --- Created attachment 182140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182140&action=edit Bug 38330: (QA follow-up) Add population of opac_suppressed from biblio_metadata This patch updates the database update to populate the new opac_suppressed field in the bilios table using the data in the biblio_metadata table. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182100|0 |1 is obsolete| | --- Comment #49 from David Cook <dcook@prosentient.com.au> --- Created attachment 182141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182141&action=edit Bug 38330: (QA follow-up) Correction to field extaction As pointed out by David.. it's the 942 not the 952 we have this data in. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182101|0 |1 is obsolete| | --- Comment #50 from David Cook <dcook@prosentient.com.au> --- Created attachment 182142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182142&action=edit Bug 38330: (QA follow-up) Improve resilience of DB update David considered using boolean, but this would catch 'no' and 0 as truthy. I instead look for common values here more explicitly. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182102|0 |1 is obsolete| | --- Comment #51 from David Cook <dcook@prosentient.com.au> --- Created attachment 182143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182143&action=edit Bug 38330: (QA follow-up) Add index to opac_suppressed As suggested by David, this one adds an index on the new column Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #52 from David Cook <dcook@prosentient.com.au> --- Created attachment 182144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182144&action=edit Bug 38330: (QA follow-up) Fix SQL syntax error Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #53 from David Cook <dcook@prosentient.com.au> --- Created attachment 182145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182145&action=edit Bug 38330: (QA follow-up) Fix WHERE clause in SQL update and re-word warning Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to ponder this one. It feels like it might be too big and risky for 25.05 at this point in time (being after hard feature freeze). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #54)
I need to ponder this one. It feels like it might be too big and risky for 25.05 at this point in time (being after hard feature freeze).
No-one has argued against this, so I am setting this rel_25_11_candidate. Let's get this in early (but you'll have to talk to Lucas ;)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make bib-level suppression |Make bib-level suppression |a biblio table field |a biblio table field |instead of part of a marc |instead of part of a MARC |tag |tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #56 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #54)
I need to ponder this one. It feels like it might be too big and risky for 25.05 at this point in time (being after hard feature freeze).
I meant to reply to this before. I think that's a good decision. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |lucas@bywatersolutions.com --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column biblio.opac_suppressed is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Biblio.pm), see the SQL12 coding guideline The new column deletedbiblio.opac_suppressed is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Deletedbiblio.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Can we get this one moving again.. what's stuck about it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182135|0 |1 is obsolete| | Attachment #182136|0 |1 is obsolete| | Attachment #182137|0 |1 is obsolete| | Attachment #182138|0 |1 is obsolete| | Attachment #182139|0 |1 is obsolete| | Attachment #182140|0 |1 is obsolete| | Attachment #182141|0 |1 is obsolete| | Attachment #182142|0 |1 is obsolete| | Attachment #182143|0 |1 is obsolete| | Attachment #182144|0 |1 is obsolete| | Attachment #182145|0 |1 is obsolete| | --- Comment #59 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186697&action=edit Bug 38330: DB changes Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #60 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186698&action=edit Bug 38330: DBIC updates Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #61 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186699&action=edit Bug 38330: Map to biblio.opac_suppressed on saving record Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
SELECT opac_suppressed,COUNT(opac_suppressed) FROM biblio GROUP BY opac_suppressed; => FAIL: There are no records with the opac_suppressed flag set to 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #62 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186700&action=edit Bug 38330: Make sure biblio.opac_suppressed is populated/updated on save This patchset adds a new column to biblio/deletedbiblio for storing the information about OPAC suppression for the record. It works as any other framework-mapped attribute. It defaults to 0 (not suppressed) and some sanitization is done on storing, because the DB should only contain 0 or 1. To test: 0. Have a couple records with 942$n set to suppress them. 1. Apply this patches 2. Run: $ ktd --shell k$ updatedatabase => SUCCESS: All good 3. Check the `opac_suppressed` column was added to both tables 4. Notice it tells you need to run `touch_all_biblios.pl` 5. Run: k$ koha-mysql kohadev 6. Run: k$ perl misc/maintenance/touch_all_biblios.pl -v => SUCCESS: No failures 7. Repeat 5 => SUCCESS: Your couple records have the flag set. This means ModBiblio is doing the right thing 8. Play with adding new records (suppressed and not) => SUCCESS: Suppression status is set correctly 9. Change the status to select records => SUCCESS: The DB column and the MARC are in sync! 10. Sign off :-D Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #63 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186701&action=edit Bug 38330: (QA follow-up) Remove use of metadata_extractor We had a local method for getting opac_suppressed in Koha::Biblio which relied on extracting from the MARC record. Now that we have an opac_suppressed field in the Biblio table, we no longer need this wrapper method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #64 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186702&action=edit Bug 38330: (QA follow-up) Add population of opac_suppressed from biblio_metadata This patch updates the database update to populate the new opac_suppressed field in the bilios table using the data in the biblio_metadata table. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #65 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186703&action=edit Bug 38330: (QA follow-up) Correction to field extaction As pointed out by David.. it's the 942 not the 952 we have this data in. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #66 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186704&action=edit Bug 38330: (QA follow-up) Improve resilience of DB update David considered using boolean, but this would catch 'no' and 0 as truthy. I instead look for common values here more explicitly. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #67 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186705&action=edit Bug 38330: (QA follow-up) Add index to opac_suppressed As suggested by David, this one adds an index on the new column Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #68 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186706&action=edit Bug 38330: (QA follow-up) Fix SQL syntax error Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #69 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186707&action=edit Bug 38330: (QA follow-up) Fix WHERE clause in SQL update and re-word warning Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #70 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #57)
[FAIL] installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column biblio.opac_suppressed is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Biblio.pm), see the SQL12 coding guideline The new column deletedbiblio.opac_suppressed is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Deletedbiblio.pm), see the SQL12 coding guideline
Rebased against latest main and the QA script is now passing. @Lucas, ping me if you're still encountering the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31035 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187093&action=edit Bug 38330: (RM follow-up) Add missing comma -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #74 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 187194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187194&action=edit Bug 38330: (follow-up) Quote tagfield value to force VARCHAR comparisson Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187200&action=edit Bug 38330: (follow-up) Add an entry for new column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- one more follow-up pushed to main :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Keywords|rel_25_11_candidate, | |release-notes-needed | Status|Pushed to main |Needs documenting --- Comment #78 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42486 [Bug 42486] ILL Backend suppression hardcoded 942$n -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38330 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 [Bug 20846] Suppressed Records Still Appear in Public Lists -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org