[Bug 13272] New: Check in textbox lacks type attribute
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 Bug ID: 13272 Summary: Check in textbox lacks type attribute Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com While applying some CSS styling to Koha's textboxes, I notice that the Check in textbox on the Koha search bar (mainpage.pl, circulation-home.pl, circulation.pl, renew.pl, branchtransfers.pl) as well as the primary textbox on the Check in page (returns.pl) and the Renew page (renew.pl) is lacking the type="text" attribute, and is therefore inconsistent with the other textboxes. I am also seeing this attribute missing from the barcode textbox on the Transfers page (branchtransfers.pl). There may be other textboxes with the same issue. It would be preferable to have these textboxes consistently attributed with type. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Summary|Check in textbox lacks type |Many inputs lack a type |attribute |attribute --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Using this regex: <input(?:\s+(?!type=)\w+="[^"]*")*\s*/> (https://stackoverflow.com/questions/3472772/need-regex-for-all-html-input-ta...) I found 23 matches in the staff client templates: prog\en\includes\borrower_debarments.inc prog\en\includes\cat-search.inc prog\en\includes\circ-search.inc prog\en\includes\home-search.inc prog\en\includes\patron-search.inc prog\en\modules\acqui\z3950_search.tt prog\en\modules\admin\smart-rules.tt prog\en\modules\cataloguing\z3950_auth_search.tt prog\en\modules\cataloguing\z3950_search.tt prog\en\modules\circ\branchtransfers.tt prog\en\modules\circ\offline.tt prog\en\modules\circ\renew.tt prog\en\modules\circ\returns.tt prog\en\modules\members\memberentrygen.tt prog\en\modules\members\paycollect.tt prog\en\modules\patroncards\members-search.tt prog\en\modules\reserve\request.tt prog\en\modules\tools\import_borrowers.tt Looks like the type attribute isn't strictly required since it defaults to "text," but there's no reason why we shouldn't add an explicit type to enable consistent styling. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org