[Bug 14867] New: userid not generated when defined in BorrowerUnwantedField
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Bug ID: 14867 Summary: userid not generated when defined in BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 42753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42753&action=edit Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42753|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 42755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42755&action=edit Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42755|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44314&action=edit Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Frédéric Demians <f.demians@tamil.fr> The issue is there, and this patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44314|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44554&action=edit [PASSED QA] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Frédéric Demians <f.demians@tamil.fr> The issue is there, and this patch fixes it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |liz@catalyst.net.nz --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org