https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- It works as described. Reading the code, and for the sake of discussion: You have this: $("#searchform").on("submit",function(){ return filter(); }); Why not directly: $("#searchform").on("submit",filter); Or, since filter() isn't used anywhere else, why not moving its code directly above: $("#searchform").on("submit",function(){ // filter() code And this old code: var type_fees = new Array(); type_fees['L'] = ''; type_fees['F'] = ''; type_fees['A'] = ''; type_fees['N'] = ''; type_fees['M'] = ''; could be cleaned up: var type_fees = {'L':'','F':'','A':'','N':'','M':''}; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by EricGosselin <eric.gosselin.5@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61382&action=edit Bug 17014 - Remove more event attributes from patron templates There are many patron-related templates which still use event attributes to define events. This patch updates these templates so that events are defined in JavaScript. To test apply the patch and check out to a patron. - From the Print menu in the toolbar, choose "Print summary." The patron summary page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print slip." The patron slip page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print quick slip." The patron quick slip page should open and the print dialog should be automatically triggered. - Click the patron's "Fines" tab in the left-hand sidebar and then choose the "Account" tab. -- Click the "Print" button for an account payment (the link should point to printfeercpt.pl). A print receipt page should open and the print dialog should be automatically triggered. -- Follow the same procedure for a transaction which is not an account payment (the link should point to printinvoice.pl). - Click the "Create manual invoice" tab. -- Select one of the "type" choices. Doing so should automatically populate the "Description" field with the corresponding code. -- If necessary, define one or more values for the MANUAL_INV authorized value and confirm that those invoice types work as well. - From the patron's "Pay fines" tab, click the "Pay amount" button. In the "collect from patron" field, enter any combination of letters, numbers, and symbols. When you tab away from that field your text should be reformatted to currency format. - From the patrons home page, change the filter in the left-hand sidebar and submit it. The correct results should be returned. Signed-off-by: EricGosselin <eric.gosselin.5@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61382|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61423&action=edit Bug 17014 - Remove more event attributes from patron templates There are many patron-related templates which still use event attributes to define events. This patch updates these templates so that events are defined in JavaScript. To test apply the patch and check out to a patron. - From the Print menu in the toolbar, choose "Print summary." The patron summary page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print slip." The patron slip page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print quick slip." The patron quick slip page should open and the print dialog should be automatically triggered. - Click the patron's "Fines" tab in the left-hand sidebar and then choose the "Account" tab. -- Click the "Print" button for an account payment (the link should point to printfeercpt.pl). A print receipt page should open and the print dialog should be automatically triggered. -- Follow the same procedure for a transaction which is not an account payment (the link should point to printinvoice.pl). - Click the "Create manual invoice" tab. -- Select one of the "type" choices. Doing so should automatically populate the "Description" field with the corresponding code. -- If necessary, define one or more values for the MANUAL_INV authorized value and confirm that those invoice types work as well. - From the patron's "Pay fines" tab, click the "Pay amount" button. In the "collect from patron" field, enter any combination of letters, numbers, and symbols. When you tab away from that field your text should be reformatted to currency format. - From the patrons home page, change the filter in the left-hand sidebar and submit it. The correct results should be returned. Signed-off-by: EricGosselin <eric.gosselin.5@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 [Bug 19329] The automatic slip printing does not work when IntranetSlipPrinterJS defined -- You are receiving this mail because: You are watching all bug changes.