[Bug 22934] New: Add missing use statement to Koha::AdditionalFieldValue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Bug ID: 22934 Summary: Add missing use statement to Koha::AdditionalFieldValue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- When refactoring additional fields for 15774 it looks like a use statement was missed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89893&action=edit Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15774 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 [Bug 15774] Additional fields for baskets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89893|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89895&action=edit Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 [Bug 22932] GetLatestSerials should not return formatted date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89895|0 |1 is obsolete| | --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 89919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89919&action=edit Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac 5 - Without patch ,in the subscription detail page,click the link of the record title. => software error. 6 - Apply the patch. => no error anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89919|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89960&action=edit Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac 5 - Without patch ,in the subscription detail page,click the link of the record title. => software error. 6 - Apply the patch. => no error anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Fixed another typo on L21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22934 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug with new feature not in 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org