[Bug 22300] New: Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Bug ID: 22300 Summary: Staff search results: Opt groups in 'sort' pull down are not well formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In older versions (17.11) the groups of the various sort options were bold, options indented and sections divided by thin lines. In master and 18.11 the display isn't as nice and harder to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84980&action=edit Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84980|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 85186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85186&action=edit Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85186|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85203&action=edit Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This could also be seen as a regression to previous versions (bug fix vs. enh) - see first comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Okies, I take your point.. pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse@bywatersolutions.com Status|Pushed to Stable |RESOLVED --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Patch doesn't apply cleanly. Please rebase if needed for 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jesse Maseto from comment #8)
Patch doesn't apply cleanly. Please rebase if needed for 18.05.x
It is not needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org