[Bug 18499] New: catalog 'Call Number Browser' on edit items screen does not sort on items.cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Bug ID: 18499 Summary: catalog 'Call Number Browser' on edit items screen does not sort on items.cn_sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To replicate: Find items which are on the same shelf in using the opac shelf browser, but whose items.itemcallnumber do not sort the same way alphanumerically. Edit one of the items, click on the elipses ( ... ) next to itemcallnumber in the edit items screen. This will bring up a 'Call numbers browser' screen. These will not be sorted the same way that they are sorted in the opac shelf browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19915 Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Need to model changes here on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Once that is PQA I will work on this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|catalog 'Call Number |catalog 'Call Number |Browser' on edit items |Browser' on edit items |screen does not sort on |screen uses the default |items.cn_sort |classification source | |rather than the item | |specific source -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- To clarify, in a system with mixed classification sources the callnumber browser uses the DefaultClassificationSource defined in the sysprefs for all browsing. This is problematic in some situations, for instance: '2017 SCHM' is a generic callnumber, if you set the Default to 'LOC' you get back a blank string To recreate: 1 - Set DefaultClassificationSource to LOC 2 - perl -e "use C4::ClassSource; print GetClassSort( undef, undef, '2017 SCHM' );" 3 - You get no feedback 4 - Set DefaultClass.. to Dewey 5 - repeat #2 6 - You get a populated string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|catalog 'Call Number |'Call Number Browser' on |Browser' on edit items |edit items screen uses the |screen uses the default |default classification |classification source |source rather than the item |rather than the item |specific source |specific source | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98531&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98531|0 |1 is obsolete| | --- Comment #4 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 98737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98737&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #5 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- This patch works as expected. I tested with Dewey, LC, and home-grown alpha-numeric call numbers using the 'z Other/Generic classification scheme' and the results were all as expected. I wish I had a larger database of call numbers to test this with to be 100% certain, but from what I could test in the test database it works great and looks like a huge improvement on the current call number browser. Thank you for your great work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, Nick: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt FAIL filters missing_filter at line 23 ( <input name="popup" type="hidden" value="[% popup %]"/>) missing_filter at line 55 ( [% IF ( cn_loo.barcode ) %] ([% cn_loo.barcode %])[% END %]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99000&action=edit Bug 18499: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98737|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99057&action=edit Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99000|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99058&action=edit Bug 18499: (follow-up) Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99059&action=edit Bug 18499: (QA follow-up) Add missing colon after label description To match the line above, a colon (:) was added after the description: Callnumber classification scheme: [pull down] Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25144 [Bug 25144] Callnumber browser is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103029&action=edit Bug 18499: [19.05.x only] Remove subtitle from query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Call Number Browser' on |Make 'Call number browser' |edit items screen uses the |on edit items screen use |default classification |the correct item specific |source rather than the item |classification scheme |specific source | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org