[Bug 29878] New: Use multiple select widget for AdvancedSearchTypes system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Bug ID: 29878 Summary: Use multiple select widget for AdvancedSearchTypes system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The AdvancedSearchTypes system preference asks for pipe-delimited text, which isn't very user-friendly. We can use a multiple-select widget (as used for OpacAdvSearchOptions for example) to allow the user to select one or more predefined options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129429&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129429|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129431&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 [Bug 17018] Split AdvancedSearchTypes for staff and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129431|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129603&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129963&action=edit Bug 29878: (follow-up) Fix opac-topissues.pl This page is using the preference AdvancedSearchTypes with wrong split character Test plan : 1) Enable preference OpacTopissue 2) In OPAC click on 'Most popular' 3) Check you see filters on ccode and/or itemtype when they are in AdvancedSearchTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129964&action=edit Bug 29878: (follow-up) Change system preference type to multiple AdvancedSearchTypes type must be changed from 'Choice' to 'multiple'. 'Choice' was in fact not the correct type. Also fix options even if they are useless. Other multiple preferences set them. Also replaces split /\,/ with /,/ There is no need to escape. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- This needs a bit more work. We see in preference description (searching.pref) : Tabs appear in the order listed. Looks like it is not valid : Values defined in preference are 'itemtypes,ccode,loc' I see in system preference page : Collection Item type Shelving location Is it alphabetical ? When I select all and save value changes to 'ccode,itemtypes,loc'; Values can not be ordered anymore, we should remove this text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think we should remove the ability to have the tabs appear in the order the library likes. If we can't do this with the multi select, we should not use it. Could we do something similar like we have for the languages? You can check/uncheck and order them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It does work in 20.11: ccode|loc|itemtypes makes the tabs appear in this order in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17018 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 [Bug 17018] Split AdvancedSearchTypes for staff and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org