https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Get rid of |Translatability: |exposed if statement in tt |Translatability: Get rid of |translation for |exposed if statement in tt |onboardingstep2.tt |for translated | |onboardingstep2.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63850|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63988&action=edit Bug 18702: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt The file onboardingstep2.tt exposes the following to translations: "[%% IF (categories && categories.count > 1 ) # This if statement checks if " "the categories variable handed to this template # by onboarding.pl has data " "in it. If the categories variable does have data # in it this means that the " "user has previously imported sample patron category # data and so we do not " "need to show them the create patron category screen 1, #instead we can " "display a screen with ubtton redirecting the user to step 3 %%] " Translators should not be confronted with such internals. This patch removes it To test: - Verify that code change makes sense - Run QA tools - Bonus test: Create a new "language" aa-AA and verify that the lines above are no longer exposed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: |Translatability: Get rid of |Translatability: Get rid of |exposed if statement in tt |exposed if statement in tt |for translated |for translated |onboardingstep2.tt |onboardingstep2.tt | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.