[Bug 7294] New: status "in order"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Bug #: 7294 Summary: status "in order" Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: claire.hernandez@biblibre.com ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com Blocks: 7163 "View status 'in order' to the OPAC and staff interface: you can map specific fields from aqorders : aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber with marc field so you can keep the information on what is currently on order at biblio level until you receive everything. Once all items have been reveived, the marc field is deleted." (BibLibre MT5834) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Blocks| |5336 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2012-02-20 13:23:55 UTC --- Created attachment 7773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7773 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |matthias.meusburger@biblibr | |e.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-20 13:38:23 UTC --- Hi Matthias, your patch contains kohaversion.pl - can you perhaps remove the file and resubmit? Thank you! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7773|0 |1 is obsolete| | --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2012-02-23 15:10:03 UTC --- Created attachment 7834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7834 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2012-02-23 15:10:30 UTC --- Sorry, it was a mistake. New patch without kohaversion.pl submitted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|claire.hernandez@biblibre.c |matthias.meusburger@biblibr |om |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7834|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8084&action=edit Bug 7294: Adds acquisition informations in marc record Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Can we get a testing scenario for this? I create a 951 field with subfields that mapped to the aqorders fields that you listed, and created an on order item, but the marc fields do not seem to have been populated with the data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, only wondering - were you using the ACQ framework in your tests? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #7)
Hm, only wondering - were you using the ACQ framework in your tests?
No, I modified and was using the default framework. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #9 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- <h1>Something went wrong !</h1>Applying: Bug 7294: Adds acquisition informations in marc record<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging installer/data/mysql/kohastructure.sql<br/> Auto-merging installer/data/mysql/updatedatabase.pl<br/> CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl<br/> Failed to merge in the changes.<br/> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8084|0 |1 is obsolete| | --- Comment #10 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 8345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8345&action=edit Proposed patch conflicts fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- tested for unimarc on biblibre sandbox 1 : tag mapped with aqorders.supplierreference is not shown in intranet (http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/MARCdetail.pl?biblionum...). Is supplierreference = clientnumber declared when creating a vendor, can't test this in the sandbox ? Tag mapped with aqorders.branchcode is also empty. It appears that this enhancement might be depending on other(s) enh to come. works for other tags listed in descritpion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #12 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Needs enhancements : contact name (supplierreference) in supplier.pl branchcode in neworderempty.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8345|0 |1 is obsolete| | --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 8916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8916&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch adds branchcode in neworderempty.pl (which was missing) Supplierreference is automatically filled with bookseller's name. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8916|0 |1 is obsolete| | --- Comment #15 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 8922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8922&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #16 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This patch adds the ability to select an empty branchcode in neworderempty.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 shinoy m <shinoy.m@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shinoy.m@osslabs.biz --- Comment #17 from shinoy m <shinoy.m@osslabs.biz> --- I tried testing this patch, I am able to see acq info captured in field 951 of the MARC record. But I don't see anything in opac-results or opac-detail that shows that this item is on order. Does this change take care of showing a 'on order' status on the OPAC and staff pages? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #18 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This patch only adds ordering information in the marc record. Whether the ordering information will be displayed in opac or admin interface depends on your configuration. But there are no "special" modifications of opac-display and opac-detail for displaying the "on order" status, if that's what you were wondering. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #19 from shinoy m <shinoy.m@osslabs.biz> --- Created attachment 9980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9980&action=edit Additional patch to show the ordered status in catalogue page The new patch is applied ahead on the old patch which is already in the attachment. The new patch will be helpful for showing the ordered status in the catalog page. The status can be seen in the catalog search result also.For the proper working of this patch two more fields to be mapped to the same marc field where the other aqorder fields are mapped. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mjr@software.coop --- Comment #20 from MJ Ray (software.coop) <mjr@software.coop> --- fatal: sha1 information is lacking or useless (acqui/addorder.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7294:Additional patch to show the ordered status in catalogue page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8922|0 |1 is obsolete| | --- Comment #21 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 10121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10121&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #22 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Here's how to test: - Create the wanted koha to marc mappings. Only ordernumber is mandatory. - Place an order - Check that the mapped fields are reported in the record - Place another order - Modify one of the orders - Check that the modified order applies to the matching field of the record - Delete an order - Check that the order is deleted in the record - Delete the other order - Check that the order is deleted in the record and that the field to which it was mapped is also deleted (as there are no orders left). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8230 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #23 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi shinoy m, I created a new bug that I assigned to you for your additional patch : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Having two separate smaller patches will make the sign-off and QA process much easier. Hope it's ok for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9980|0 |1 is obsolete| | --- Comment #24 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Comment on attachment 9980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9980 Additional patch to show the ordered status in catalogue page Obsoleted this patch, as it is now in 8230. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8229 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #25 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Blocked by 8229 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #26 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Works for me, but didn't work for mveron and alex_a when adding from new record or suggestion. I should try with the default koha community database. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle.m.hall@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10121|0 |1 is obsolete| | --- Comment #27 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 10745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10745&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #28 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Indeed, the previous patch did not work correctly. This new patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot seem to get the mapped fields to show up. I created an ACQ framework, then I mapped some aqorders fields to a few 951 fields. I then created some baskets and added items to the basket. When I viewed the MARC for the record, I did not see any data for the 951 fields I had previously mapped. Can you provide a test plan? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #30 from delaye <stephane.delaye@biblibre.com> --- I try to understand the usefulness of the patch. Want to display order information from the search? Ok but why the OPAC? How useful for the borrowers to know the price or the reference quantity of the order? And then from the interface professional why delete this information after receipt? Why not limit the display to the internal interface and do not delete the information after the receipt? .... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #31 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Kyle, are you sure you have mapped aqorders.ordernumber? This is mandatory. Anyway, here's my test plan: 1) Create the mappings using the ACQ framework. Here's what I have used for testing, using 930: a ordernumber Tab:9, | Koha field: aqorders.ordernumber, Not repeatable, Mandatory, Edit Delete b listprice Tab:9, | Koha field: aqorders.listprice, Not repeatable, Not mandatory, Edit Delete c branchcode Tab:9, | Koha field: aqorders.branchcode, Not repeatable, Not mandatory, Edit Delete d quantity Tab:9, | Koha field: aqorders.quantity, Not repeatable, Not mandatory, Edit Delete e test2 Tab:9, Not repeatable, Not mandatory, 2) Select a basket 3) Add an order to basket (in my case: from an existing record) 4) Fill item informations (syspref AcqCreateItem's value is: Create an item when placing an order) 5) Add the item 6) Quantity is now at 1. Select a budget. Fill order informations. Save. 7) You're back at the basket details screen. Click on the newly ordered title. Click on "Marc". Click on "9". Here's what i've got: 930 ## - order a ordernumber 38 c branchcode FPL d quantity 1 b listprice 12.00 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #32 from Nicole C. Engard <nengard@gmail.com> --- Matthias, How do I add the linking to the Koha fields? The only fields in the pull down are biblio and items and I don't see away to add fields in the Koha to Marc Mapping so I'm not sure where to go to add aqorders.ordernumber etc. so that I can put them as the Koha link in the framework. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10745|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11661&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Followed the test plan. Feature works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #35 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (En réponse au commentaire 32)
Matthias,
How do I add the linking to the Koha fields? The only fields in the pull down are biblio and items and I don't see away to add fields in the Koha to Marc Mapping so I'm not sure where to go to add aqorders.ordernumber etc. so that I can put them as the Koha link in the framework.
Nicole
Hi Nicole, When applying this patch, you should have an "aqorders" value in the dropdown list in the "Koha to MARC mapping" page (koha2marclinks.pl). When selecting it and pressing ok, you should be able to do the mapping. It's not the case? Another way to do it is to edit the ACQ framework MARC Structure (marctagstructure.pl?frameworkcode=ACQ), edit the 930 subfields, and proceed to the mapping from there (you should also have the aqorder.* fields listed in "Display More Constraints -> Koha link"). Does this work for you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #36 from Nicole C. Engard <nengard@gmail.com> --- I might have done something wrong when testing - Kyle has signed off and I trust his test :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #37 from Mason James <mtj@kohaaloha.com> --- Created attachment 12301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12301&action=edit modified: C4/Acquisition.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11661|0 |1 is obsolete| | --- Comment #38 from Mason James <mtj@kohaaloha.com> --- Created attachment 12302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12302&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12301|0 |1 is obsolete| | --- Comment #39 from Mason James <mtj@kohaaloha.com> --- Created attachment 12303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12303&action=edit perltidy of badly indented ModReceiveOrder() sub -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj@kohaaloha.com --- Comment #40 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #38)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment - there is a small error in the neworderempty.tt template causing ./xt/tt_valid.t to fail failing QA on this $ perl ./xt/tt_valid.t 1..2 not ok 1 - TT syntax: not using TT directive within HTML tag # Failed test 'TT syntax: not using TT directive within HTML tag' # at ./xt/tt_valid.t line 55. # Files list: # intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: 341 ok 2 - Token received same as original put on stack # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12302|0 |1 is obsolete| | --- Comment #41 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 12332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12332&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #42 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch fixes TT validation issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #43 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * this patch touches core features, I won't push it for 3.10 (Feature Freeze) * There are many $$x{Y} that should be written $x->{Y} * I think/fear that the aqorders.branchcode feature is a bad idea: how will it work when syspref AcqCreateItem=ordering ? How will you deal, when you don't have AcqCreadItem=ordering, with creation of items, will this value be used for defining the branch ? How will you deal with cases where you order 3 items for different branches ? The items table has some fields that are already related to acquisition: items.booksellerid, items.price, items.replacementprice. * I don't see why the "aqorders.uncertainprice" should be ported to MARC, but maybe there's a use-case I don't see As a conclusion, what is requested from QA point of view: * split the patch in 2, to separate branchcode feature from the link2marc feature, that's 2 different things * fix $${} * argue how this feature will integrate smoothly with various acqcreateitem possibilities -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12332|0 |1 is obsolete| | --- Comment #44 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 14072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14072&action=edit Rebased patch Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14072|0 |1 is obsolete| | --- Comment #45 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 14076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14076&action=edit Transform $$ into $-> Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #46 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- * There are many $$x{Y} that should be written $x->{Y} => Done. * I think/fear that the aqorders.branchcode feature is a bad idea: how will it work when syspref AcqCreateItem=ordering ? How will you deal, when you don't have AcqCreadItem=ordering, with creation of items, will this value be used for defining the branch ? How will you deal with cases where you order 3 items for different branches ? The items table has some fields that are already related to acquisition: items.booksellerid, items.price, items.replacementprice. => I don't see the problem here, because the branchcode that is used is the one in the aqorders table (added by this patch), so it doesn't matter which value has AcqCreateItem syspref. The branchcode is asked when creating a new order and that's it. Moreover, the values inserted in the MARC Record are here for information, they're not reused afterwards. * split the patch in 2, to separate branchcode feature from the link2marc feature, that's 2 different things => Same as before, branchcode is an aqorders field, just like the others. I don't see how it is different and why it should be handled separately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- testing 1 commit(s) (applied to commit 33e95ea) * adc69c0 Bug 7294: Adds acquisition informations in marc record C4/Acquisition.pm acqui/addorder.pl admin/koha2marclinks.pl admin/marc_subfields_structure.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt * C4/Acquisition.pm FAIL pod FAIL *** WARNING: No items in =over / =back list in file C4/Acquisition.pm forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (1662) The patch introduces a forbidden pattern: tabulation character (1371) The patch introduces a forbidden pattern: tabulation character (1369) The patch introduces a forbidden pattern: tabulation character (1667) The patch introduces a forbidden pattern: tabulation character (1381) The patch introduces a forbidden pattern: tabulation character (1665) The patch introduces a forbidden pattern: tabulation character (1661) The patch introduces a forbidden pattern: tabulation character (1370) The patch introduces a forbidden pattern: tabulation character (1660) The patch introduces a forbidden pattern: tabulation character (1385) The patch introduces a forbidden pattern: tabulation character (1383) The patch introduces a forbidden pattern: tabulation character (1658) The patch introduces a forbidden pattern: tabulation character (1363) The patch introduces a forbidden pattern: tabulation character (1382) The patch introduces a forbidden pattern: tabulation character (1377) The patch introduces a forbidden pattern: tabulation character (1668) The patch introduces a forbidden pattern: tabulation character (1402) The patch introduces a forbidden pattern: tabulation character (1366) The patch introduces a forbidden pattern: tabulation character (1364) The patch introduces a forbidden pattern: tabulation character (1664) The patch introduces a forbidden pattern: tabulation character (1367) The patch introduces a forbidden pattern: withespace character (1389) The patch introduces a forbidden pattern: tabulation character (1659) The patch introduces a forbidden pattern: withespace character (1667) The patch introduces a forbidden pattern: tabulation character (1374) The patch introduces a forbidden pattern: tabulation character (1389) The patch introduces a forbidden pattern: tabulation character (1373) The patch introduces a forbidden pattern: tabulation character (1657) The patch introduces a forbidden pattern: tabulation character (1372) The patch introduces a forbidden pattern: tabulation character (1386) The patch introduces a forbidden pattern: tabulation character (1403) The patch introduces a forbidden pattern: tabulation character (1666) The patch introduces a forbidden pattern: tabulation character (1379) The patch introduces a forbidden pattern: tabulation character (1375) The patch introduces a forbidden pattern: tabulation character (1390) The patch introduces a forbidden pattern: tabulation character (1384) The patch introduces a forbidden pattern: tabulation character (1380) The patch introduces a forbidden pattern: tabulation character (1376) The patch introduces a forbidden pattern: tabulation character (1391) The patch introduces a forbidden pattern: tabulation character (1663) The patch introduces a forbidden pattern: tabulation character (1388) The patch introduces a forbidden pattern: withespace character (1663) The patch introduces a forbidden pattern: withespace character (1377) The patch introduces a forbidden pattern: tabulation character (1368) valid OK critic OK * acqui/addorder.pl FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (239) The patch introduces a forbidden pattern: tabulation character (229) The patch introduces a forbidden pattern: tabulation character (236) The patch introduces a forbidden pattern: withespace character (197) The patch introduces a forbidden pattern: tabulation character (235) The patch introduces a forbidden pattern: tabulation character (202) The patch introduces a forbidden pattern: withespace character (210) The patch introduces a forbidden pattern: tabulation character (242) The patch introduces a forbidden pattern: withespace character (175) The patch introduces a forbidden pattern: tabulation character (240) The patch introduces a forbidden pattern: tabulation character (224) The patch introduces a forbidden pattern: tabulation character (249) The patch introduces a forbidden pattern: tabulation character (208) The patch introduces a forbidden pattern: withespace character (232) The patch introduces a forbidden pattern: tabulation character (244) The patch introduces a forbidden pattern: tabulation character (241) The patch introduces a forbidden pattern: tabulation character (237) The patch introduces a forbidden pattern: tabulation character (232) The patch introduces a forbidden pattern: tabulation character (203) The patch introduces a forbidden pattern: tabulation character (243) The patch introduces a forbidden pattern: tabulation character (245) The patch introduces a forbidden pattern: tabulation character (233) The patch introduces a forbidden pattern: tabulation character (247) The patch introduces a forbidden pattern: tabulation character (246) The patch introduces a forbidden pattern: tabulation character (194) The patch introduces a forbidden pattern: tabulation character (230) valid OK critic OK * admin/koha2marclinks.pl OK pod OK forbidden patterns OK valid OK critic OK * admin/marc_subfields_structure.pl OK pod OK forbidden patterns OK valid OK critic OK * installer/data/mysql/updatedatabase.pl FAIL pod FAIL *** ERROR: =item without previous =over in file installer/data/mysql/updatedatabase.pl forbidden patterns FAIL The patch introduces a forbidden pattern: merge marker (=======) (6309) valid OK critic OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt OK forbidden patterns OK tt_valid OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Ping! Matthias, are you going to write a followup for this? It looks like it only failed QA due to new tab characters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14076|0 |1 is obsolete| | --- Comment #49 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 14918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14918&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #50 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Tabs and pods are now fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14918|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16017&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch fixes an issues in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16017|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16247&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking a look at this now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Matthias, let's get started with QA on that feature :) 1) The QA script does not pass, becasue of Perlcritic and a POD error, please fix. 2) I think you accidentally deleted a line from an earlier update in updatedatabase: +++ b/installer/data/mysql/updatedatabase.pl @@ -5806,7 +5806,6 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AllowReturnToBranch', '$prefvalue', 'Where an item may be returned', 'anywhere|homebranch|holdingbranch|homeorholdingbranch', 'Choice');"); print "Upgrade to $DBversion done: adding AllowReturnToBranch syspref (bug 6151)"; - SetVersion($DBversion); } 3) Can you explain how the addition of branch to the aquisition detail works? Right now one library can easily order items for multiple branches, will this still be possible? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 4) QA script also complains about tabs in neworderempty.tt Please fix and switch back to signed off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16247|0 |1 is obsolete| | --- Comment #57 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 16464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16464&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- 1, 2, 4 : All green now :) As for the 3), even if the branchcode has been added to the aqorders table, it is possible to leave it blank, so acquisitions for multiple branches is still possible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found a problem, my test plan is: 1) Create a new order 2) Create a new order line (from empty record) with 2 items (AcqCreateItem = on order) 3) Close basket 3) Receive only 1 of the items Perl error message shown: Mandatory parameter quantity missing at /home/katrin/kohaclone/acqui/finishreceive.pl line 88 Patch has been applied and I am using a newly created ACQ framework based on Default (MARC21). No other confiuration/mapping has been done yet. Error only occurs for partial receives. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Matthias, did you find the problem yet? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #61 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Yes, I did. But I also did some more testing, and it doesn't behave correctly when canceling an order, so I have fix that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah - good testing! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8667 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #63 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I have just realized the aim of this patch is partially the same as BZ9780 I made, and which is waiting for QA. But in my patch, in order status is not display in tabs, but under the record. And my patch also prevent librarians to suppress a record if it is used in active order. Maybe the logic of BZ9780 and BZ7294 are not compatible : I did not put order information into MARC record, but create a new function in C4/Acquisition to check if a record is used by an order. So, is it really necessary to put order information into MARC record? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure every library will want to have the information in the record, so maybe we need both approaches? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #65 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- My patch was only make to display the number of orders using a bib record, but the function I created (Acquisition::GetOrdersByBiblionumber) return all fields from aqorders and aqbudgets, so I suppose it could be used for displaying more information. If the link between biblio and aqorders tables is kept (and that s the aim of my pacth, by preventing the suppression of the record...), I don't see the interest of putting order information within MARC. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17313&action=edit Bug 7294: Adds acquisition informations in marc record -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|matthias.meusburger@biblibr |jonathan.druart@biblibre.co |e.com |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5336 | Depends on| |5336 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8667 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #67 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello Jonathan Could you take a look at my last comment under BZ 9780 and give me your opinion please? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #68 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Somebody create a new bug for displaying orders under records (that is the 4th!) : BZ 10013 And we made a local dev in jquery in my library. I joined a screenshot under 10013. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8230 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have given this feature some more thought and I worry a bit about the consequences of storing acquisition related information in the MARC record. Libraries might easily overwrite the information in the record using z39.50 or importing and matching records. This would make this feature probably not usable for our libraries, as the records are updated automatically with updated records from the union catalog. Also there might be information you don't want the patron to see, so the fields would have to be excluded from the MARC views and MARC export options. Overall I'd like this to be strictly optional and not tied to important functionality. I think the new patch from Jonathan for 5336 is no longer dependenton this feature? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #69)
I have given this feature some more thought and I worry a bit about the consequences of storing acquisition related information in the MARC record.
Libraries might easily overwrite the information in the record using z39.50 or importing and matching records. This would make this feature probably not usable for our libraries, as the records are updated automatically with updated records from the union catalog.
Also there might be information you don't want the patron to see, so the fields would have to be excluded from the MARC views and MARC export options.
We will certainly drop this feature.
Overall I'd like this to be strictly optional and not tied to important functionality. I think the new patch from Jonathan for 5336 is no longer dependenton this feature?
No, it is the opposite, this one is dependent on bug 5336. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If the feature will be dropped, should this be closed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #72 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #71)
If the feature will be dropped, should this be closed?
Not sure... :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- The status of orders is managed by bug 5336. We don't want order status information in the marc record. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org