[Bug 28269] New: Order search should be possible with ISSN too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Bug ID: 28269 Summary: Order search should be possible with ISSN too Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: inkeri.hakulinen+bugz@helsinki.fi QA Contact: testopia@bugs.koha-community.org At the order search ( koha/acqui/histsearch.pl ) there should be a possibility to search orders by ISSN. Serials don't have an ISBN, but ISSN. Often the serial names are long and similar to each other, so the short and exact searching by ISSN should be an option, too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |slavashishkin@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |slavashishkin@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 133782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133782&action=edit Bug 28269: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133782|0 |1 is obsolete| | --- Comment #3 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 133796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133796&action=edit Bug 28269: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #4 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 133869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133869&action=edit Bug 28269: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #5 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 133870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133870&action=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #6 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 133871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133871&action=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Slava, thx for your patches! I haven't tested yet, but looking at this, I wonder if it's not actually 2 great features :) We try to break things into small steps wherever possible, so I wonder if it would make sense to move your first patch to bug 23919 and link them both with a depends on (that will ensure the right sequence in testing). It will also have the benefit of this showing up more clearly in release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #8 from Slava Shishkin <slavashishkin@gmail.com> --- Hi Katrin, Okay, I'll deal with these issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Let us know if we can help in any way :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #10 from Slava Shishkin <slavashishkin@gmail.com> --- The first patch (133869) will not solve by itself 23919 - there is additional code logic required (and I now have some proof of concept working, so yes, 23919 will be solved as well by me, but there will be another patch over 133869), and the above patch (133869) is needed by both 28269 and 23919. So it can be here or there. Q1: so to which ticket is better to place the first patch, please advise, Q2: Can I put one ticket as dependant on another, and that will fit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 [Bug 23919] Make ISSN searchable with and without hyphen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #11 from Slava Shishkin <slavashishkin@gmail.com> --- Ok, I will move patch 133869 to 23919 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133870|0 |1 is obsolete| | Attachment #133871|0 |1 is obsolete| | --- Comment #12 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134386&action=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #13 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134387&action=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134386|0 |1 is obsolete| | Attachment #134387|0 |1 is obsolete| | --- Comment #14 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134427&action=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #15 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134428&action=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134427|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138185&action=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134428|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138186&action=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138185|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138850&action=edit Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138186|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138851&action=edit Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138852&action=edit Bug 28269: (QA follow-up) Fix typo in test description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice enhancement :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Bug 28269 depends on bug 23919, which changed state. Bug 23919 Summary: Make ISSN searchable with and without hyphen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds ISSN as a new release notes| |search option to the | |acquisitions advanced | |search form. If | |SearchWithISSNVariations is | |enabled, you'll be able to | |search for the ISSN with | |and without the hyphen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/659 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org