[Bug 23685] New: Exporting report may consume unlimited memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Bug ID: 23685 Summary: Exporting report may consume unlimited memory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: paul@flo.org QA Contact: testopia@bugs.koha-community.org In guided_reports.pl, when exporting report results ($phase eq 'Export') all rows of data are fetched and then converted to the desired format. This may consume an unlimited amount of memory; when report results are particularly large, it may consume all available memory, leading to timed-out HTTP requests, crashes, and potentially data loss. (We have experienced Zebra index corruption as a result.) In master, reports/guided_reports.pl supports three export types -- tab-delimited, CSV, or *.ods. In each case, all data are loaded into memory and held there before any output is produced: 891 $sql = get_prepped_report( $sql, \@param_names, \@sql_params ); 892 my ($sth, $q_errors) = execute_query($sql); ... 895 if ($format eq 'tab') { 896 $type = 'application/octet-stream'; 897 $content .= join("\t", header_cell_values($sth)) . "\n"; 898 $content = Encode::decode('UTF-8', $content); 899 while (my $row = $sth->fetchrow_arrayref()) { 900 $content .= join("\t", @$row) . "\n"; 901 } 902 } else { 903 my $delimiter = C4::Context->preference('delimiter') || ','; 904 if ( $format eq 'csv' ) { ... 914 while (my $row = $sth->fetchrow_arrayref()) { 915 if ($csv->combine(@$row)) { 916 $content .= $csv->string() . "\n"; 917 } else { 918 push @$q_errors, { combine => $csv->error_diag() } ; 919 } 920 } 921 } 922 elsif ( $format eq 'ods' ) { ... 932 # Other line in Unicode 933 my $sql_rows = $sth->fetchall_arrayref(); 934 foreach my $sql_row ( @$sql_rows ) { 935 my @content_row; 936 foreach my $sql_cell ( @$sql_row ) { 937 push @content_row, Encode::encode( 'UTF8', $sql_cell ); 938 } 939 push @$ods_content, \@content_row; 940 } 941 942 # Process 943 generate_ods($ods_filepath, $ods_content); 944 945 # Output 946 binmode(STDOUT); 947 open $ods_fh, '<', $ods_filepath; 948 $content .= $_ while <$ods_fh>; 949 unlink $ods_filepath; 950 } The *.ods case is particularly problematic, because before any data is sent back to the user's browser, *three* copies of the full results are sitting in memory simultaneously -- @$sql_row, @$ods_content, and $content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, can you share why you closed INVALID? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #2 from Paul Hoffman <paul@flo.org> --- (In reply to Katrin Fischer from comment #1)
Hi Paul, can you share why you closed INVALID?
I tweaked bug #23626 (memory consumption related to the charting feature) to encompass this problem, because they involve the same files and the same underlying problem -- running a report and then doing something with the results (charting or exporting) potentially consumes all available memory. Maybe I should post a comment there with the details from this ticket? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Hoffman from comment #2)
(In reply to Katrin Fischer from comment #1)
Hi Paul, can you share why you closed INVALID?
I tweaked bug #23626 (memory consumption related to the charting feature) to encompass this problem, because they involve the same files and the same underlying problem -- running a report and then doing something with the results (charting or exporting) potentially consumes all available memory.
Maybe I should post a comment there with the details from this ticket?
You could use 'mark as duplicate' or choose 'RESOLVED MOVED' with a comment - that would link the bugs and make this clearer to people researching bugs later. Also if you leave out the # bugzilla will show a link: bug 23626 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #4 from Paul Hoffman <paul@flo.org> --- I'm reopening this as suggested by Nick Clemens in bug 23626. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #5 from didier <didier.gautheron@biblibre.com> --- What were the rationals for using a big string rather than writing directly to SDTOUT or a temporary file? Are theses assumptions still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Didier Gautheron from comment #5)
What were the rationals for using a big string rather than writing directly to SDTOUT or a temporary file?
Are theses assumptions still valid?
It looks like it used to print out to STDOUT but it was changed in Bug 11679. After reviewing the code, I'd say it was probably a desire to make the code more readable/easier to maintain. However, it does create this performance problem. Fixing the "tab" and "csv" export should be fairly trivial, but the ODS will be harder since it's a more complex file format (ZIP compressed XML). I'll write another comment about that... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Wow looking at OpenOffice::OODoc... it hasn't been updated in over 10 years. It's amazing that it still works. Excel::Writer::XLSX has an interesting little write up on the topic of memory usage (see https://metacpan.org/pod/Excel::Writer::XLSX#SPEED-AND-MEMORY-USAGE). It looks like OpenOffice::OODoc uses Archive::Zip and Archive::Zip doesn't seem to be able to stream to output... It looks like Excel::Writer::XLSX manages memory by writing worksheets out as temporary files (https://metacpan.org/pod/Excel::Writer::XLSX#set_tempdir()). Of course Excel::Writer::XLSX still adds every one of those temporary files into memory when it's saving the workbook, so it would still have a memory spike. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Rewriting OpenOffice::OODoc is not really an option, but that would be the most "correct" solution I imagine. However, realistically, we could be more optimal in our current use of OpenOffice::OODoc. As Paul mentions, it makes no sense to do a $sth->fetchall_arrayref(), plus building @$ods_content, and then having an in-memory representation in OpenOffice::OODoc. That's 3x more memory usage than we need to use. We should just use something like $sth->fetchrow_hashref or $sth->fetchrow_arrayref and feed OpenOffice::OODoc row by row. -- Note too that the ODS format will have proxy issues for large exports, because guided_reports.pl will write the ZIP to disk, read the ZIP from disk, write to STDOUT, and then Plack::App::CGIBin will buffer STDOUT in a temporary file on disk, and then it will send the whole response all at once to the Apache reverse proxy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- An alternative solution might be to write a CSV file to a temporary file and then use LibreOffice's CLI tools to convert from CSV to ODS. Example: soffice --convert-to ods koha.csv --headless I haven't tried that though, so I can't speak to its performance. I seem to recall Indranil saying OpenOffice or LibreOffice had some memory usage issues for large spreadsheets. It might not be any better. Plus, it would add a large dependency to Koha for just 1 thing. I think that's all I have for ideas though. I think the ODS format is just problematic - at least with the tools that we have to hand. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Just a note here to say that this is still a problem - perhaps we should only support CSV and TAB for exports? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Liz Rea from comment #10)
Just a note here to say that this is still a problem - perhaps we should only support CSV and TAB for exports?
The .ods format is what we use most as CSV is not recognized by Excel as utf8 and so umlauts are broken. You have to separately import the data which is a lot of extra steps. I'd really really like to keep it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Just noting that this has caused a bunch of OOMs for our libraries this week, not sure why it's happening all of a sudden but this is a real problem for us. Keen to collaborate on a solution! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- We've received sponsorship to try and fix the ODS export format. Any ideas are welcome, we're working on this now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #13)
We've received sponsorship to try and fix the ODS export format.
Any ideas are welcome, we're working on this now
You'll want to go with a streaming response for all formats. Instead of putting everything into $content, you'll want to print to STDOUT line by line to save memory. However, I don't know why I didn't mention it before, but even if you tried to do a streaming response where each row was written out to STDOUT one by one, it won't work as expected because Koha uses Plack::App::CGIBin. You can see fully explanations in bug 8437 and bug 26791 in my comments there. Basically, the whole response gets buffered in a temporary file before it's sent to the Apache proxy to send back to the client. Plus, for ODS, you'll have to wait for the content of generate_ods as well. (If you want to see a possible cheeky solution for that, you can check out bug 31744. Not sure if it'll work for ODS like it works for CSV though.) Anyway, just some thoughts... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168116&action=edit Bug 23685: Don't store ODS content in a variable to save memory Just attaching this to start. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I don't know the kind of report I need to test crashing the system when I export to ODS. Any ideas? I've just avoided adding to a $content variable as a start and can confirm it works, but doesn't address the Plack problem that David Cook raised. Not sure the best way around that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #16)
I don't know the kind of report I need to test crashing the system when I export to ODS. Any ideas?
Try something like this: SELECT biblio.* FROM biblio CROSS JOIN biblio b limit 10000; I think it should make an enormous number of rows, so you can play with the limit however you like.
I've just avoided adding to a $content variable as a start and can confirm it works, but doesn't address the Plack problem that David Cook raised. Not sure the best way around that.
Yeah it's a hard one. For now, the best bet is probably to avoid using Plack for this. It sucks, but it's the only practical solution I can think of. There just isn't enough community support to move forward on a Mojolicious/Plack-based controller solution yet. I've tried a few times to progress it, but it's too much for just 1 person. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168570&action=edit Bug 23685: Exclude guided_reports.pl from plack When attempting to export reports in ODS format from Koha, plack can time out Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1. Create a report which will generate an enormous number of rows, such as SELECT biblio.* FROM biblio CROSS JOIN biblio b; (add a limit of 10000 or something if you like i.e. SELECT biblio.* FROM biblio CROSS JOIN biblio b limit 10000;) 2. Run the report 3. Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4. Restart all the things 5. Download the results in ODS format 6. Confirm the export works as expected Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168570|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 168577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168577&action=edit Bug 23685: Exclude guided_reports.pl from plack When attempting to export reports in ODS format from Koha, plack can time out Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1. Create a report which will generate an enormous number of rows, such as SELECT biblio.* FROM biblio CROSS JOIN biblio b; (add a limit of 10000 or something if you like i.e. SELECT biblio.* FROM biblio CROSS JOIN biblio b limit 10000;) 2. Run the report 3. Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4. Restart all the things 5. Download the results in ODS format 6. Confirm the export works as expected Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- diff --git a/debian/templates/apache-shared-intranet-plack.conf b/debian/templates/apache-shared-intranet-plack.conf index bcee399443..6fa4014929 100644 --- a/debian/templates/apache-shared-intranet-plack.conf +++ b/debian/templates/apache-shared-intranet-plack.conf @@ -14,6 +14,7 @@ ProxyPass "/cgi-bin/koha/tools/export.pl" "!" ProxyPass "/cgi-bin/koha/tools/upload-cover-image.pl" "!" ProxyPass "/cgi-bin/koha/svc/cataloguing/metasearch" "!" + ProxyPass "/cgi-bin/koha/reports/guided_reports.pl" "!" Can understand this choice. But it takes years to get them out of this list again? We had quite a bunch when we started with Plack in 2015 ? commit 4adc4ee5f8d3e113b62094552be6c80942289c3e Author: Tomás Cohen Arazi <tomascohen@theke.io> Date: Wed Mar 4 00:19:40 2015 +0100 Bug 13791: Plack out-of-the-box support on packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #11)
The .ods format is what we use most as CSV is not recognized by Excel as utf8 and so umlauts are broken. You have to separately import the data which is a lot of extra steps. I'd really really like to keep it.
I guess that it takes a few steps more to import in Excel correctly, but that should really be possible. Do not remember any details, but you should be able to google it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thinking about workarounds.. Cant we put some user defined limit on e.g. number of records to report / download ? Removing ODS is a serious option too. We need some more input here. (Moving to In Discussion wont attract many people..) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to Major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #21)
(In reply to Katrin Fischer from comment #11)
The .ods format is what we use most as CSV is not recognized by Excel as utf8 and so umlauts are broken. You have to separately import the data which is a lot of extra steps. I'd really really like to keep it.
I guess that it takes a few steps more to import in Excel correctly, but that should really be possible. Do not remember any details, but you should be able to google it :)
I can do it - but it's really hard to explain and train, while .ods just works fine with both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am quite against removing .ods as it was such an improvement for us. Our reports usually contain umlauts and with .cvs and Excel we always got reports about broken umlauts and it's really tedious to import the data correctly (many more clicks). On the other hand we didn't experience the serious issues this bug is hoping to fix, maybe because the exports are usually quite small in comparison. I think hardcoding a limit would be totally acceptable for us if there is no better way to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks all for the input. What should the limit be? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- As an aside, another option would be to rewrite reports/guided_reports.pl to use a Plack/Mojolicious handler. Easier said than done although a lot of the core work needed is already prepared in bug 31380. At some point, surely we need to stop using Plack::App::CGIBin and move into a real Plack/Mojo world. We can do it incrementally, but it needs to be done at some point... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #28 from Mathieu Saby <mathsabypro@gmail.com> --- We suffered from this bug recently, but please do not remove ODS ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Coming back here, we got some feedback :) Thx for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168116|0 |1 is obsolete| | Attachment #168577|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171136&action=edit Bug 23685: (follow-up) Control ODS exporting The pref ReportingAllowsODS_Export should be true for exporting to ODS in Reporting. Test plan: Set pref to false value. Check if option is no longer available on report's Download menu. Manipulate URL with op=export&format=ods. No data expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171137&action=edit Bug 23685: (follow-up) Dbrev for new preferences Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171138&action=edit Bug 23685: (follow-up) Add prefs to Administration form Test plan: Edit both prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171139&action=edit Bug 23685: (follow-up) Add export limit for guided reports Test plan: Set pref GuidedReportsExportLimit to some positive integer. Test if exporting a report respects that limit. Run t/db_dependent/Koha/Reports.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171136|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171140&action=edit Bug 23685: (follow-up) Control ODS exporting The pref ReportingAllowsODS_Export should be true for exporting to ODS in Reporting. Test plan: Set pref to false value. Check if option is no longer available on report's Download menu. Manipulate URL with op=export&format=ods. No data expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development allows you release notes| |to control the number of | |records that is downloaded | |in the reports module (to | |prevent timeouts) and also | |includes the option to hide | |the ODS download option | |that is the most expensive | |one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development allows you |This development allows you release notes|to control the number of |to control the number of |records that is downloaded |records that is downloaded |in the reports module (to |in the reports module (to |prevent timeouts) and also |prevent timeouts) and also |includes the option to hide |includes the option to hide |the ODS download option |the ODS download option |that is the most expensive |that is the most expensive |one. |one. | | | |Adding prefs | |GuidedReportsExportLimit | |and | |ReportingAllowsODS_Export | |for that reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171141&action=edit Bug 23685: Don't store ODS content in a variable to save memory Just attaching this to start. Sponsored-by: Waikato Institute of Technology Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171137|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171142&action=edit Bug 23685: (follow-up) Dbrev for new preferences Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171138|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171143&action=edit Bug 23685: (follow-up) Add prefs to Administration form Test plan: Edit both prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171139|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171144&action=edit Bug 23685: (follow-up) Add export limit for guided reports Test plan: Set pref GuidedReportsExportLimit to some positive integer. Test if exporting a report respects that limit. Run t/db_dependent/Koha/Reports.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171140|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171145&action=edit Bug 23685: (follow-up) Control ODS exporting The pref ReportingAllowsODS_Export should be true for exporting to ODS in Reporting. Test plan: Set pref to false value. Check if option is no longer available on report's Download menu. Manipulate URL with op=export&format=ods. No data expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Aleisha, since this adds four patches to your initial ones, please have a look if you agree (functionally and QA wise) with this approach. It is meant to allow flexibility as indicated in the feedback received. If you add your signoff line to the follow-ups, I will pass QA if nobody beats me to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA note: FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs IntranetAddMastheadLibraryPulldown is bad placed (see bug 10610) This warning shows that another report did a wrong insert. Not here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Might be controversial... but our system preferences usually have no underscores, could we remove the one here? ReportingAllowsODS_Export -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #43 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #42)
Might be controversial... but our system preferences usually have no underscores, could we remove the one here? ReportingAllowsODS_Export
I agree - how about we call preference ExportFormatODS? Also I noticed that patches saying "Reporting" to refer to the module, I think this should just be "Reports" as that's the name of the module button. Finally, there's a typo in the DBrev patches - "Reporing" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171141|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171171&action=edit Bug 23685: Don't store ODS content in a variable to save memory Just attaching this to start. Sponsored-by: Waikato Institute of Technology Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171142|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171172&action=edit Bug 23685: (follow-up) Dbrev for new preferences Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171143|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171173&action=edit Bug 23685: (follow-up) Add prefs to Administration form Test plan: Edit both prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171144|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171174&action=edit Bug 23685: (follow-up) Add export limit for guided reports Test plan: Set pref ReportsExportLimit to some positive integer. Test if exporting a report respects that limit. Run t/db_dependent/Koha/Reports.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171145|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171175&action=edit Bug 23685: (follow-up) Control ODS exporting The pref ReportsExportFormatODS should be true for exporting to ODS in Reporting. Test plan: Set pref to false value. Check if option is no longer available on report's Download menu. Manipulate URL with op=export&format=ods. No data expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #43)
(In reply to Katrin Fischer from comment #42)
Might be controversial... but our system preferences usually have no underscores, could we remove the one here? ReportingAllowsODS_Export
I agree - how about we call preference ExportFormatODS?
OK. Added prefix Reports to add context.
Also I noticed that patches saying "Reporting" to refer to the module, I think this should just be "Reports" as that's the name of the module button.
Fixed
Finally, there's a typo in the DBrev patches - "Reporing"
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171171|0 |1 is obsolete| | --- Comment #50 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171571&action=edit Bug 23685: Don't store ODS content in a variable to save memory Just attaching this to start. Sponsored-by: Waikato Institute of Technology Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171172|0 |1 is obsolete| | --- Comment #51 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171572&action=edit Bug 23685: (follow-up) Dbrev for new preferences Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171173|0 |1 is obsolete| | --- Comment #52 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171573&action=edit Bug 23685: (follow-up) Add prefs to Administration form Test plan: Edit both prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171174|0 |1 is obsolete| | --- Comment #53 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171574&action=edit Bug 23685: (follow-up) Add export limit for guided reports Test plan: Set pref ReportsExportLimit to some positive integer. Test if exporting a report respects that limit. Run t/db_dependent/Koha/Reports.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171175|0 |1 is obsolete| | --- Comment #54 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171575&action=edit Bug 23685: (follow-up) Control ODS exporting The pref ReportsExportFormatODS should be true for exporting to ODS in Reporting. Test plan: Set pref to false value. Check if option is no longer available on report's Download menu. Manipulate URL with op=export&format=ods. No data expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|m.de.rooy@rijksmuseum.nl |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #55 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Old links to ODS exports will fail with a 500 if the pref is off, would be nice to have a warning, even just in the logs, of what happened, but not a blocker here. The patch to exclude from plack was dropped, but that seems appropriate - systems can implement it locally if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33635 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This inspired me to work on bug 33635 - CSV export display broken diacritics in Excel I had a feeling we were just missing the BOM segment on our csv's and it looks like that was indeed the case. Well worth looking at that one too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens (kidclamp) from comment #55)
Old links to ODS exports will fail with a 500 if the pref is off, would be nice to have a warning, even just in the logs, of what happened, but not a blocker here.
The patch to exclude from plack was dropped, but that seems appropriate - systems can implement it locally if needed
Could you explain a bit more about when a library would want to implement this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #59 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #57)
(In reply to Nick Clemens (kidclamp) from comment #55)
Old links to ODS exports will fail with a 500 if the pref is off, would be nice to have a warning, even just in the logs, of what happened, but not a blocker here.
The patch to exclude from plack was dropped, but that seems appropriate - systems can implement it locally if needed
Could you explain a bit more about when a library would want to implement this?
So a library could exclude from Plack if they want to have a large export of all the rows. Plack buffers the whole response in a temporary file before sending any data back to Apache, which can cause timeouts. Whereas CGI/excluded from Plack will theoretically send the data back immediately to Apache (for non-ODS exports), although I think in practice it's a bit more complicated. See bug 31744 for an inventory.pl example. So it would be addressing a timeout problem rather than a memory problem. Maybe before Kohacon2025 I can keep working on my Mojolicious controller replacement for CGI scripts which solve the timeout problem without excluding from Plack. (The ODS export is a problem regardless because of the compressed nature of the ODS format and how OpenOffice::OODoc works.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply clean to 24.05.x, rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #61 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Why didn't we make it a dropdown with multi-select for the available formats instead? With a warning about ODS being dangerous? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #62 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Re-opening as the new system preferences need to be added to the Koha Manual. Release Maintainers: when deciding not to backport, please set the bug status as "Needs documenting". The Documentation team then reviews the bug to decide whether any changes need to be made to the Koha Manual. Please help us by using this status, otherwise some cool new developments will be completely missed for the Manual ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #63 from Aude Charillon <aude.charillon@openfifth.co.uk> --- New system preferences ReportsExportFormatODS and ReportsExportLimit added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org