[Bug 30303] New: Add ability to select which values to retain when merging patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Bug ID: 30303 Summary: Add ability to select which values to retain when merging patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When merging two patron records, one simply picks one record to retain values from. It would be helpful to have an interface more like what we see when merging biblio records, where one can select values from either pre-merge record to be retained post-merge. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- This would be great!!! +++++1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Elaine Bradtke <eb@efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org --- Comment #2 from Elaine Bradtke <eb@efdss.org> --- Important for libraries that allow self registration. Users create their own logins without linking to their existing card. If we try to merge the two, the login information (password, etc.) is lost. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 sys_admin@latahlibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sys_admin@latahlibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #3 from Rebecca Coert <rcoert@arlingtonva.us> --- This would be very useful, especially if the Registration Date field was included. I often merge newer accounts (with the correct information) for users that have returned, but have an old/expired account. It would be nice to keep their original registration date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Nancy M. <nmumford@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmumford@clamsnet.org --- Comment #4 from Nancy M. <nmumford@clamsnet.org> --- Our network offers self-registration and I merge many cards. I'm truly amazed this is not already an option when merging. Patrons who are registered more than once often have updated information that is not in the older record. This would be an important enhancement as more libraries are offering online registration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Eileen Chandler <echandler@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186382&action=edit Bug 30303: Add ui for copying values when merging patrons When merging two patrons this patch adds a new checkbox to 'Copy values from the record to be deleted' To test: - Apply patches and restart_all 1. From select two patrons and click 'Merge selected patrons' 2. Select one of the records 3. Check the new box to 'Copy values from the record to be deleted' 4. A diff of the two patrons is shown with checkboxes for each field 5. Confirm checking and un-checking the boxes updates the diff as expected 6. Confirm changing the patron selection updates the diff as expected. 7. Confirm un-checking and re-checking the Copy values from the record to be deleted resets the check boxes for the fields to copy 8. Select some fields to copy values and click merge patrons 9. Confirm the values were copied as expected Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186383&action=edit Bug 30303: Copy values to keeper record when merging patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186572&action=edit Bug 30303: (follow-up) Update diff highlighting instead of swapping columns This patch makes the ui more visually consistent and intuitive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #8 from Lari Taskula <lari.taskula@hypernova.fi> --- This is so cool! I noticed that after merging, if I hit the browser's back button, it takes me back to the field selection where I am once again able to select the fields to retain. Surprisingly, the new choices would still apply after hitting "Merge" the second time, even if Koha says "No valid patrons to merge were found.". But in some sense this feels more like a feature than a bug, because I might have forgotten to select something and this allows me to correct my error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 187269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187269&action=edit Bug 30303: (follow-up) Stop the back button from loading from cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Lari Taskula from comment #8)
This is so cool!
Thanks Lari!
I noticed that after merging, if I hit the browser's back button, it takes me back to the field selection where I am once again able to select the fields to retain. Surprisingly, the new choices would still apply after hitting "Merge" the second time, even if Koha says "No valid patrons to merge were found.". But in some sense this feels more like a feature than a bug, because I might have forgotten to select something and this allows me to correct my error.
This is sort of just the nature of the browser using a web app like Koha. Different browsers may behave differently too. I understand how in this case it could be confusing though. I think this might be better handled on the server side with HTTP Cache-Control headers like no-cache, no-store or must-revalidate, but this could also be done with javascript to force a reload when the browser's back button is used. I'm not sure if it's necessary, but the last patch forces a reload when you use the back button like this: // Stop the back button loading from cache window.onpageshow = function (e) { if (e.persisted) { window.location.reload(); } } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187269|0 |1 is obsolete| | --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 187295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187295&action=edit Bug 30303: (follow-up) Only copy values if merge returns results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- On second thought I think the better solution is to only copy the values if the merge returns results. That way if you use the back button you'll still see the page from the cache, but if you try to select more values to copy and submit the form again no values will be copied. That way the No valid patrons to merge were found message is accurate. Thanks for testing and feedback Lari! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186382|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187306&action=edit Bug 30303: Add ui for copying values when merging patrons When merging two patrons this patch adds a new checkbox to 'Copy values from the record to be deleted' To test: - Apply patches and restart_all 1. From select two patrons and click 'Merge selected patrons' 2. Select one of the records 3. Check the new box to 'Copy values from the record to be deleted' 4. A diff of the two patrons is shown with checkboxes for each field 5. Confirm checking and un-checking the boxes updates the diff as expected 6. Confirm changing the patron selection updates the diff as expected. 7. Confirm un-checking and re-checking the Copy values from the record to be deleted resets the check boxes for the fields to copy 8. Select some fields to copy values and click merge patrons 9. Confirm the values were copied as expected Sponsored-by: CLAMS Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186383|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187307&action=edit Bug 30303: Copy values to keeper record when merging patrons Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186572|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187308&action=edit Bug 30303: (follow-up) Update diff highlighting instead of swapping columns This patch makes the ui more visually consistent and intuitive Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187295|0 |1 is obsolete| | --- Comment #16 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 187309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187309&action=edit Bug 30303: (follow-up) Only copy values if merge returns results Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Lari Taskula <lari.taskula@hypernova.fi> --- We've just discovered that the merge is placing firstname as surname and vice versa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #18 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 189752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189752&action=edit Bug 30303: (follow-up) Split surname and firstname as separate fields To test: 1. Follow-original test plan 2. Observe "Name" field has now been split into "Surname" and "First name" fields 3. Merge patrons 4. Observe the selected surname and firstname have been preserved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- We could've of course just swapped the $name indices in merge-patrons.pl, but I think it is better to be very explicit with the fields we are selecting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #20 from Lari Taskula <lari.taskula@hypernova.fi> --- I also noticed that an empty field is represented with a hyphen (character -), which is okay, but when we select it to be retained, the hyphen actually gets inserted into the selected field. I think the expected behavior is to clear the field instead. Then again, although I'm not sure how realistic scenario it is, but someone may actually want to retain the hyphen, so we also shouldn't clear it in every case. Perhaps we should have a different value, for example an empty string, representing the field to be cleared. And if we receive and empty string in merge-patrons.pl, we should probably delete it from $data so that it never gets passed to $keeper->set() and does not uselessly become '' instead of NULL in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #20)
And if we receive and empty string in merge-patrons.pl, we should probably delete it from $data so that it never gets passed to $keeper->set() and does not uselessly become '' instead of NULL in the database. Correction, not to be deleted, but set as undef.
But I just noticed the diffString does not handle empty strings as I expected (just displaying an empty green/red box), so we need something else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #22 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing this some more Lari! I agree it's better to have the first name and surname as explicit separate fields. Thanks for finding the bug with the empty fields too. I will take another look and make a follow up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #23 from Lari Taskula <lari.taskula@hypernova.fi> --- We noticed that this doesn't support merging passwords from the source record to the destination record. Not sure if that is out of scope for this Bug, as the original merging functionality did not support it either. But it would be useful and I don't see why it couldn't be there. We can just display *** instead of the password hash. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #24 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the feedback Lari. The ability to copy the password would be useful, but I would prefer to get the basic functionality passed QA first and file a follow up bug for adding the ability to copy the password. I started working on the case to handle empty values and actual hyphens in the data and based on the way the diff works and how this patch was written it's a little gnarly. It might be better if instead of the form sending the values for each field to be copied, it just sends a 1 and the data for the fields to be copied is retrieved from the patron object on the backend. I think the same idea would work well for the copying the password too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |CLAMS list of Sponsors| | Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #25 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 197126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197126&action=edit Bug 30303: Add ui for copying values when merging patrons When merging two patrons this patch adds a new checkbox to 'Copy values from the record to be deleted' To test: - Apply patches and restart_all 1. From select two patrons and click 'Merge selected patrons' 2. Select one of the records 3. Check the new box to 'Copy values from the record to be deleted' 4. A diff of the two patrons is shown with checkboxes for each field 5. Confirm checking and un-checking the boxes updates the diff as expected 6. Confirm changing the patron selection updates the diff as expected. 7. Confirm un-checking and re-checking the Copy values from the record to be deleted resets the check boxes for the fields to copy 8. Select some fields to copy values and click merge patrons 9. Confirm the values were copied as expected Sponsored-by: CLAMS Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #26 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 197127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197127&action=edit Bug 30303: Copy values to keeper record when merging patrons Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #27 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 197128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197128&action=edit Bug 30303: (follow-up) Copy values from merge results instead of CGI This patch makes it so the values copied come from the merge results which fixes the case of copying empty values or - accurately. To test: 1. Have a patron with some empty fields and some fields with '-' 2. Follow the original test plan and try to copy those fields 3. confirm empty fields and '-' now copy as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187309|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #28 from Brendan Lawlor <blawlor@clamsnet.org> --- I squashed some commits to make this cleaner and fixed the case of copying empty values or hyphens. I looked into copying the password. It's very simple to add the ui to merge-patrons.tt like this: container.append( `<div class="row"> <div class="col"> <label for="Password"> <strong>Password:</strong> </div> <div class="col col2"><pre data-og="----"></pre></div> <div class="col col3"><pre data-og="****"></pre></div> <div class="col form-check"> <input type="checkbox" name="password" value="password" id="copypassword"> </div> </div>`); But it copying the password doesn't work like the other fields because it's encrypted so it has to be handled differently than the other fields in merge-patrons.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement provides release notes| |greater control over data | |preservation and | |streamlines the process of | |managing duplicate patron | |records. | | | |When merging two patron | |records, users can now | |selectively copy fields to | |retain from the record | |being deleted (source) into | |the record being kept | |(destination). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #29 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198118&action=edit Bug 30303: Add ui for copying values when merging patrons When merging two patrons this patch adds a new checkbox to 'Copy values from the record to be deleted' To test: - Apply patches and restart_all 1. From select two patrons and click 'Merge selected patrons' 2. Select one of the records 3. Check the new box to 'Copy values from the record to be deleted' 4. A diff of the two patrons is shown with checkboxes for each field 5. Confirm checking and un-checking the boxes updates the diff as expected 6. Confirm changing the patron selection updates the diff as expected. 7. Confirm un-checking and re-checking the Copy values from the record to be deleted resets the check boxes for the fields to copy 8. Select some fields to copy values and click merge patrons 9. Confirm the values were copied as expected Sponsored-by: CLAMS Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #30 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198119&action=edit Bug 30303: Copy values to keeper record when merging patrons Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #31 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198120&action=edit Bug 30303: (follow-up) Copy values from merge results instead of CGI This patch makes it so the values copied come from the merge results which fixes the case of copying empty values or - accurately. To test: 1. Have a patron with some empty fields and some fields with '-' 2. Follow the original test plan and try to copy those fields 3. confirm empty fields and '-' now copy as expected Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #33 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Laure <laure.roy@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |laure.roy@inlibro.com Resolution|--- |FIXED Documentation| |Laure Roy contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1248 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43664 [Bug 43664] Copying password from the source record when merging patrons -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org