[Bug 24884] New: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Bug ID: 24884 Summary: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When OpacAllowPublicListCreation is disabled (i.e. patrons are not allowed to create public lists from the OPAC), there shouldn't be a 'New list' button in the 'Public lists' tab. I am aware this does not enable patrons to create public lists, but it can be confusing, since it is in the 'Public lists' tab. To replicate: 1) In Administration > Global system preferences, search for OpacAllowPublicListCreation 2) Choose "Don't allow" and Save 3) Go to the OPAC and log into an account 4) In your account go to "your lists" 5) Click on the "Public lists" tab Note there is a 'New list' button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov --- Comment #1 from rkuiper@roundrocktexas.gov --- Agree. This is confusing to the patron. Rhonda K. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108414&action=edit Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108414|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 108416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108416&action=edit Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab. Works perfectly! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108416|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108425&action=edit Bug 24884: Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled This patch adds a check on the OpacAllowPublicListCreation system preference to the OPAC lists template so that if public list creation is disabled the "New list" button doesn't appear under the "Public lists" tab. To test, apply the patch and confirm that the virtualshelves preference is enabled. - With the OpacAllowPublicListCreation system preference enabled, go to the OPAC and view the lists page. - If you are logged in you should see a "New list" link under both the "Your lists" tab and the "Public lists" tab. - If you are not logged in you should see "Log in to create a new list" on both pages. - View the page with OpacAllowPublicListCreation disabled. - If you are logged in you should see a "New list" link under only the "Your lists" tab. - If you are not logged in you should see the "Log in" link only under the "Your lists" tab. Works perfectly! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org