[Bug 31986] New: Add page-section to various administration pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Bug ID: 31986 Summary: Add page-section to various administration pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 These admin pages need a page-section div to be added: additional-fields.tt aqbudgets.tt auth_subfields_structure.tt auth_tag_structure.tt authtypes.tt biblio_framework.tt checkmarc.tt classsources.tt currency.tt edi_accounts.tt edi_ean_accounts.tt items_search_fields.tt koha2marclinks.tt marc-overlay-rules.tt marc_subfields_structure.tt marctagstructure.tt matching-rules.tt oai_sets.tt smtp_servers.tt z3950servers.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142666&action=edit Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142666|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142671&action=edit Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off as the mentioned pages now have the page-sections. Some notes and observations - may need separate bugs if required/or have not yet been created. Needs div class: - OIA sets configuration > [OIA set] > Actions > Define mappings (http://127.0.0.1:8081/cgi-bin/koha/admin/oai_set_mappings.pl?id=1) Misaligned add and modify forms: - Authority types > New authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form) - Authority types > Modify authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form&authtypecode=GEOGR_NAME) - Add/modify forms in general: Submit / Cancel buttons area at bottom of form has extra white space before buttons, for example: New Z39.50 server Other: - Currencies and exchange rates: DataTables look is different from the standard look - EDI accounts: enable the EDIFACT system preference - Item search fields: first add works OK, trying to add another 'New search field' results in a blank page (http://127.0.0.1:8081/cgi-bin/koha/admin/items_search_fields.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, could you have a look at these again for possible follow-ups here? * h1 should not be inside page section for currencies * Item fields has 2 h1, which makes the heading inside the page section bigger than the first one * OAI sets: 3rd step, defining mappings is missing page section: admin/oai_set_mappings.pl?id=1 * Share contents with Hea: we usually put the h2+ now inside the page-section, but there is a lot of additional text on this screen between form and headings. Should these also be blocks? Some more notes, happy to file new bugs if they make some sense: * auth_subfields_structure.pl - The submit/cancel are in a separate 'block', I have also seen this on other pages. Should we make this a general rule for our style guide? * The save buttons for the 'new' actions on classification configuration are not 'centered'. There is a lot more white space to the top than to the bottom. Maybe a mark-up problem? Same for: admin/edi_accounts.pl?op=acct_form ... But: branch_transfer_limits.pl has no additional space on top and bottom. Maybe a 'part 2' bug for this one or did I miss the single bugs? * Missing - or maybe in another bug? ** Jobs ** circulation rules ** Patron attributes ** Cities ** Patron restrictions ** Debit types ** Credit types ** Cash registers ** Plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 31926 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
* h1 should not be inside page section for currencies
I didn't change this in my patch because presents a problem which needs to be addressed globally. Sometimes, as on this page, the H1 is inside a <legend>: <legend> <h1> <span>New currency</span> I want to look at how consistent we are with this structure and try to address it in another patch. item_search_fields.tt is a similar issue.
* auth_subfields_structure.pl - The submit/cancel are in a separate 'block', I have also seen this on other pages. Should we make this a general rule for our style guide?
This will be addressed in another bug, and should probably be covered in the style guide.
* The save buttons for the 'new' actions on classification configuration are not 'centered'. There is a lot more white space to the top than to the bottom.
This is essentially the same problem as the previous one.
Maybe a 'part 2' bug for this one or did I miss the single bugs?
This patch wasn't comprehensive, so more work remains to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
* auth_subfields_structure.pl - The submit/cancel are in a separate 'block', I have also seen this on other pages. Should we make this a general rule for our style guide?
See Bug 32022 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32028 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen's comments all make good sense. I filed for the remaining admin pages: Bug 32028 - Add page-section to various administration pages (part 2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142671|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142735&action=edit Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 [Bug 32126] Adding item search fields is broken - can't add more than one field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 Bug 31986 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org