[Bug 9961] New: Truncation and QueryAutoTruncate not working properly with new QueryParser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Bug ID: 9961 Summary: Truncation and QueryAutoTruncate not working properly with new QueryParser Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de CC: jcamins@cpbibliography.com I did some tests while working on bug 7518 and found that truncation seems not to work correctly when QueryParser is activated: START CONFIGURATION: Chr UseQueryParser Try QueryAutoTruncate only if * is added QueryFuzzy Try QueryStemming Try QueryWeightFields Enable TESTS: 1) NOT OK Keyword Geschichte 1236 Keyword Gesch* No results found! Keyword Gesch No results found! 2) OK UseQueryParser Do not try Keyword Geschichte 1236 Keyword Gesch* 1372 Keyword Gesch 1379 3) NOT OK UseQueryParser Try QueryAutoTruncate automatically Keyword Geschichte 1236 Keyword Gesch* No results found! Keyword Gesch No results found! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 17904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17904&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17904|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 17935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17935&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17935|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17976&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17976|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18010&action=edit [PASSED QA] Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Thx for fixing this Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Not needed for 3.10.x bug fix for new feature on 3.12.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #7 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 29866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29866&action=edit Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29866|0 |1 is obsolete| | CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #8 from Eric Bégin <eric.begin@inLibro.com> --- Comment on attachment 29866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29866 Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function Wrong bug number with git bz :( -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org