[Bug 24647] New: PDF::API2::Simple is declared as a required dependency but it is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Bug ID: 24647 Summary: PDF::API2::Simple is declared as a required dependency but it is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org `git grep PDF::API2::Simple` returns only one occurence, in cpanfile. `git log -S PDF::API2::Simple` returns a few commits that move around the declaration of dependencies, and the commit https://github.com/Koha-Community/Koha/commit/e418db57f9544983a004b6a7b7f79a... that introduces this dependency without using it. So it looks like it has been a required dependency for 10 years, without ever being used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 98777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98777&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98777|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 99067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99067&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Test plan: 1) Search for PDF::API2::Simple - git grep PDF::API2::Simple - there should be one result 2) Apply the patch 3) Search again 4) There should be no results 5) Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99067|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99128&action=edit Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24647 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x cpanfile does not contain the lines indicated to be removed anyways! not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org