https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91418&action=edit Bug 22209: Move stock rotation stage and item forms into modals This patch makes a number of interface changes to the Stock Rotation management interface: - "Add stage" and "Add items" forms are now triggered by clicking new buttons in the toolbar. - "Manage stages" and "Manage items" menu items have been added to a sidebar menu to be displayed when stages or items are being managed. - JavaScript has been added to move focus to the first form field in the modal when it is displayed. The "autofocus" attribute is not sufficent here because the modal is hidden by default. - Add messages to be shown when there are no items or stages to be displayed. - Correct "selected" attributes to use XHTML-style: selected="selected" (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates) To test, apply the patch and go to Tools -> Stock rotation. - Create a rota if you don't already have one. - Manage stages for your rota. - If your rota has no stages you should see a message along with an "Add stage" button. The button should trigger the "Add stage" modal. - Test the "Add stage" button in the toolbar. It should trigger a modal dialog containing the form for adding a new stage. The cursor focus should automatically be on the "library" field. - Submitting the form should correctly add the stage. - Verify that there is a new menu in the sidebar, "Manage stages" and "Manage items." - Manage items for your rota. - If your rota has no items you should see a message along with an "Add items" button. The button should trigger the "Add items" modal. - Test the "Add items" button in the toolbar. It should trigger a modal dialog containing the form for adding new items. The cursor focus should automatically be on the "barcode" field. - Submitting either a barcode or a file of barcodes should work correctly. - Verify that the new menu items are shown in the sidebar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91508|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92079&action=edit Bug 22209: Move stock rotation stage and item forms into modals This patch makes a number of interface changes to the Stock Rotation management interface: - "Add stage" and "Add items" forms are now triggered by clicking new buttons in the toolbar. - "Manage stages" and "Manage items" menu items have been added to a sidebar menu to be displayed when stages or items are being managed. - JavaScript has been added to move focus to the first form field in the modal when it is displayed. The "autofocus" attribute is not sufficent here because the modal is hidden by default. - Add messages to be shown when there are no items or stages to be displayed. - Correct "selected" attributes to use XHTML-style: selected="selected" (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates) To test, apply the patch and go to Tools -> Stock rotation. - Create a rota if you don't already have one. - Manage stages for your rota. - If your rota has no stages you should see a message along with an "Add stage" button. The button should trigger the "Add stage" modal. - Test the "Add stage" button in the toolbar. It should trigger a modal dialog containing the form for adding a new stage. The cursor focus should automatically be on the "library" field. - Submitting the form should correctly add the stage. - Verify that there is a new menu in the sidebar, "Manage stages" and "Manage items." - Manage items for your rota. - If your rota has no items you should see a message along with an "Add items" button. The button should trigger the "Add items" modal. - Test the "Add items" button in the toolbar. It should trigger a modal dialog containing the form for adding new items. The cursor focus should automatically be on the "barcode" field. - Submitting either a barcode or a file of barcodes should work correctly. - Verify that the new menu items are shown in the sidebar. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.