[Bug 25733] New: Return claims attention can't be cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Bug ID: 25733 Summary: Return claims attention can't be cleared Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The Attention notice on circulation.pl does not go down as claims are resolved, and there does not seem to be any way to reset this. The message won't even go away if you turn off the feature. This is very buggy. We need to have a way to remove a mistaken claim. We need to have a way to determine if certain types of resolutions count or don't count. This message should go away if claims returned is disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- That Attention note is a count of total lifetime claims. It will display as long as the count of claims is above the ClaimReturnedWarningThreshold value. I can use some use for a choice in whether or not this counts resolved claims. I've spoken to libraries who would argue either side, so I don't think we can settle on one definitive "correct" behavior here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25736 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- I guess part of the problem is my lack of understanding of what a "warning" should be. I thought the threshold limit would actually put up a warning box. I guess it kind of makes sense. I would also think that there would be an option somewhere to block checkout if the threshold was met. Maybe another feature soon? Anyway, now I understand. Thanks for clarifying this feature. Yes, an option to determine what counts and what doesn't would be a wise addition. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org --- Comment #3 from Daniel Gaghan <daniel.gaghan@pueblolibrary.org> --- Nuts, I was hoping that the claims returned threshold was for active claims... I guess we will need to delete them then after a few months. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- I did discover you can delete a claim. That little action doesn't show up in the action button until the claim is resolved. So, that is something. But you have to delete it altogether. Some folks might not like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- So maybe a system preference that determines whether or not resolved claims get counted toward that threshold? By the way, bug 25429 adds a function to cleanup_database to make resolved claims automatically delete after a number of days, which could help out somewhat here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If we add another pref, maybe we should make one for warning about active claims? That way we could have different limits for total and active and if only the active are to be counted the pref for resolved could be left empty. (hope that makes sense) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Ideally, I could see the following to be a benefit: * Preference about the warning behavior - Should it show in the warning panel or a banner - Should claims show counts for claims, or total claims and claims unresolved - Should total claims have resolved claims that don't count towards total claims - Should it block or not -- Should it block on total claims or claims unresolved - Should resolved claims have a moratorium - should they count against the patron for a set length of time or indefinitely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25901 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #8 from Rebecca Coert <rcoert@arlingtonva.us> --- (In reply to Katrin Fischer from comment #6)
If we add another pref, maybe we should make one for warning about active claims? That way we could have different limits for total and active and if only the active are to be counted the pref for resolved could be left empty. (hope that makes sense)
I agree. There should be a differentiation between the active vs. total claims. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #9 from Sam Lau <samalau@gmail.com> --- Created attachment 168678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168678&action=edit Bug 25733: Add new system preference 'UnresolvedClaimReturnedWarningThreshold' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #10 from Sam Lau <samalau@gmail.com> --- Created attachment 168679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168679&action=edit Bug 25733: Add warning for unresolved claims -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #11 from Sam Lau <samalau@gmail.com> --- Created attachment 168680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168680&action=edit Bug 25733: Unit tests prove t/db_dependent/Circulation/ReturnClaims.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168679|0 |1 is obsolete| | --- Comment #12 from Sam Lau <samalau@gmail.com> --- Created attachment 168681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168681&action=edit Bug 25733: Add warning for unresolved claims These patches add a new warning for unresolved claims that are larger than the number set by the new 'UnresolvedClaimReturnedWarningThreshold' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->system preferences, search for 'UnresolvedClaimReturnedWarningThreshold' and set this to '1' 3) Now search for 'ClaimReturnedLostValue' and set this to 'Lost' 4) Checkout some items for a patron 5) On the patron's checkout page, claim both these items as returned. 6) In the attention box, you should now see a 'Unresolved return claims: Patron has 2 unresolved RETURN CLAIMS'. 7) Visit patron details page, ensure the attention and message show up there as well. 8) Resolve one of these claims. Note that the message should disappear, as we set the sys pref to '1'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168681|0 |1 is obsolete| | --- Comment #13 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168759&action=edit Bug 25733: Add warning for unresolved claims These patches add a new warning for unresolved claims that are larger than the number set by the new 'UnresolvedClaimReturnedWarningThreshold' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->system preferences, search for 'UnresolvedClaimReturnedWarningThreshold' and set this to '1' 3) Now search for 'ClaimReturnedLostValue' and set this to 'Lost' 4) Checkout some items for a patron 5) On the patron's checkout page, claim both these items as returned. 6) In the attention box, you should now see a 'Unresolved return claims: Patron has 2 unresolved RETURN CLAIMS'. 7) Visit patron details page, ensure the attention and message show up there as well. 8) Resolve one of these claims. Note that the message should disappear, as we set the sys pref to '1'. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- I am wondering if we need 2 separate system preferences here. Can we not combine them into one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Kathleen <kkosiec@santabarbaraca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkosiec@santabarbaraca.gov --- Comment #15 from Kathleen <kkosiec@santabarbaraca.gov> --- I'm just chiming in to say I just noticed this bug and appreciate the efforts! It's definitely confusing for staff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168678|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179671&action=edit Bug 25733: Add new system preference 'UnresolvedClaimReturnedWarningThreshold' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168680|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179672&action=edit Bug 25733: Unit tests prove t/db_dependent/Circulation/ReturnClaims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168759|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179673&action=edit Bug 25733: Add warning for unresolved claims These patches add a new warning for unresolved claims that are larger than the number set by the new 'UnresolvedClaimReturnedWarningThreshold' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->system preferences, search for 'UnresolvedClaimReturnedWarningThreshold' and set this to '1' 3) Now search for 'ClaimReturnedLostValue' and set this to 'Lost' 4) Checkout some items for a patron 5) On the patron's checkout page, claim both these items as returned. 6) In the attention box, you should now see a 'Unresolved return claims: Patron has 2 unresolved RETURN CLAIMS'. 7) Visit patron details page, ensure the attention and message show up there as well. 8) Resolve one of these claims. Note that the message should disappear, as we set the sys pref to '1'. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179674&action=edit Bug 25733: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased and tidied, setting this one back to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179671|0 |1 is obsolete| | --- Comment #21 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180414&action=edit Bug 25733: Add new system preference 'UnresolvedClaimReturnedWarningThreshold' Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179672|0 |1 is obsolete| | --- Comment #22 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180415&action=edit Bug 25733: Unit tests prove t/db_dependent/Circulation/ReturnClaims.t Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179673|0 |1 is obsolete| | --- Comment #23 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180416&action=edit Bug 25733: Add warning for unresolved claims These patches add a new warning for unresolved claims that are larger than the number set by the new 'UnresolvedClaimReturnedWarningThreshold' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->system preferences, search for 'UnresolvedClaimReturnedWarningThreshold' and set this to '1' 3) Now search for 'ClaimReturnedLostValue' and set this to 'Lost' 4) Checkout some items for a patron 5) On the patron's checkout page, claim both these items as returned. 6) In the attention box, you should now see a 'Unresolved return claims: Patron has 2 unresolved RETURN CLAIMS'. 7) Visit patron details page, ensure the attention and message show up there as well. 8) Resolve one of these claims. Note that the message should disappear, as we set the sys pref to '1'. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179674|0 |1 is obsolete| | --- Comment #24 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180417&action=edit Bug 25733: (follow-up) Tidy Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |marion.durand@biblibre.com --- Comment #25 from Marion Durand <marion.durand@biblibre.com> --- I signed this one off but I think that https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25736 need to be taken care of at the same time. This is because with this patch, we have two message in Attention box (one for all return claims and one for active return claims). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Can we better move this to enh? The description sounded like a bug, but later comments seem to resolve that for some part. There is still some discussion here too btw, see last comment as just an example of that. We need feedback from the author. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trevor.diamond@mainlib.org --- Comment #27 from trevor.diamond@mainlib.org --- We've only been on Koha since March 2025, but several staff have commented on the situation in this bug. Looking forward to the fix! Let me know if I can do anything to help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #28 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marcel de Rooy from comment #26)
Can we better move this to enh? The description sounded like a bug, but later comments seem to resolve that for some part.
There is still some discussion here too btw, see last comment as just an example of that. We need feedback from the author.
Author of the bug or author of the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #26)
Can we better move this to enh? The description sounded like a bug, but later comments seem to resolve that for some part.
There is still some discussion here too btw, see last comment as just an example of that. We need feedback from the author.
We won't likely get feedback from Sam, he was a ByWater intern and that internship is now over. I do think this is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Change to enh -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org