https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170907&action=edit Bug 37774: Make MoveReserve check for patron holds even if none found by CheckReserve This patch moves the check for a patron's holds so that even if CheckReserve does not find the hold due to hold policies it can still be filled. The check will respect 'ConfirmFutureHolds' as per existing tests 1 - Set a "Default holds policy by item type" rule on "Mixed materials" to "No holds allowed" 2 - Add a Mixed Materials item on a record with items of 'Book' item types that are holdable 3 - Place a hold for a patron 4 - Check out the 'Mixed material' book to the patron (they are allowed to borrow these materials) 5 - The hold is not marked filled! Boo 6 - Check in the item and check out again 7 - The hold is filled! Yay 8 - Place another hold for the patron, with a future date set 9 - Checkout the item 10 - The hold is not filled! Yay 11 - Set 'ConfirmFutureHolds' to include the future hold placed above 12 - Checkin and checkout the item 13 - The hold is filled! Yay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170907|0 |1 is obsolete| | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 171484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171484&action=edit Bug 37774: Make MoveReserve check for patron holds even if none found by CheckReserve This patch moves the check for a patron's holds so that even if CheckReserve does not find the hold due to hold policies it can still be filled. The check will respect 'ConfirmFutureHolds' as per existing tests 1 - Set a "Default holds policy by item type" rule on "Mixed materials" to "No holds allowed" 2 - Add a Mixed Materials item on a record with items of 'Book' item types that are holdable 3 - Place a hold for a patron 4 - Check out the 'Mixed material' book to the patron (they are allowed to borrow these materials) 5 - The hold is not marked filled! Boo 6 - Check in the item and check out again 7 - The hold is filled! Yay 8 - Place another hold for the patron, with a future date set 9 - Checkout the item 10 - The hold is not filled! Yay 11 - Set 'ConfirmFutureHolds' to include the future hold placed above 12 - Checkin and checkout the item 13 - The hold is filled! Yay Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Hanna Dehlin <hanna.dehlin@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hanna.dehlin@hkr.se --- Comment #6 from Hanna Dehlin <hanna.dehlin@hkr.se> --- This patch breaks wanted behavior for our library. An item that is not holdable should not be able to fill a hold. For example: We are a university library and for many of our titles we have two itemtypes: dayloan (not holdable, 1-day loan) and course literature (holdable, 3-week loan). A patron should be able to place and keep a hold for the course literature items and still be able to check out the dayloan item. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Stefan Berndtsson <stefan.berndtsson@ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |stefan.berndtsson@ub.gu.se --- Comment #7 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- Agreeing with Hanna. This should have a separate option instead of "No holds allowed" to trigger this behaviour. Something like "Fillable but no holds allowed" (except with a better label) for the specific combination of circulation rules that's relevant for the situation. I'm preemptively moving this to In Discussion since this patch may disrupt existing processes for a lot of libraries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37774 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.