[Bug 15299] New: Add delete confirmation for deleting saved reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Bug ID: 15299 Summary: Add delete confirmation for deleting saved reports Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: hbraum@nekls.org QA Contact: testopia@bugs.koha-community.org In pretty much all areas of Koha, if you delete something (item, patron, setting, authorised values, etc.) you must confirm the deletion. When you delete a saved report, the report just deletes. Could a confirmation message be added, before the deletion happens? 1. Go to Saved Reports. 2. Create a new report and save it. 3. Go back to Saved Reports and find the report you just created . 4. Click on the Actions menu for that report, and choose Delete. 5. Note that the report deletes without a confirmation message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #1 from Heather Braum <hbraum@nekls.org> --- FYI: when you select multiple reports to delete from the saved SQL reports page, and click the "Delete selected" button, you do get a "Are you sure you want to delete the selected reports?" confirmation message. The issue is with individual report deletion -- no delete confirmation message is triggered there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Heather can you please check this again? In my tests 3.18.x and master there is already a delete confirmation warning. It is possible that a JavaScript error elsewhere on the page is short-circuiting the confirmation. Do you have custom JS in your staff client system preferences which might be causing problems? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same here, I cannot recreate on master. Heather, please provide more details if it still happens. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Status|RESOLVED |REOPENED Severity|minor |normal Resolution|INVALID |--- --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok got it! It happens when you want to delete a report which is not displayed initially (pagination). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46389&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Just noting that clicking the delete button from the Run, Edit, or Show views also doesn't prompt for confirmation. But this patch adds a confirm for deleting from the list, and that's good! Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46389|0 |1 is obsolete| | --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 46413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46413&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Confirm that there is now a confirmation on delete from the list -> action menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- adds back the confirm for ones that are not initially displayed, I mean -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Actually sorry I was wrong, it works fine on the show page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #9)
Actually sorry I was wrong, it works fine on the show page.
I have tested all others and they worked, please confirm you don't get the warn somewhere. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46413|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46428&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Confirm that there is now a confirmation on delete from the list -> action menu Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org