[Bug 20364] New: Show languages from MARC21 field 041 in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Bug ID: 20364 Summary: Show languages from MARC21 field 041 in intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org The encoded languages from MARC21 field 041 are not shown anywhere. These are quite important for example DVD video material (subtitle languages). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 72559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72559&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20245 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72559|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73363&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73364&action=edit Bug 20364: Follow up to correct koha qa test tool failure Plus, improve the perlcritic level beyond minimal. TEST PLAN --------- 1) apply first patch 2) run the script in a koha shell output to before.xml 3) run koha qa test tools -- script will fail. 4) perlcritic -3 on script is noisy. 5) apply this patch 6) run the script in a koha shell output to after.xml 7) a diff of these two output files should be identical 8) run koha qa test tools -- script will now pass 9) perlcritic -3 on script is OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73363|0 |1 is obsolete| | Attachment #73364|0 |1 is obsolete| | --- Comment #4 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 79858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79858&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Incorporated the QA fixes by M. Tompsett in this patch. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 arees@stlukes.nsw.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arees@stlukes.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Patch doesn't apply. The patch seems to erase all the record information in the Normal view tab. Title, author and contributor names, publisher, material type, description and other fields all disappear. Only the item information is displayed on screen (item, call number, status, location and barcode). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79858|0 |1 is obsolete| | --- Comment #6 from paxed <pasi.kallinen@koha-suomi.fi> --- Created attachment 90347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90347&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Adding Marcel to the CC list as my 'go to xslt guy'. Changes look sound to me so far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90347|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90845&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90845|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91394&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not totally fond of the ending . on the fields, but as there can be multiple labels on the same line, I can see why they were put there. Something to work later maybe. Also: There is no mention of the maintenance script in the commit message. Wondering how we can document this best. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds language release notes| |data from the 041 field of | |bibliographic records to | |both the search results and | |details pages of the staff | |client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 [Bug 23783] Show languages from MARC21 field 041 in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #13 from Pablo AB <pablo.bianchi@gmail.com> --- When 041 $a (Language code of text/sound track or separate title) is associated with the LANG authorized value list, then the detail view of the record (OPAC and Intranet) show an "Unknown language code", even if the value of the subfield is a valid language code. This text comes from MARC21Languages.xsl. This behavior was expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pablo AB from comment #13)
When 041 $a (Language code of text/sound track or separate title) is associated with the LANG authorized value list, then the detail view of the record (OPAC and Intranet) show an "Unknown language code", even if the value of the subfield is a valid language code. This text comes from MARC21Languages.xsl.
This behavior was expected?
Hm, I think I know why that happens: When you link an authorised value to a field in cataloguing, Koha will manipulate the XML and switch the codes for the descriptions. So then we end up with an 'unknown language code'. Maybe we could change up the XSLT so it displays the 'code' if it can't locate a matching description. Could you file a new bug? This has been released, so we need a new bug number to work on this. They can be linked using the 'depends'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25082 [Bug 25082] Unknown language code if 041 $a is linked to an authorized value list -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org