https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check out error made by the |Return focus to barcode |cursor not returning at |field after toggling |"enter item barcode" space |on-site checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58566&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58566|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58651&action=edit [SIGNED-OFF] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To be consistent should not we have the same behaviour for "Automatic renewal"? I personally don't really like that kind of custom javascript, especially when that can be achieve by filling the intranet js pref. But I am not behind a circulation desk :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63038|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 63136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63136&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 63145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63145&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63145|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63213&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking boxes in the "checkout settings" panel the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable OnSiteCheckouts and decreaseLoanHighHolds system preferences. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the label or checkbox for "Automatic renewal", "Don't decrease checkout length based on holds" and "On-site checkout" - Confirm that the focus has moved to the barcode field. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. Marked as enhancement, but I think it might be annoying enough to qualify as a but for some. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.