[Bug 21710] New: Typo: atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Bug ID: 21710 Summary: Typo: atributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Typo "atributes" should be "attributes" installer/data/mysql/en/optional/patron_atributes.txt:Useful patron atribute types: also misc/import_patrons.pl has the same typo in a parameter name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84938&action=edit Bug 21710: Fix typo in atributes in installer Adds the missing t to some atributes in the web installer files. To test: Easiest to verify by looking at the patches, changes appear in comments and the text shown by the nb-NO and English web installer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84939&action=edit Bug 21710: Fix typo in option of import_patrons.pl Fix typo in 'p|preserve-extended-atributes' option of the import_patrons.pl script. To test: - Use the script to import patron data. - Verify behaviour is the same with and without the patch concerning the preserve-extended_at(t)tributes option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've split the changes into 2 patches: - The changes to the installer are easy and will only effect display. - The change to the parameter of the script is trickier - it will break the use of the script for people having it automated with the typo... not sure what to do here. First thing I will do is moving the issue to a separate bug 22299. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Typo: atributes |Fix typo atributes in some | |installer files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84938|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85015&action=edit Bug 21710: Fix typo in atributes in installer Adds the missing t to some atributes in the web installer files. To test: Easiest to verify by looking at the patches, changes appear in comments and the text shown by the nb-NO and English web installer. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call splitting the bug into two.. This half is nice and trivial and doesn't introduce any regressions.. Going straight for PQA here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org