https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165481&action=edit Bug 36684: Prevent users from cancelling an order if it has uncertain prices To test: 1. Create a basket 1. Add an item to the basket from an existing record 1. When adding the item, under accounting details select “Uncertain price”. Save the item. 2. Notice that under the RRP tax exc. column the price has an “Uncertain” label. Under the ‘Cancel order’ column you also have the ability to “Cancel order” 3. Cancel the order. A new “Cancelled orders” table will appear under the “Orders” table. The item in the “Cancelled orders” table is greyed out and does not show any information regarding the “Uncertain price” label. 4. The basket remains a “problem” basket despite it not having any active items with uncertain prices. 2. Apply the patch and restart_all 3. Create a new basket 1. Add an item to the basket from an existing record 1. When adding the item, under accounting details select “Uncertain price”. Save the item. 2. Notice that under the RRP tax exc. column the price has an “Uncertain” label. 3. Under the ‘Cancel order’ column you now see a message that says, “Can’t cancel order because it contains uncertain prices.” 4. Click on the “Uncertain prices” tab and uncheck the ‘Uncertain’ box. Save and head back to your basket. 5. You are now able to “Cancel order” since the item no longer has an uncertain price. 2. Add a second item to the basket from an existing record. 1. Do not select “Uncertain price”. Save the item. 2. Under the ‘Cancel order’ column you have the ability to “Cancel order” 4. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I don't understand your proposed solution. Is there something inherently undesirable about cancelling an order with an uncertain price? Why should we require the user to clear the uncertain price if they're just going to cancel the order? I would suggest an alternate solution: if an order with an uncertain price is cancelled, we could automatically clear the uncertain price flag before cancelling the order. We'd prevent the unclearable "problem" on the basket without creating more work for the user. If you prefer your current solution, you need to deal with the "Cancel order and delete catalog record" button. As your patch stands, I'm still able to click "cancel order and delete record," which still hits your described issue of leaving the basket flagged as a problem. -- You are receiving this mail because: You are watching all bug changes.