[Bug 16080] New: Remove unused images from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bug ID: 16080 Summary: Remove unused images from the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 16020, 16023, 16025, 16027, 16032, 16043, 16045, 16046, 16059, 16071 I've identified quite a few images which are no longer used or will be made obsolete by bugs identified as dependencies here: koha-tmpl/intranet-tmpl/prog/img/cart.gif koha-tmpl/intranet-tmpl/prog/img/checkall.gif koha-tmpl/intranet-tmpl/prog/img/clear-field.png koha-tmpl/intranet-tmpl/prog/img/clone-field.png koha-tmpl/intranet-tmpl/prog/img/dropshadow-alpha.png koha-tmpl/intranet-tmpl/prog/img/dropshadow-mask.gif koha-tmpl/intranet-tmpl/prog/img/dropshadow.gif koha-tmpl/intranet-tmpl/prog/img/glyphicons-halflings-koha.png koha-tmpl/intranet-tmpl/prog/img/glyphicons-halflings-white-koha.png koha-tmpl/intranet-tmpl/prog/img/more-arrow.gif koha-tmpl/intranet-tmpl/prog/img/more-up-arrow.gif koha-tmpl/intranet-tmpl/prog/img/more.gif koha-tmpl/intranet-tmpl/prog/img/print-confirm.gif koha-tmpl/intranet-tmpl/prog/img/regularDay.jpg koha-tmpl/intranet-tmpl/prog/img/regularHoliday.jpg koha-tmpl/intranet-tmpl/prog/img/repeatable.jpg koha-tmpl/intranet-tmpl/prog/img/search-audio-books.gif koha-tmpl/intranet-tmpl/prog/img/search-books.gif koha-tmpl/intranet-tmpl/prog/img/search-kids.gif koha-tmpl/intranet-tmpl/prog/img/search-large-print.gif koha-tmpl/intranet-tmpl/prog/img/search-local-history.gif koha-tmpl/intranet-tmpl/prog/img/search-movies.gif koha-tmpl/intranet-tmpl/prog/img/search-music.gif koha-tmpl/intranet-tmpl/prog/img/search-reference.gif koha-tmpl/intranet-tmpl/prog/img/search-software-web.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-add-to-shelf.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-delete.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-duplicate.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-edit.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-hold.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-new.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-orders.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-password.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-print.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-receive.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-renew.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-save.gif koha-tmpl/intranet-tmpl/prog/img/toolbar-search.gif Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16020 [Bug 16020] Remove unused CSS and images following label creator UX changes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16023 [Bug 16023] Use Font Awesome icons on audio alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16025 [Bug 16025] Use Font Awesome icons on item types localization page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 [Bug 16027] Use Font Awesome icons in the professional cataloging interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16032 [Bug 16032] Use Font Awesome icon in "note" styled divs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16043 [Bug 16043] Use Font Awesome icon in hold confirmation dialog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 [Bug 16045] Use Font Awesome icons in OAI sets administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16046 [Bug 16046] Use Font Awesome icons on patron edit pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16059 [Bug 16059] Use Font Awesome icons in standard cataloging duplicate warning dialog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 [Bug 16071] Use Font Awesome icons in authority record duplicate warning dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 [Bug 16206] Template changes made by EDI feature should use Font Awesome icons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bug 16080 depends on bug 16206, which changed state. Bug 16206 Summary: Corrections to templates related new EDI feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16241 [Bug 16241] Move staff client CSS out of language directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50590&action=edit Bug 16080 - Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Testing on top of Bug 16241: git grep glyphicons-halflings-koha.png koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt (line 28) The file contains more references, e.g. cart-small.gif (not in list in this patch) All others in list are OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50590|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50837&action=edit Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50837|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50846&action=edit [SIGNED-OFF] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of Bug 16241 No reference of deleted files (only on PO files but that will be fixed later) No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50846|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50893&action=edit [PASSED QA] Bug 16080 [Revised] Remove unused images from the staff client This patch removes images from the staff client templates which are no longer used. To test you must (as of 2016-04-22) apply the patch for Bug 16241. Apply the patch and search for references in the Koha code to the removed images. You should find none. The staff client CSS file has been updated to remove obsolete references to image files. These old styles were made obsolete by the switch to Font Awesome icons. Revision removes reference to glyphicons-halflings-koha.png from circ/offline-mf.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of Bug 16241 No reference of deleted files (only on PO files but that will be fixed later) No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org