[Bug 15757] New: Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bug ID: 15757 Summary: Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A library reported recently that an item with circulation period set to 0 for all patron categories with a few exceptions set was checked out and was given a checkout period of 21 days. This comes from the last lines in the GetLoanLength subroutine: 1475 # if no rule is set => 21 days (hardcoded) 1476 return { 1477 issuelength => 21, 1478 renewalperiod => 21, 1479 lengthunit => 'days', 1480 }; 1481 This should fire a1475 # if no rule is set => 21 days (hardcoded) 1476 return { 1477 issuelength => 21, 1478 renewalperiod => 21, 1479 lengthunit => 'days', 1480 }; 1481 warning and/or stop the checkout rather than defaulting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, there is no difference between the 2 snippets you paste :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha ok, "this should fire a warning" :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We could change the different occurrences of if defined($loanlength) && $loanlength->{issuelength}; with if defined($loanlength) && defined $loanlength->{issuelength}; To take into account the "0". And do not default to 0 when defining the circ rules but NULL instead. The only problem is that these behavior changes could be considered as a bug for existing installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I suppose a syspref then? CircRuleUndefinedCheckout: Yes/No/Warn CircRuleUndefinedCheckoutPeriod: default(21) So default is 'Yes/Allow' for 21 days? (In reply to Jonathan Druart from comment #3)
We could change the different occurrences of if defined($loanlength) && $loanlength->{issuelength}; with if defined($loanlength) && defined $loanlength->{issuelength}; To take into account the "0". And do not default to 0 when defining the circ rules but NULL instead.
The only problem is that these behavior changes could be considered as a bug for existing installations.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would consider it more an enhancement than as a blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
I would consider it more an enhancement than as a blocker
I could go for a lesser bug status, but I definitely think the expectation of a library setting the checkout period to zero is not a fall back to default rules or 21 days, I think it is expected that the item will not be checked out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- I would definitely call this a bug. We were scratching our heads trying to figure out where the 21 days came from. What would be preferable is when something like this is overridden and does not have a defined loan period it should prompt you. Something like: This item does not have a set loan period. When would you like it due? If a due date is specified already by staff, it should show that date as a suggestion, otherwise show today's date. Staff could alter the date on that prompt or just use the date shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Better yet, when asked if you want to override, it could say: Do you want to override with a due date of xx/xx/xxxx? YES / NO Again, defaulting to today, or the specified due date if set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Christopher, would you agree with the suggestion I made on comment 3? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8361 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13576 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #9)
Christopher, would you agree with the suggestion I made on comment 3?
I can't. The code is beyond my understanding. I don't know any of Koha's internal plumbing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #10)
(In reply to Jonathan Druart from comment #9)
Christopher, would you agree with the suggestion I made on comment 3?
I can't. The code is beyond my understanding. I don't know any of Koha's internal plumbing.
Basically it means that - 0 will be taken into account for 'Loan period' (issuelength) - and if not filled in the circ rules NULL will be inserted in the DB (instead of 0, which is the current behavior). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #11)
Basically it means that - 0 will be taken into account for 'Loan period' (issuelength) - and if not filled in the circ rules NULL will be inserted in the DB (instead of 0, which is the current behavior).
And what is the behavior of NULL? If 0 is being taken into account, then that is great. But I think we need to make clear what NULL will do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #12)
(In reply to Jonathan Druart from comment #11)
Basically it means that - 0 will be taken into account for 'Loan period' (issuelength) - and if not filled in the circ rules NULL will be inserted in the DB (instead of 0, which is the current behavior).
And what is the behavior of NULL?
If 0 is being taken into account, then that is great. But I think we need to make clear what NULL will do.
Nothing, another rule will be checked. And 0 will be returned (instead of 21) if no default rule is defined. That's why I have linked bug 13576 and bug 8361, a default rule has to be defined. I'd consider that outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #13)
Nothing, another rule will be checked. And 0 will be returned (instead of 21) if no default rule is defined. That's why I have linked bug 13576 and bug 8361, a default rule has to be defined. I'd consider that outside the scope of this bug.
Then I am in agreement with the change in comment 3. :) Thanks for walking me through it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #15 from Magnus Enger <magnus@libriotech.no> --- *** Bug 13576 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50013&action=edit Bug 15757: Add one test for GetLoanLength The usual call (3 params) of this subroutine was not tested. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50014&action=edit Bug 15757: Make GetLoanLength defaults to 0 instead of 21 GetLoanLength arbitrary defaulted to 21. The expected behavior seems to be to default on 0 (loan will be dued today). IMPORTANT NOTE: This patch will introduce a change in the behaviors for configuration with a 0 in issuelength. Before this patch, the rule with a issuelength==0 was skipped, now it's used! Test plan: 1/ Do not define any rule: the due date will be today (before this patch was +21 days) 2/ Define some rules which does not match the patron category, itemtype or branchcode: the due date will be today (before this patch was +21 days). 3/ Modify a rule to match the checkout and set issuelength=0: the due date will be today (before this patch, the rule was skipped) 4/ Modify this rule and set the issuelength to something > 0: the due date will be adjusted (same behavior as before this patch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50015&action=edit Bug 15757: Make issuelength default to null instead of 0 When editing circ rules, if the Loan period "issuelength" is not defined (empty string), the default value was 0, not it's inserted in the DB as NULL. Test plan: 1/ Create or edit a circ rule 2/ Do not fill the Loan period column 3/ Save => Without this patch, the value was 0 => With this patch it's now an empty string (in the DB it's set to NULL) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Important: Please test this patch deeply! @RMaint: Do NOT backport this patch set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 50015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50015 Bug 15757: Make issuelength default to null instead of 0 Review of attachment 50015: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15757&attachment=50015) ----------------------------------------------------------------- ::: admin/smart-rules.pl @@ +140,4 @@
$maxonsiteissueqty =~ s/\s//g; $maxonsiteissueqty = undef if $maxonsiteissueqty !~ /^\d+/; my $issuelength = $input->param('issuelength'); + $issuelength = $issuelength eq q{} ? undef : $issuelength;
Change 142 to: my $issuelength = $input->param('issuelength') // q{}; -- to avoid noise triggered when parameter is undef. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 50013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50013 Bug 15757: Add one test for GetLoanLength Review of attachment 50013: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15757&attachment=50013) ----------------------------------------------------------------- ::: t/db_dependent/Circulation_Issuingrule.t @@ +113,4 @@
maxissueqty => 5, maxonsiteissueqty => 4, finedays => 0, + lengthunit => 'days',
Why change to days? @@ -113,4 @@
maxissueqty => 5, maxonsiteissueqty => 4, finedays => 0, - lengthunit => 'Null',
I think the point was undef, but Data::Dumper puts out 'Null' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 50014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50014 Bug 15757: Make GetLoanLength defaults to 0 instead of 21 Review of attachment 50014: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15757&attachment=50014) ----------------------------------------------------------------- ::: t/db_dependent/Circulation_Issuingrule.t @@ +113,5 @@
+is_deeply( + C4::Circulation::GetLoanLength(), + $default, + "Without parameters, GetLoanLength returns hardcoded values" +);
This is an added test. If the number of tests to run is set, then you forgot to update it. @@ +360,3 @@
is_deeply( C4::Circulation::GetLoanLength(), + $default,
Nice clean up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #22)
Comment on attachment 50014 [details] [review] Bug 15757: Make GetLoanLength defaults to 0 instead of 21
Review of attachment 50014 [details] [review]: -----------------------------------------------------------------
::: t/db_dependent/Circulation_Issuingrule.t @@ +113,5 @@
+is_deeply( + C4::Circulation::GetLoanLength(), + $default, + "Without parameters, GetLoanLength returns hardcoded values" +);
This is an added test. If the number of tests to run is set, then you forgot to update it.
Don't know where does it come from, it's certainly a c/p issue. The number of expected tests is 10 and 11 are run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50014|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50029&action=edit Bug 15757: Make GetLoanLength defaults to 0 instead of 21 GetLoanLength arbitrary defaulted to 21. The expected behavior seems to be to default on 0 (loan will be dued today). IMPORTANT NOTE: This patch will introduce a change in the behaviors for configuration with a 0 in issuelength. Before this patch, the rule with a issuelength==0 was skipped, now it's used! Test plan: 1/ Do not define any rule: the due date will be today (before this patch was +21 days) 2/ Define some rules which does not match the patron category, itemtype or branchcode: the due date will be today (before this patch was +21 days). 3/ Modify a rule to match the checkout and set issuelength=0: the due date will be today (before this patch, the rule was skipped) 4/ Modify this rule and set the issuelength to something > 0: the due date will be adjusted (same behavior as before this patch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 [Bug 12787] Unit test files should be better organized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide follow-ups for what you think useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50013|0 |1 is obsolete| | --- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50131&action=edit [ISGNED-OFF] Bug 15757: Add one test for GetLoanLength The usual call (3 params) of this subroutine was not tested. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50015|0 |1 is obsolete| | --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50132&action=edit [SIGNED-OFF] Bug 15757: Make issuelength default to null instead of 0 When editing circ rules, if the Loan period "issuelength" is not defined (empty string), the default value was 0, not it's inserted in the DB as NULL. Test plan: 1/ Create or edit a circ rule 2/ Do not fill the Loan period column 3/ Save => Without this patch, the value was 0 => With this patch it's now an empty string (in the DB it's set to NULL) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50029|0 |1 is obsolete| | --- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50133&action=edit [SIGNED-OFF] Bug 15757: Make GetLoanLength defaults to 0 instead of 21 GetLoanLength arbitrary defaulted to 21. The expected behavior seems to be to default on 0 (loan will be dued today). IMPORTANT NOTE: This patch will introduce a change in the behaviors for configuration with a 0 in issuelength. Before this patch, the rule with a issuelength==0 was skipped, now it's used! Test plan: 1/ Do not define any rule: the due date will be today (before this patch was +21 days) 2/ Define some rules which does not match the patron category, itemtype or branchcode: the due date will be today (before this patch was +21 days). 3/ Modify a rule to match the checkout and set issuelength=0: the due date will be today (before this patch, the rule was skipped) 4/ Modify this rule and set the issuelength to something > 0: the due date will be adjusted (same behavior as before this patch) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, checked 1-4 All test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50131|0 |1 is obsolete| | Attachment #50132|0 |1 is obsolete| | Attachment #50133|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50513&action=edit Bug 15757: Add one test for GetLoanLength The usual call (3 params) of this subroutine was not tested. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50514&action=edit Bug 15757: Make issuelength default to null instead of 0 When editing circ rules, if the Loan period "issuelength" is not defined (empty string), the default value was 0, not it's inserted in the DB as NULL. Test plan: 1/ Create or edit a circ rule 2/ Do not fill the Loan period column 3/ Save => Without this patch, the value was 0 => With this patch it's now an empty string (in the DB it's set to NULL) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described. No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50515&action=edit Bug 15757: Make GetLoanLength defaults to 0 instead of 21 GetLoanLength arbitrary defaulted to 21. The expected behavior seems to be to default on 0 (loan will be dued today). IMPORTANT NOTE: This patch will introduce a change in the behaviors for configuration with a 0 in issuelength. Before this patch, the rule with a issuelength==0 was skipped, now it's used! Test plan: 1/ Do not define any rule: the due date will be today (before this patch was +21 days) 2/ Define some rules which does not match the patron category, itemtype or branchcode: the due date will be today (before this patch was +21 days). 3/ Modify a rule to match the checkout and set issuelength=0: the due date will be today (before this patch, the rule was skipped) 4/ Modify this rule and set the issuelength to something > 0: the due date will be adjusted (same behavior as before this patch) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, checked 1-4 All test pass No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50516&action=edit Bug 15757 [QA Followup] - Having EDI configured will make unit tests fail Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #33 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org