[Bug 13151] New: staff marc preview not wrapping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Bug ID: 13151 Summary: staff marc preview not wrapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 32796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32796&action=edit example marc preview in staff When you're in the staff client and click the marc preview you link you have to scroll left to right to see the whole thing because it doesn't wrap. In the OPAC it looks much cleaner. Could we use that layout in the staff client since the staff are the people who care about MARC - not the patrons. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33529&action=edit Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33529|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33551&action=edit Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm it works: nice modal dialog box; display aligned on opac display; works also with Unimarc biblios. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33551|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33796&action=edit [PASSED QA] Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a <pre> tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's "plainMARC.xsl" file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm it works: nice modal dialog box; display aligned on opac display; works also with Unimarc biblios. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org