[Bug 27569] New: marc-framework import function doesn't accept LibreOffice csv/ods file formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Bug ID: 27569 Summary: marc-framework import function doesn't accept LibreOffice csv/ods file formats Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: braun.kamilla@web.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The biblographic marc-framework import function does not except any of the ods-file format standards (i.e. 1.0/1.1; 1.2; 1.2 extended (compatibility-mode); 1.2 extended) used by LibreOffice. The csv-format stored by LibreOffice is also not usable. This makes the marc-framework export/import functions unusable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 braun.kamilla@web.de changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|critical |major --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What error do you get? Can you detail the different steps to recreate the problem? I am lowering the severity, it's not a critical issue, you can still use CSV. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #2 from braun.kamilla@web.de --- (In reply to Jonathan Druart from comment #1)
What error do you get?
there is no error report generated by koha, the marc-framework is empty after import, even though there is a lot of content in the ods/csv-file
Can you detail the different steps to recreate the problem?
You can recreate the problem by simply exporting an existing marc-framework to either csv- or ods-file, then opening it into LibreOffice, saving it with a different filename (still csv/ods-format), an then importing that file (without any changes made in the content) into koha.
I am lowering the severity, it's not a critical issue, you can still use CSV.
The CSV-import (saved by LibreOffice) is also not working. It suffers the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116164&action=edit Bug 27569: Remove non mysql code Remove a bit of the confusion by removing unless code (not related to mysql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116165&action=edit Bug 27569: Don't hide errors! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116166&action=edit Bug 27569: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116167&action=edit Bug 27569: Fix CSV export for biblio frameworks The CSV import of the biblio frameworks is broken. A change in LibreOffice resulted in CSV not formatted how the C4::ImportExportFramework code is expected. This code is quite broken, it expects all the CSV cells to be quoted. The "add tests" patch shows the different between what we expected before this patch, and what is the new version generated by LibreOffice. Test plan: Export a biblio framework in CSV Open it with LibreOffice and save it undef a different name Create a new biblio framework and use the new file to construct it Compare the 2 frameworks and make sure they are identical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116168&action=edit Bug 27569: Add tests for ODS export Looks ok so far -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116169&action=edit Bug 27569: Change av for 100$2 Switch from "#" to "" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116170&action=edit Bug 27569: Fix ODS export - take empty string into account If a cell contains an empty string it was not taken into account. Test plan: Same as CSV but with ODS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, can you add which LibreOffice version you have used for testing? I have tested a bit and the issue seems to be that we used to export "empty cell" with # in it, but we don't seem to do that with the authorised_value and see_also columns consistently anymore? When I add back the #, the file loads appears to be loading ok. I think making it work with empty cells would be better, but it could it have been a change in our export format causing this? I tested with an .ods file with Excel 2016 or LibreOffice 6.2.5.2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #10)
Hi Jonathan,
can you add which LibreOffice version you have used for testing?
Version: 6.1.5.2
I have tested a bit and the issue seems to be that we used to export "empty cell" with # in it, but we don't seem to do that with the authorised_value and see_also columns consistently anymore? When I add back the #, the file loads appears to be loading ok.
It's actually exporting what we have in DB: MariaDB [koha_kohadev]> select tagfield, authorised_value from marc_tag_structure where frameworkcode="" and tagfield in ("018", "020"); +----------+------------------+ | tagfield | authorised_value | +----------+------------------+ | 018 | | | 020 | NULL | +----------+------------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18143 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, there was a change made by bug 18143 that introduced the export behaviour change. But it's from Feb 2017! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143 [Bug 18143] Silence floody MARC framework export -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #12)
Ok, there was a change made by bug 18143 that introduced the export behaviour change. But it's from Feb 2017!
But pushed in Feb 2019! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #14 from braun.kamilla@web.de --- Dear Jonathan, Can you tell me, when the BUG-FIXED version of KOHA will be available for download. Thank you. Best Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At the moment we cannot give you a version this will be released with yet. It needs to go through the QA process first. The next step is that this needs to be tested by someone and changed to Signed Off. You can try and take on this step if you want, as this should work for testing on our sandboxes. The process is described here: https://wiki.koha-community.org/wiki/Sandboxes After the patch has been succesfully tested it will go to QA and someone from the QA team verifies if it meets our guidelines. Then it can be pushed and included in the next monthly bugfx release. As a workaroudn it might work if you replace empty cells with # to get your framework loaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116164|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116871&action=edit Bug 27569: Remove non mysql code Remove a bit of the confusion by removing unless code (not related to mysql) Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116165|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116872&action=edit Bug 27569: Don't hide errors! Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116166|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116873&action=edit Bug 27569: Add tests Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116167|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116874&action=edit Bug 27569: Fix CSV export for biblio frameworks The CSV import of the biblio frameworks is broken. A change in LibreOffice resulted in CSV not formatted how the C4::ImportExportFramework code is expected. This code is quite broken, it expects all the CSV cells to be quoted. The "add tests" patch shows the different between what we expected before this patch, and what is the new version generated by LibreOffice. Test plan: Export a biblio framework in CSV Open it with LibreOffice and save it undef a different name Create a new biblio framework and use the new file to construct it Compare the 2 frameworks and make sure they are identical Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116168|0 |1 is obsolete| | --- Comment #20 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116875&action=edit Bug 27569: Add tests for ODS export Looks ok so far Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116169|0 |1 is obsolete| | --- Comment #21 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116876&action=edit Bug 27569: Change av for 100$2 Switch from "#" to "" Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116170|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116877&action=edit Bug 27569: Fix ODS export - take empty string into account If a cell contains an empty string it was not taken into account. Test plan: Same as CSV but with ODS Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Ron Houk <rhouk@ottumwapubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |rhouk@ottumwapubliclibrary. | |org --- Comment #23 from Ron Houk <rhouk@ottumwapubliclibrary.org> --- I went through the test plan listed in comment #6 using LibreOffice 7.0.4.2 and the new framework appeared to be identical to the framework that was exported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116871|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116888&action=edit Bug 27569: Remove non mysql code Remove a bit of the confusion by removing unless code (not related to mysql) Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116872|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116889&action=edit Bug 27569: Don't hide errors! Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116873|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116890&action=edit Bug 27569: Add tests Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116874|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116891&action=edit Bug 27569: Fix CSV export for biblio frameworks The CSV import of the biblio frameworks is broken. A change in LibreOffice resulted in CSV not formatted how the C4::ImportExportFramework code is expected. This code is quite broken, it expects all the CSV cells to be quoted. The "add tests" patch shows the different between what we expected before this patch, and what is the new version generated by LibreOffice. Test plan: Export a biblio framework in CSV Open it with LibreOffice and save it undef a different name Create a new biblio framework and use the new file to construct it Compare the 2 frameworks and make sure they are identical Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116875|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116892&action=edit Bug 27569: Add tests for ODS export Looks ok so far Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116876|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116893&action=edit Bug 27569: Change av for 100$2 Switch from "#" to "" Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116877|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116894&action=edit Bug 27569: Fix ODS export - take empty string into account If a cell contains an empty string it was not taken into account. Test plan: Same as CSV but with ODS Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27968 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27968 [Bug 27968] MARC framework CSV and ODS import incomplete or corrupted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Without the patch, importing the CSV saved by LibreOffice crashes. DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "INSERT INTO marc_tag_structure (s,liblibrarian,libopac,repeatable,mandatory,authorised_value,ind1_defaultvalue,ind2_defaultvalue,frameworkcode,,,,,,,,,0,LEADER,LEADER,0,1,,,,,,,,,,,,,1,CONTROL [...] And the ODS saved by LibreOffice only import 101 fields instead of 348 So this patch is a great fix :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.16 --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- When checking the functionality of the patch, other issues have been found, see bug 27968 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27968 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27968 [Bug 27968] MARC framework CSV and ODS import incomplete or corrupted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27968 [Bug 27968] MARC framework CSV and ODS import incomplete or corrupted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27968 | --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- oops, I missed that "blocks 27968" was removed and I added it again thinking that I forgot in the first place. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27968 [Bug 27968] MARC framework CSV and ODS import incomplete or corrupted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #38 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It turns out that the following SQL error has been caught by tests in 19.11 koha_1 | DBD::mysql::st execute failed: Unknown column 'important' in 'field list' [for Statement "INSERT INTO marc_tag_structure (tagfield,liblibrarian,libopac,repeatable,mandatory,important,authorised_value,ind1_defaultvalue,ind2_defaultvalue,frameworkcode) VALUES (?,?,?,?,?,?,?,?,?,?) ON DUPLICATE KEY UPDATE tagfield=?,liblibrarian=?,libopac=?,repeatable=?,mandatory=?,important=?,authorised_value=?,ind1_defaultvalue=?,ind2_defaultvalue=?,frameworkcode=?" with ParamValues: 0='000', 1='LEADER', 2='LEADER', 3='0', 4='1', 5='0', 6='', 7='', 8='', 9='h8aS', 10='000', 11='LEADER', 12='LEADER', 13='0', 14='1', 15='0', 16='', 17='', 18='', 19='h8aS'] at /kohadevbox/koha/C4/ImportExportFramework.pm line 860, <$dom> line 2. https://jenkins.koha-community.org/job/Koha_19.11_D9/305/ Couldn't find where does it take the column "important" comes from though. Wait, it actually comes from the test data. t/db_dependent/data/frameworks/biblio_framework_no_quoted.csv Add patch fixing the test data has been pushed to 19.11.x https://git.koha-community.org/Koha-community/Koha/commit/eba92984ddf7fcc62a... Good thing that the previous patches made the import fail instead of silently doing something wrong when having a wrong structure to import. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org