https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That is because the module name on the summary table is not translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Difference in Koha module |Make module names on |names for notices linked to |letters overview page |Holds/Reserves |translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77724&action=edit Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77724|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77815&action=edit Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #4)

Should not we surround the strings with spans?

We could, but it's not necessary. The text will show up in the po file, because it's inside a parsed html element: <td> It will show up as one string, which can be good sometimes as it means you have more context. If we add <span> tags, they will all show up separately and might get merged with existing translations. So both versions have advantages. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thought a bit more about it - adding the spans will help translation more, as it will make them match with the strings from the pull down list. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77815|0 |1 is obsolete| | Attachment #77860|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77987&action=edit Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77989&action=edit Bug 19500: Add missing span for 'other' To stay consistent in the DOM structure it would make sense to have it there as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.