[Bug 31421] New: Library limitation on patron category breaks patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Bug ID: 31421 Summary: Library limitation on patron category breaks patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: * Log in under library A (Fairfield) * Limit one patron category (Patrons PT) to library B (Centerville) * Search for all patrons (empty search) * No results and there is an error in the console: Uncaught TypeError: categories_map[data] is undefined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31422 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 31686 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141468&action=edit Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141468|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 141479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141479&action=edit Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Non-limited categories is displayed in the "New patron" dropdown list https://snipboard.io/043TZt.jpg
The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons.
Is that correct? Yes I know I am the one who wrote bug 7919, but not the one who design it. And I have to admit I have no idea how it's supposed to work right now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Non-limited categories is displayed in the "New patron" dropdown list
Sorry, *limited* categories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142247&action=edit Bug 31421: Add a limited option to template plugin This adds a specific 'limited' routine to the Categories plugin, and uses it for the new patron dropdowns To test: 1 - Limit a patron category to some branches 2 - Sign in not at one of those 3 - Confirm the new patron dropdowns don't include the category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL Koha/Template/Plugin/Categories.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'limited' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142332&action=edit Bug 31421: (follow-up) Add POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141479|0 |1 is obsolete| | Attachment #142247|0 |1 is obsolete| | Attachment #142332|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142705&action=edit Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142706&action=edit Bug 31421: Add a limited option to template plugin This adds a specific 'limited' routine to the Categories plugin, and uses it for the new patron dropdowns To test: 1 - Limit a patron category to some branches 2 - Sign in not at one of those 3 - Confirm the new patron dropdowns don't include the category Bug 31421: (follow-up) Add POD Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142707&action=edit Bug 31421: Add tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 21.05.x not affected, no backport. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07, |22.11.00, 22.05.07 released in|21.11.14 | --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- revert on 21.11. bug actually not reproduced. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org