[Bug 16053] New: Edit the active currency removes its 'active' flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Bug ID: 16053 Summary: Edit the active currency removes its 'active' flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 15084
From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive
When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49004&action=edit Bug 16053: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49005&action=edit Bug 16053: Do not remove the active flag when editing the active currency
From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive
When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49004|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49045&action=edit [SIGNED-OFF] Bug 16053: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49005|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49046&action=edit [SIGNED-OFF] Bug 16053: Do not remove the active flag when editing the active currency
From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive
When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49045|0 |1 is obsolete| | Attachment #49046|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49340&action=edit [PASSED QA] Bug 16053: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49341&action=edit [PASSED QA] Bug 16053: Do not remove the active flag when editing the active currency
From commit b574b615919a6463708d4c1d7b1153a061c1ea0a Bug 15084: Make sure the previous active currency is marked as inactive
When a currency is stored, all the active flags of all currencies are unset. Only the active ones and different than the one we are editing should be updated. Test plan: Edit the active currency => Without this patch the active flag was removed => With this patch, the active flag is kept Edit another currency and set it the active flag => The active flag must have been removed from the previously active currency. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16053 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable version, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org