[Bug 20422] New: Working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Bug ID: 20422 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl Summary|Working title |Fix warn on URI/Escape.pm | |line 184 from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72952&action=edit Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72953&action=edit Bug 20422: Fix warning on uri_escape_utf8 in Output.pm When opac-details calls parametrized_url, it triggers an uninitialized warning when you would have a record without e.g. author, like: Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. This is (imo) actually a bug in URI::Escape; it should check its args. But we resolve the warning here by adding the "// q{}" in parametrized_url. NOTE: Along the way we do something similar in the arrParamsBusc loop. If the variable is undefined, jump to the next one. (Consistent with the approach in the if-part preceding it.) Test plan: [1] Run t/Output.t again. Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72952|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72954&action=edit Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72953|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72955&action=edit Bug 20422: Fix warning on uri_escape_utf8 in Output.pm When opac-details calls parametrized_url, it triggers an uninitialized warning when you would have a record without e.g. author, like: Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. This is (imo) actually a bug in URI::Escape; it should check its args. But we resolve the warning here by adding the "// q{}" in parametrized_url. NOTE: Along the way we do something similar in the arrParamsBusc loop. If the variable is undefined, jump to the next one. (Consistent with the approach in the if-part preceding it.) Test plan: [1] Run t/Output.t again. Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72954|0 |1 is obsolete| | Attachment #72955|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73210&action=edit Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73211&action=edit Bug 20422: Fix warning on uri_escape_utf8 in Output.pm When opac-details calls parametrized_url, it triggers an uninitialized warning when you would have a record without e.g. author, like: Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. This is (imo) actually a bug in URI::Escape; it should check its args. But we resolve the warning here by adding the "// q{}" in parametrized_url. NOTE: Along the way we do something similar in the arrParamsBusc loop. If the variable is undefined, jump to the next one. (Consistent with the approach in the if-part preceding it.) Test plan: [1] Run t/Output.t again. Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20422 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org