[Bug 32375] New: 22.05.07 failing t/AuthoritiesMarc_MARC21.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Bug ID: 32375 Summary: 22.05.07 failing t/AuthoritiesMarc_MARC21.t Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org t/AuthoritiesMarc_MARC21.t is failing on 22.05.07 Please see the output below: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/AuthoritiesMarc_MARC21.t t/AuthoritiesMarc_MARC21.t .. 1/5 # No tests run! t/AuthoritiesMarc_MARC21.t .. 5/5 # Failed test 'No tests run for subtest "FindDuplicateAuthority tests"' # at t/AuthoritiesMarc_MARC21.t line 62. DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI connect('database=koha_kohadev;host=localhost;port=3306','koha_kohadev',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /home/vagrant/kohaclone/Koha/Database.pm line 91. at /home/vagrant/kohaclone/Koha/Database.pm line 139 # Looks like your test exited with 255 just after 5. t/AuthoritiesMarc_MARC21.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/5 subtests Test Summary Report ------------------- t/AuthoritiesMarc_MARC21.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Files=1, Tests=5, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.57 cusr 0.17 csys = 1.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- It appears the tests added in bug 31023 have made this test db dependent now so it looks like it needs to be moved to t/db_dependent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- I dont think the tests can be written to work without a db, (and still test something) so shifting this file to t/db_dependent seems the only way forward. We will send a patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #3 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 144370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144370&action=edit bug 32375: moving t/AuthoritiesMarc_MARC21.t to t/db_dependent t/AuthoritiesMarc_MARC21.t is now db dependent so it needs to be in t/db_dependent to pass the tests Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |danyonsewell@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Hey all, I am having trouble making t/AuthoritiesMarc_MARC21.t fail on my 22.05.x branch. Maybe I missing a specific configuration that will make this fail? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #5 from wainuiwitikapark@catalyst.net.nz --- (In reply to Lucas Gass from comment #4)
Hey all,
I am having trouble making t/AuthoritiesMarc_MARC21.t fail on my 22.05.x branch.
Maybe I missing a specific configuration that will make this fail?
Hi Lucas, Can you start mysql and see if it fails then? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Thats right you have to have no db, so if you stop mariadb, or mysqlserver and run it will fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 145780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145780&action=edit Bug 32375: Move t/AuthoritiesMarc_MARC21.t to t/db_dependent t/AuthoritiesMarc_MARC21.t is now database dependent so it needs to be in t/db_dependent to pass the tests. Test plan (using koha-testing-docker): 1. If you run prove t/AuthoritiesMarc_MARC21.t without stopping the database, the tests will pass. To get the tests to fail: 1.1 Stop the database - from a new terminal window run: docker stop koha-db-1 1.2 In your Koha container run: prove t/AuthoritiesMarc_MARC21.t ==> The tests fail 8-( 2. Restart the database container from the terminal window you stopped it in: docker start koha-db-1 3. Apply the patch in the Koha container as normal. 4. Run: prove t/db_dependent/AuthoritiesMarc_MARC21.t ==> The test pass! 5. Sign off D: Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I tested with koha-testing-docker (KTD) and updated the commit message to format the bug title as expected by the QA Team and added the test plan I used. I hope what I've done is sufficient/correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #144370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145780|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 147811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147811&action=edit Bug 32375: Move t/AuthoritiesMarc_MARC21.t to t/db_dependent t/AuthoritiesMarc_MARC21.t is now database dependent so it needs to be in t/db_dependent to pass the tests. Test plan (using koha-testing-docker): 1. If you run prove t/AuthoritiesMarc_MARC21.t without stopping the database, the tests will pass. To get the tests to fail: 1.1 Stop the database - from a new terminal window run: docker stop koha-db-1 1.2 In your Koha container run: prove t/AuthoritiesMarc_MARC21.t ==> The tests fail 8-( 2. Restart the database container from the terminal window you stopped it in: docker start koha-db-1 3. Apply the patch in the Koha container as normal. 4. Run: prove t/db_dependent/AuthoritiesMarc_MARC21.t ==> The test pass! 5. Sign off D: Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, QA script happy, change looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.11 released in| | Status|Passed QA |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.11 |22.05.11, 21.11.19 released in| | Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org