[Bug 32127] New: Always sort patrpn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Bug ID: 32127 Summary: Always sort patrpn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Always sort patrpn |Sort patron categories by | |description in templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 143382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143382&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143382|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143391&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143391|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143815&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Failed QA --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Makes sense, needs regression tests though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed. I've tried to add in t/db_dependent/Template/Plugin/Categories.t. But I don't know how to manage the existing categories. Any help is welcome :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148890&action=edit Bug 32127: Add unit test Run prove t/db_dependent/Template/Plugin/Categories.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143815|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148891&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148890|0 |1 is obsolete| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148892&action=edit Bug 32127: Add unit test Run prove t/db_dependent/Template/Plugin/Categories.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- This works and tests pass. On /cgi-bin/koha/members/members-home.pl the dropdown sorts by description. If you click 'New patron', it sorts by description. If you are in '/members/memberentry.pl' and click the dropdown for 'Category:' it still sorts by code. I will sign-off here and we can address that in separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148891|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149099&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148892|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149100&action=edit Bug 32127: Add unit test Run prove t/db_dependent/Template/Plugin/Categories.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149099|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149364&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149100|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149365&action=edit Bug 32127: Add unit test Run prove t/db_dependent/Template/Plugin/Categories.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- conflicts on 21.11. can't backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11556 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11556 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org