[Bug 19816] New: output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Bug ID: 19816 Summary: output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 [Bug 18330] REST API: Date-time handling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Bug 19816 depends on bug 18330, which changed state. Bug 18330 Summary: REST API: Date-time handling https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Even if the RFC doesn't target date-only representations, full-date is proposed to be used in OpenAPI, so we should support it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|CLOSED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- OpenAPI specifies a format for date-only formatted strings (1). It basically specifies that for 'date' format, the 'full-date' profile needs to be used [2] Reopening. [1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dat... [2] https://tools.ietf.org/html/rfc3339#section-5.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|output_pref must raised an |output_pref must implement |exception if called with |'dateonly' for dateformat |dateformat => rfc3339 and > |=> rfc3339 |dateonly => 1 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84372&action=edit Bug 19816: Regression tests This patch adds tests for the rfc3339 behaviour when dateonly => 1. To test: - Run: $ kshell k$ prove t/DateUtils.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/DateUtils.t => FAIL: dateonly is not implemented -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84373&action=edit Bug 19816: Implement dateonly for rfc3339 format This patch implements the dateonly option for the rfc3339. This is described in the OpenAPI 2.0 specification [1]. The required output format is described on RFC 3339 [2], as 'full-date'. [1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dat... [2] https://tools.ietf.org/html/rfc3339#section-5.6 To test: - Apply the regression tests patch - Run: k$ prove t/DateUtils.t => FAIL: Tests fail because dateonly is not implemented - Apply this patch - Run: k$ prove t/DateUtils.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 [Bug 20006] Adapt /v1/holds to new naming guidelines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84372|0 |1 is obsolete| | Attachment #84373|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84393&action=edit Bug 19816: Regression tests This patch adds tests for the rfc3339 behaviour when dateonly => 1. To test: - Run: $ kshell k$ prove t/DateUtils.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/DateUtils.t => FAIL: dateonly is not implemented Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84394&action=edit Bug 19816: Implement dateonly for rfc3339 format This patch implements the dateonly option for the rfc3339. This is described in the OpenAPI 2.0 specification [1]. The required output format is described on RFC 3339 [2], as 'full-date'. [1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dat... [2] https://tools.ietf.org/html/rfc3339#section-5.6 To test: - Apply the regression tests patch - Run: k$ prove t/DateUtils.t => FAIL: Tests fail because dateonly is not implemented - Apply this patch - Run: k$ prove t/DateUtils.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 [Bug 22206] Add route to handle holds suspensions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84393|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84586&action=edit Bug 19816: Regression tests This patch adds tests for the rfc3339 behaviour when dateonly => 1. To test: - Run: $ kshell k$ prove t/DateUtils.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/DateUtils.t => FAIL: dateonly is not implemented Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84394|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84587&action=edit Bug 19816: Implement dateonly for rfc3339 format This patch implements the dateonly option for the rfc3339. This is described in the OpenAPI 2.0 specification [1]. The required output format is described on RFC 3339 [2], as 'full-date'. [1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dat... [2] https://tools.ietf.org/html/rfc3339#section-5.6 To test: - Apply the regression tests patch - Run: k$ prove t/DateUtils.t => FAIL: Tests fail because dateonly is not implemented - Apply this patch - Run: k$ prove t/DateUtils.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial enhancement, passes all tests. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18330 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org