[Bug 3098] New: XSLT stylesheet does not obey OPACURLOpenInNewWindow syspref
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 Summary: XSLT stylesheet does not obey OPACURLOpenInNewWindow syspref Product: Koha Version: rel_3_0 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: jmf@liblime.com ReportedBy: jwagner@ptfs.com Estimated Hours: 0.0 The OPACURLOpenInNewWindow syspref works if the XSLTDetailsDisplay syspref is turned off (i.e., if the system is not using the XSLT stylesheets). However, if the XSLTDetailsDisplay syspref is turned on, the system ignores the OPACURLOpenInNewWindow setting and opens URLs in the same window. The XSLT stylesheet needs to open this syspref if it is set. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 --- Comment #1 from Jane Wagner <jwagner@ptfs.com> 2009-07-24 16:24:53 --- Still haven't been able to figure out how to pass a syspref to the XSLT files and get it obeyed, but I did an interim hard-coded fix to force the OPAC to open URLs in new windows: Under koha-tmpl/opac-tmpl/prog/en/xslt, in MARC21slim2OPACDetail.xsl and MARC21slim2OPACResults.xsl, under the 856 section, search for the line <a><xsl:attribute name="href"><xsl:value-of select="marc:subfield[@code='u']"/></xsl:attribute> Change the beginning <a> as follows: <a target="_blank"> This is an interim fix until the larger problem of passing/obeying sysprefs gets solved. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 |PATCH-Sent --- Comment #2 from Jane Wagner <jwagner@ptfs.com> 2009-08-23 20:03:34 --- Sent patch combined with Bug 3108, Bug 3545. Modified C4/XSLT.pm based on code written by Frédéric Demians (thanks!) to pass the values of the sysprefs to the .xsl files. Modified the .xsl files to implement them. Now, if OPACURLOpenInNewWindow is on, the OPAC MARC21 XSLT results list and title display will open a URL in a new browser window. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 --- Comment #3 from Jane Wagner <jwagner@ptfs.com> 2009-08-23 20:11:10 --- Patch sent August 23, 2009. As a followup, in MARC21slim2OPACResults.xsl, there was a check for the 856 indicator 2 to be 0 before it would show the URL in the results list. There was no such check in the details xsl. The apparent intent was that if people consistently coded the 856 ind 2 correctly, the display would just show 856s with 2nd indicator of 0 on the results list, to include URLs that point directly to the resource, not alternative versions. I believe that many, if not most, sites may have either (1) incorrect settings on 856s migrated into Koha or (2) people creating records in Koha who don't know what indicators to use. Therefore, I deleted the check for 856 _0 in the results list. It will now show all 856s present in the record. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com AssignedTo|jmf@liblime.com |jwagner@ptfs.com Status|ASSIGNED |NEW --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> 2009-09-16 01:43:02 --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (2)
-
bugzilla-daemon@kohaorg.ec2.liblime.com -
bugzilla-daemon@liblime.com