[Bug 9953] New: When OpacMaintenance brakes lifting debarment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Bug ID: 9953 Summary: When OpacMaintenance brakes lifting debarment Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When OpacMaintenance is on, any opac page will redirect to maintenance.pl. Some pages of intranet have the same behavior : mancredit.pl maninvoice.pl setdebar.pl setstatus.pl This is because in checkauth, if type arg is undefined it is "opac" by default. Type arg must always be defined in intranet pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 17024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17024&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- this is a crazy bug. Good catch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17024|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 17040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17040&action=edit Bug 9953 - When OpacMaintenance brakes lifting debarment When OpacMaintenance is on, any opac page will redirect to maintenance.pl. Some pages of intranet have the same behavior and you get 404 error. This is because in checkauth, if type arg is undefined it is "opac" by default. This patch adds type arg in all intranet calls of checkauth. Test plan : - Set syspref OpacMaintenance=Show - Go to a borrower page - Click on "Fines" and "Create manual invoice" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Click on "Fines" and "Create manual credit" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Edit borrower - Set "Restricted" to yes and save - Click on "Lift restriction" in messages => Check you keep in member page and not maintenance.pl with 404 error OK - Edit borrower - Set "Expiry date" to a day in the past and save - Click on "Renew" in messages => Check you keep in member page and not maintenance.pl with 404 error OK Signed-off-by: Liz Rea <liz@catalyst.net.nz> Good catch, a tricky bug. http://bugs.koha-community.org/show_bug.cgi?id=9952 Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17043&action=edit Bug 9953 - When OpacMaintenance breaks lifting debarment When OpacMaintenance is on, any opac page will redirect to maintenance.pl. Some pages of intranet have the same behavior and you get 404 error. This is because in checkauth, if type arg is undefined it is "opac" by default. This patch adds type arg in all intranet calls of checkauth. Test plan : - Set syspref OpacMaintenance=Show - Go to a borrower page - Click on "Fines" and "Create manual invoice" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Click on "Fines" and "Create manual credit" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Edit borrower - Set "Restricted" to yes and save - Click on "Lift restriction" in messages => Check you keep in member page and not maintenance.pl with 404 error OK - Edit borrower - Set "Expiry date" to a day in the past and save - Click on "Renew" in messages => Check you keep in member page and not maintenance.pl with 404 error OK Signed-off-by: Liz Rea <liz@catalyst.net.nz> Good catch, a tricky bug. http://bugs.koha-community.org/show_bug.cgi?id=9952 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removed a few tabs from mancredit. All tests and QA script pass now. Good test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17040|0 |1 is obsolete| | Attachment #17043|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17044&action=edit [PASSED QA] Bug 9953 - When OpacMaintenance breaks lifting debarment When OpacMaintenance is on, any opac page will redirect to maintenance.pl. Some pages of intranet have the same behavior and you get 404 error. This is because in checkauth, if type arg is undefined it is "opac" by default. This patch adds type arg in all intranet calls of checkauth. Test plan : - Set syspref OpacMaintenance=Show - Go to a borrower page - Click on "Fines" and "Create manual invoice" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Click on "Fines" and "Create manual credit" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Edit borrower - Set "Restricted" to yes and save - Click on "Lift restriction" in messages => Check you keep in member page and not maintenance.pl with 404 error OK - Edit borrower - Set "Expiry date" to a day in the past and save - Click on "Renew" in messages => Check you keep in member page and not maintenance.pl with 404 error OK Signed-off-by: Liz Rea <liz@catalyst.net.nz> Good catch, a tricky bug. http://bugs.koha-community.org/show_bug.cgi?id=9952 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removed a few tabs from mancredit. All tests and QA script pass now. Good test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When OpacMaintenance brakes |When OpacMaintenance breaks |lifting debarment |lifting debarment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9953 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org