[Bug 21206] New: C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Bug ID: 21206 Summary: C4::Items - Remove GetItem Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Let's use Koha::Items! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77700&action=edit Bug 21206: Remove GetItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77701&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The whole dependency tree has been pushed to https://gitlab.com/joubu/Koha/commits/bug_21206 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is ready for testing, no test plan provided. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21252 [Bug 21252] Koha::Patron->do_check_for_previous_checkout should take Koha::Item as parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 77699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699 Bug 21206: Replace C4::Items::GetItem Review of attachment 77699: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21206&attachment=77699) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +615,5 @@
# Add renewal if possible my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber ); if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
+ my $issue = $item ? $item->checkout : return; # FIXME should be handled
This does not return.... ::: labels/label-edit-batch.pl @@ +87,4 @@
my @numbers_list = split /\n/, $number_list; # Entries are effectively passed in as a <cr> separated list foreach my $number (@numbers_list) { $number =~ s/\r$//; # strip any naughty return chars + if( $number_type eq "itemnumber" && Koha::ITems->find($number) ) {
ITems -> Items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Also QA tool fails: FAIL acqui/orderreceive.pl FAIL valid Global symbol "@items" requires explicit package name acqui/orderreceive.pl had compilation errors. FAIL catalogue/getitem-ajax.pl FAIL valid catalogue/getitem-ajax.pl had compilation errors. Global symbol "$item_unblessed" requires explicit package name FAIL misc/recreateIssueStatistics.pl FAIL forbidden patterns forbidden pattern: tab char (line 124) FAIL t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t FAIL valid syntax error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77699|0 |1 is obsolete| | Attachment #77700|0 |1 is obsolete| | Attachment #77701|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78081&action=edit Bug 21206: Remove GetItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78082&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 78080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080 Bug 21206: Replace C4::Items::GetItem Review of attachment 78080: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21206&attachment=78080) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +614,5 @@
if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
+ return unless $item; # FIXME should be handled + + my $issue = $item->checkout;
I see still little problem here: If item exists and is not checked out -> boom The check and return on item is done on line 610 here, so here should be "return unless $issue;" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78080|0 |1 is obsolete| | Attachment #78081|0 |1 is obsolete| | Attachment #78082|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78153&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78154&action=edit Bug 21206: Remove GetItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78155&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Bug 21206 depends on bug 21184, which changed state. Bug 21184 Summary: C4::Items - Remove GetBarcodeFromItemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Bug 21206 depends on bug 21205, which changed state. Bug 21205 Summary: C4::Acquisition - Remove GetOrderFromItemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78153|0 |1 is obsolete| | Attachment #78154|0 |1 is obsolete| | Attachment #78155|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82831&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82832&action=edit Bug 21206: Remove GetItem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82833&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82834&action=edit Bug 21206: (follow-up) Fix Circulation.t Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19884 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82831|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84006&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82832|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84007&action=edit Bug 21206: Remove GetItem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82833|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84008&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82834|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84009&action=edit Bug 21206: (follow-up) Fix Circulation.t Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84010&action=edit Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I reviewed the patches, everything looks good. I fixed minor issues too. Will mark PQA once I cover all the changes on the UI too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84006|0 |1 is obsolete| | --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84184&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84007|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84185&action=edit Bug 21206: Remove GetItem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84008|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84186&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84009|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84187&action=edit Bug 21206: (follow-up) Fix Circulation.t Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84010|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84188&action=edit Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Needs a rebase after removal of dropbox mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84184|0 |1 is obsolete| | Attachment #84185|0 |1 is obsolete| | Attachment #84186|0 |1 is obsolete| | Attachment #84187|0 |1 is obsolete| | Attachment #84188|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85163&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85164&action=edit Bug 21206: Remove GetItem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85165&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85166&action=edit Bug 21206: (follow-up) Fix Circulation.t Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85167&action=edit Bug 21206: (QA follow-up) Rebase problem and leftover mocked GetItem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85168&action=edit Bug 21206: Fix SwitchOnSiteCheckouts.t Fix conflict with commit f8544ba5799c457057d42aefc63c88e15a08b096 Bug 21999: Move attributes to a variable to not dup them Thanks tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 [Bug 22675] SCO broken on invalid barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21975 [Bug 21975] Unnecessary substitutions in automatic item modification by age -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22669 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22891 [Bug 22891] ILS-DI: RenewLoan explodes in error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Part of the ongoing effort release notes| |to improve the | |maintainability of our | |codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Part of the ongoing effort |Part of the ongoing effort release notes|to improve the |to improve the |maintainability of our |maintainability of our |codebase. |codebase. | | | |This patch-set | |removes the `GetItem` | |method from C4::Items and | |replaces any existing | |occurrences with | |`Koha::Items->search()`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|Part of the ongoing effort |Part of the ongoing effort release notes|to improve the |to improve the |maintainability of our |maintainability of our |codebase. |codebase. | | |This patch-set |This enhamcement |removes the `GetItem` |removes the `GetItem` |method from C4::Items and |method from C4::Items and |replaces any existing |replaces any existing |occurrences with |occurrences with |`Koha::Items->search()`. |`Koha::Items->search()`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Blocks| |22877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 [Bug 23985] The method Koha::Item-> is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 [Bug 24468] C4::Reserves::_get_itype is no longer used -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org