[Bug 11042] New: Color issue for selected tab under search box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Bug ID: 11042 Summary: Color issue for selected tab under search box Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ssammons@npelem.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 21975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21975&action=edit Image of color issue & element inspector. When trying to customize colors for the staff/admin area you will encounter a color code marked with !important in the CSS staff-global.css. Upon copying the CSS code block and making changes to the color, the staff-global.css color will over ride your select, even with important left on the color statement. Examples: ****My Custom Code:**** #header_search ul.ui-tabs-nav li.ui-tabs-selected { background-color: #FFFFF1; border: 1px solid #800000; !important; border-top: 0 !important; top: -1px; } ****staff-global.css code**** #header_search ul.ui-tabs-nav li.ui-tabs-selected { background-color : #FFFFF1; border: 1px solid #85CA11 !important; border-top: 0 !important; top: -1px; } Notes: I am using the Home › Administration › System preferences > intranetcolorstylesheet option for the CSS file to put my code it. Coding is done via SSH on the system level to my file called custom-login.css. I think the solution is just to remove the !important; statement off the code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Ketan Kulkarni <ketan@carvingit.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |ketan@carvingit.com Assignee|koha-bugs@lists.koha-commun |ketan@carvingit.com |ity.org | --- Comment #1 from Ketan Kulkarni <ketan@carvingit.com> --- Created attachment 22433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22433&action=edit Updated staff-global.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22433|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24411&action=edit Bug 11042: Updated staff global.css so that it does not override rules in custom.css Test plan: put \#header_search ul.ui-tabs-nav li.ui-tabs-selected { background-color: #FFFFF1; border: 1px solid #800000; !important; border-top: 0 !important; top: -1px; } in the pref IntranetUserCSS. Go on the intranet main page. Look at the borders of the selected tab in the search header. They should be burgundy-coloured. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, do you agree with this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I don't find that this patch solves the problem completely: The tab border color only changes on the sides, not on the bottom. Am I not seeing what you're seeing Jonathan? Removing instances of !important is a good goal in general, and I note that the latest version of jQueryUI doesn't have the same use of !important that 1.8.23 has. The real solution to this bug may be an upgrade to jQueryUI. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11570 Resolution|--- |MOVED --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I confirm this is fixed by bug 11570. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org