[Bug 30344] New: Changing a patron from a category that allows guarantors to one that doesn't should remove that link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Bug ID: 30344 Summary: Changing a patron from a category that allows guarantors to one that doesn't should remove that link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a child typo patron is changed to an adult type patron, it hides the patron's guarantors, but does not remove that link. We should be removing that link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changing a patron from a |Changing a patron from a |category that allows |category that allows |guarantors to one that |guarantees to one that |doesn't should remove that |doesn't should remove that |link |link -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Updated description: If an adult type patron is changed to a child type patron, it hides the patron's guarantees, but does not remove that link. We should be removing that link as we do when a guarantee becomes an adult type patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132117&action=edit Bug 30344: Changing a patron from a category that allows guarantees to one that doesn't should remove that link If an adult type patron is changed to a child type patron, it hides the patron's guarantees, but does not remove that link. We should be removing that link as we do when a guarantee becomes an adult type patron. Test Plan: 1) Create an adult with a guarantor 2) Turn that adult into a child patron tyupe 3) Note the guarantees show on the patron details, but not in the patron editor 4) Turn that patron back into an adult 5) Note the guarantees how again in the editor 6) Apply this patch 7) Restart all the things! 8) Turn that patron back into a child again 9) Note the guarantees no longer show on the patron details 10) Turn that patron back into an adult 11) Note the patron still has no guarantees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30351 [Bug 30351] Changing a patron type should warn librarian if a guarantor/guarantee relationship will be severed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Depends on| |12446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 [Bug 12446] Enable an adult to have a guarantor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Added a dependency on 12446, which just made it possible to have guarantors for adults. This patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132117|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143829&action=edit Bug 30344: Changing a patron from a category that allows guarantees to one that doesn't should remove that link If an adult type patron is changed to a child type patron, it hides the patron's guarantees, but does not remove that link. We should be removing that link as we do when a guarantee becomes an adult type patron. Test Plan: 1) Create an adult with a guarantor 2) Turn that adult into a child patron tyupe 3) Note the guarantees show on the patron details, but not in the patron editor 4) Turn that patron back into an adult 5) Note the guarantees how again in the editor 6) Apply this patch 7) Restart all the things! 8) Turn that patron back into a child again 9) Note the guarantees no longer show on the patron details 10) Turn that patron back into an adult 11) Note the patron still has no guarantees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Needs Signoff |RESOLVED --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I can no longer reproduce the original issue on master without these patches. Here's what I get before I apply any of this: 1: create a patron in a category where canbeguarantee=1 2: give that patron a guarantor, confirm it shows in details and editor 3: edit that patron to a category where canbeguarantee=0 4: confirm on details and in editor that patron's guarantor no longer shows 5: edit patron back to their original category 6: confirm their guarantor *still* doesn't show So I'm marking this resolved, Works for Me, but please adjust if you can reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- That said, please see bug 32195 and bug 32196 for issues where a patron category is edited and leaves un-editable relationships. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org