[Bug 16645] New: Plack: Add the multi_param fix from Context in koha.psgi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Bug ID: 16645 Summary: Plack: Add the multi_param fix from Context in koha.psgi Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51985&action=edit Bug 16645: Plack: Add the multi_param fix from Context in koha.psgi When you are running koha.psgi (under Wheezy with an older CGI), you will crash on multi_param calls (e.g. when searching in opac). This patch simply copies the fix from Context to koha.psgi. Test plan: Run Plack with koha.psgi and test searching in opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16644 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Hie, I'd say it depends on Bug 15809 directly no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- + no warnings 'redefine'; This is already set a few lines above. No ? + use warnings 'redefine'; sure we need this line ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #2)
Hie,
I'd say it depends on Bug 15809 directly no ?
Yes it does. But that has been pushed some time ago already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #3)
+ no warnings 'redefine'; This is already set a few lines above. No ?
+ use warnings 'redefine'; sure we need this line ?
No warnings was repeated. Will remove it and move the enable warns one level higher outside the if statement. It is better to add it. Only allow redefines without warnings within the section you have explicitly marked as such. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51985|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53161&action=edit Bug 16645: Plack: Add the multi_param fix from Context in koha.psgi When you are running koha.psgi (under Wheezy with an older CGI), you will crash on multi_param calls (e.g. when searching in opac). This patch simply copies the fix from Context to koha.psgi. Test plan: Run Plack with koha.psgi and test searching in opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Note that debian scripts work with plack only since jessie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16644 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16644 |15809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I'm testing : With the patch I get this warn : Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl line 527. Is it plack-specific ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #8)
I'm testing :
With the patch I get this warn :
Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl line 527.
Is it plack-specific ?
I am not seeing it in my log btw. How can I reproduce? Could be consequence of enabling the warnings again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #9)
Could be consequence of enabling the warnings again?
I'd say yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Closing this report. We are not supporting Wheezy anymore and there is no interest in this patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org