[Bug 40315] New: xt/tt_tidy.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Bug ID: 40315 Summary: xt/tt_tidy.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org 18:22:50 koha_1 | Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. 18:22:50 koha_1 | Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. 18:22:50 koha_1 | Something went wrong, Prettier generated an empty file. The original file was kept at misc/devel/tidy.pl line 112. This is because those 3 files are empty: koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/illview.inc koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc Is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Depends on| |38340 CC| |pjamorim91@gmail.com, | |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40444 Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184375&action=edit Bug 40315: Remove warnings from xt/tt_tidy.t Maybe we could remove the warnings from misc/devel/tidy.pl if the file was originally empty but for now it feels safer to skip the tidy of empty files Test plan: prove xt/tt_tidy.t xt/use-test-no-warnings.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The tests failed for me: prove xt/tt_tidy.t xt/use-test-no-warnings.t xt/tt_tidy.t ............... ok xt/use-test-no-warnings.t .. 1/2 # Failed test 'All Perl test files should contain Test::NoWarnings' # at xt/use-test-no-warnings.t line 58. # got: '8' # expected: '0' # The following test files should use Test::NoWarnings: # t/ImportBatch.t # t/db_dependent/Auth.t # t/db_dependent/Budgets.t # t/db_dependent/Koha/Patron.t # t/db_dependent/www/auth_values_input_www.t # t/db_dependent/www/batch.t # t/db_dependent/www/history.t # t/db_dependent/www/search_utf8.t # Looks like you failed 1 test of 2. xt/use-test-no-warnings.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- xt/use-test-no-warnings.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=2, Tests=862, 172 wallclock secs ( 0.03 usr 0.00 sys + 1335.50 cusr 411.00 csys = 1746.53 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, this one needs the patches under bug 25515. So you will need to apply the patches from bug 40371, bug 40379, bug 40401 and 18772 first. They do not apply using git-bz because 25515 is an omnibus and does not have patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184375|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 184426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184426&action=edit Bug 40315: Remove warnings from xt/tt_tidy.t Maybe we could remove the warnings from misc/devel/tidy.pl if the file was originally empty but for now it feels safer to skip the tidy of empty files Test plan: prove xt/tt_tidy.t xt/use-test-no-warnings.t should return green Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- xt/use-test-no-warnings.t .. 1/2 # Failed test 'All Perl test files should contain Test::NoWarnings' # at xt/use-test-no-warnings.t line 52. # got: '1' # expected: '0' # The following test files should use Test::NoWarnings: # t/db_dependent/api/v1/cash_registers.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #5)
xt/use-test-no-warnings.t .. 1/2 # Failed test 'All Perl test files should contain Test::NoWarnings' # at xt/use-test-no-warnings.t line 52. # got: '1' # expected: '0' # The following test files should use Test::NoWarnings: # t/db_dependent/api/v1/cash_registers.t
It's from bug 40444. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184426|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184614&action=edit Bug 40315: Remove warnings from xt/tt_tidy.t Maybe we could remove the warnings from misc/devel/tidy.pl if the file was originally empty but for now it feels safer to skip the tidy of empty files Test plan: prove xt/tt_tidy.t xt/use-test-no-warnings.t should return green Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184615&action=edit Bug 40315: (QA follow-up) Fix shebang for both tests Including chmod 755 xt/use-test-no-warnings.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Bug 40315 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Bug 40315 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Bug 40315 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 40444 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- Test suite related, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40315 Bug 40315 depends on bug 40444, which changed state. Bug 40444 Summary: Add a test to ensure all Perl test files use Test::NoWarnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org