[Bug 4904] New: Problem with printing fines in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Summary: Problem with printing fines in overdue notices Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 In 3.2 there is a new option to print the current fine in overdue notices. Documentation: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=599887a1855349de... While USD works fine, there is a problem with other currencies. I tested with EUR and GBP: <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>USD</fine></item> = ... Fine: $4.50 <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item> = ... Fine: £3.00 <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>EUR</fine></item> = â¬1,50 I see the same output in sent mails (Outlook) and in my database (Koha reports module and MySQL Query Browser) I have installed Locale::Currency::Format 1.28. Koha Version is 3.01.00.139. The overdue_notices.pl cronjob prints following error: Use of uninitialized value $fine in string at /home/koha/kohaclone/misc/cronjobs/overdue_notices.pl line 666. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2264 screenshot of currency symbols in notices before code change -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2265 screenshot of currency symbols in notices after code change -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2266 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- What perl version and locale did the problem manifest itself on? (I'm not seeing the original bug on perl 5.10.1 and en_GB.UTF-8) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, I have seen this problem on 2 different installations, an updated standard installation (3.01.61 to HEAD) and my dev install (HEAD) 9.10 Karmic Koala Perl version is 5.010000 Locale de_DE.UTF-8 Does my patch cause any problems? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- What version of Encode do you have? To check: perl -MEncode -e 'print $Encode::VERSION, "\n";' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- perl -MEncode -e 'print $Encode::VERSION, "\n";' - Result: 2.23 I updated the module to 2.39 via cpan and I still see the same problems with currency symbols. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-09-14 07:47:34 UTC --- Resend patch with small change, removing 2 additional lines as requested by Chris Cormack. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2266|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-09-14 07:49:53 UTC --- Created attachment 2621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2621 new patch with additional changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-11 20:14:38 UTC --- Patch was pushed to 3.2. Euro symbol is now shown correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org