[Bug 5072] New: Clicking 'order' on a z39.50 search result causes a 500 error.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Summary: Clicking 'order' on a z39.50 search result causes a 500 error. Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 To reproduce: 1) In acquisitions, add a new order to a basket 2) Select "From an external source" 3) Add some search terms, and hit search 4) On one of the results, hit 'order' 5) Fill out the 'new order' page 6) Watch the system fail and say "Mandatory parameter budget_id missing at /usr/share/koha/lib/C4/Acquisition.pm line 903." Note: this only happens if you have no budgets defined. Expected result: You can't get past step 2, because koha pipes up and says "hey, add some budgets first." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking 'order' on a |Filling an order page with |z39.50 search result causes |no budget defined causes a |a 500 error. |500 error -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 2433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2433 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5061 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Colin commented on bug 5061, that this bug is also related to 3616. Colin: 'The bug is related to 3616 but needs a separate fix. In Acquisitions.pm the error message is issued via a die. die is not a user friendly way to handle error conditions.' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- While I haven't tested it, I suspect that #3616 is solved by this as well, as this corrects the workflow to prevent the user getting to the point of trying to enter a new order if it would fail further down the track. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3616 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-13 20:25:16 UTC --- Hi Robin, your patch contains changes to a .gitignore file. Can you please resubmit without it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2433|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 21:43:23 UTC --- Created attachment 4802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4802 Bug 5072 - prevent creating new orders if there are no valid budgets On the basket editing screen, the links to add orders to a basket are hidden unless a valid fund is available. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 21:50:27 UTC --- Created attachment 4803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4803 Bug 5072 : Template changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4803|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 22:04:30 UTC --- Created attachment 4804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4804 [SIGNED-OFF] Bug 5072 : Template changes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4802|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 22:04:50 UTC --- Created attachment 4805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4805 [SIGNED-OFF] Bug 5072 - prevent creating new orders if there are no valid budgets On the basket editing screen, the links to add orders to a basket are hidden unless a valid fund is available. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 22:05:04 UTC --- Retested this on current master. If you try to save a order in acquisitions you get an alert now that you have to choose a fund first. If you have no funds defined, you can't save, but you don't get a perl error message any longer. With patch you can not add order line to a basket before you have created a fund and a budget. The patch does not check if you are allowed to spend on that budget. But it's an improvement over current behaviour. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4804|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 12:06:52 UTC --- Created attachment 4818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4818 proposed patch (passed QA) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4805|0 |1 is obsolete| | --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 12:08:33 UTC --- Created attachment 4819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4819 proposed patch (passed QA) QA comment: * patch addresses the problem * The 2nd patch also contains an undocumented fix in POD doc of the .pm. Thanks Katrin for fixing, shame for not saying it. Outside from this -very minor- comment, passed QA (+no DB change) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-04 01:55:29 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-15 20:03:59 UTC --- *** Bug 4111 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6994 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 15:59:05 UTC --- This works, but there is a small follow up to prevent the message from showing up on the 'order from suggestion' page (bug 6994) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org