[Bug 40827] New: Update plugin wrapper to include context for method="report"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Bug ID: 40827 Summary: Update plugin wrapper to include context for method="report" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Update koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.into include the reports menu and have the breadcrumbs list reports instead of admin/tools when method="report" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m Depends on| |31339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Makes sense. Having some regrets calling it "wrapper-staff-tool-plugin.inc" now heh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 188173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188173&action=edit Bug 40827: Add context to plugin wrapper for report plugins This patch updates the plugin wrapper to include the reports menu and have the breadcrumbs list reports instead of admin or tools when method="report" To Test: 1. Install the Kitchen Sink Plugin 2. Navigate to Reports->Report plugins->Run Report. 3. Observe the admin menu shows 4. Apply the patch 5. Repeat step 2 6. Observe the report menu shows and the breadcrumbs are for the report module. 7. Check that the tools and configuration show the appropriate tool/admin context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the plugin wrapper to | |include the reports menu | |and have the breadcrumbs | |list reports instead of | |admin or tools when | |method="report" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from David Cook <dcook@prosentient.com.au> --- The patch looks good at a glance, but the test plan doesn't work when using either the dev or non-dev Kitchen Sink Plugin v2.6.3. It looks like the templates are changed in the main branch, but not in a released version of the plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- That being said... I've hacked on my own plugin which uses the plugin wrapper and the change definitely works and it works well. If you can provide an updated test plan and get someone to sign off, I can QA this. It's a good change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Actually... this is such a small yet useful change... I think we might be able to leapfrog... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188173|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 188454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188454&action=edit Bug 40827: Add context to plugin wrapper for report plugins This patch updates the plugin wrapper to include the reports menu and have the breadcrumbs list reports instead of admin or tools when method="report" To Test: 1. Install the Kitchen Sink Plugin 2. Navigate to Reports->Report plugins->Run Report. 3. Observe the admin menu shows 4. Apply the patch 5. Repeat step 2 6. Observe the report menu shows and the breadcrumbs are for the report module. 7. Check that the tools and configuration show the appropriate tool/admin context. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from David Cook <dcook@prosentient.com.au> --- For people implementing this, you can pass the "method" via $template->{VARS}->{method} or you can hard-code it into your template like this: [% WRAPPER "wrapper-staff-tool-plugin.inc" method="report" plugin_title="Kitchen Sink Plugin: Patron List" %] They both work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40827 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting Version(s)|25.11.00 |25.11.00, 25.05.08 released in| | --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Backported to 25.05 thanks all! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org