[Bug 7128] New: logged in and logged out states of opac-main.tt are hard to style
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Bug #: 7128 Summary: logged in and logged out states of opac-main.tt are hard to style Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org It could use some ID's beyond the yui classes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-11-01 19:10:28 UTC --- Created attachment 6133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6133 Bug 7128 - adding some ID's to make styling opac-main.tt a bit easier To test: verify that the loggedin id is added when user is logged in verify that the notloggedin id is evident when no user is logged in. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |wizzyrea@gmail.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6133|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 02:44:48 UTC --- Created attachment 6156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6156 Bug 7128 - adding some ID's to make styling opac-main.tt a bit easier To test: verify that the loggedin id is added when user is logged in verify that the notloggedin id is evident when no user is logged in. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 02:45:03 UTC --- Created attachment 6157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6157 Bug 7128 : Follow up, adding the id to the case when a user is not logged in -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 02:45:15 UTC --- Liz your patch actually only sets the id for not logged in, when we don't allow login at all. Rather than if people are just not logged in, I have attached a follow up patch, to add the id to the other case (and fixed the formatting to make it clearer) can you take a look at that please? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_8 |master AssignedTo|oleonard@myacpl.org |wizzyrea@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6156|0 |1 is obsolete| | Attachment #6157|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-11-04 19:19:34 UTC --- Created attachment 6211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6211 Signed-off patches, squashed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-05 02:00:46 UTC --- Template only change, easy to read, marking as Passed QA. Huzzah for more IDs! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 11:00:43 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-11-07 14:39:00 UTC --- ah, I see that now, thanks all! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7128 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org