http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28201&action=edit Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28201|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29331&action=edit [SIGNED-OFF] Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29339&action=edit [PASSED QA] Bug 12237: Remove the "horrible hack" in C4::Templates Use C4::Languages::getlanguage() instead of C4::Templates::_current_language() Test plan: 1/ Set one of the 4 XSLT sysprefs to 'default' 2/ Go to the corresponding page 3/ Switch language and check that the right XSLT is used 4/ Set the same syspref to something with '{langcode}' in it. For example: "../koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/UNIMARCslim2OPACDetail.xsl" 5/ Go back to the corresponding page 6/ Switch language and check that the right XSLT is used 7/ Change a compact.xsl for a language (for example koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/compact.xsl) to be able to see differences 8/ Go to a biblio detail page in staff interface and click on "MARC Preview: Show" 9/ Close the popup, switch language and click again on the same link 10/ Check that the correct XSLT is used. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No problems found, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.