[Bug 28530] New: Allow configuration of floating limits by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Bug ID: 28530 Summary: Allow configuration of floating limits by item type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When return policy is set to Item Floats, it's possible for patron usage patterns to result in an imbalance in the collection -- more DVDs end up at Branch A and more books at Branch B. This can be especially troublesome when a given branch has limited shelving for a specific item type. I'd like to see a mechanism by which libraries can define a maximum count of items per item type to be allowed to float at a given branch. So, following my example above, Branch A could say that DVDs float when checked in but only up to 1000 items. If a DVD is checked in at Branch A and would be the 1001st DVD there, it instead transfers away. When some DVDs get checked out or transferred away, new returns will again be allowed to remain at Branch A. Setting the float limit to zero for a given item type and branch would make that item type always transfer away from that branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Christofer Zorn <christofer.zorn@ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #1 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- +1 We also would like to see this functionality added in. As we move to a more floating based system, we are going to rely on CollectionsHQ to tell us how to shift. It would be a great option to see this built into the ILS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Ashley Johnson <ajohnson@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org --- Comment #2 from carthur@slolibrary.org <carthur@slolibrary.org> --- We would also like this as a feature, it would be very helpful to have this as we are also using CollectionHQ to tell us how to shift our collections. -Charlie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160038&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160038|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160039&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160040&action=edit Bug 28530: Add Koha Object(s) for Float Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160041&action=edit Bug 28530: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160042&action=edit Bug 28530: Add float limits editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160043&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160044&action=edit Bug 28530: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160039|0 |1 is obsolete| | Attachment #160040|0 |1 is obsolete| | Attachment #160041|0 |1 is obsolete| | Attachment #160042|0 |1 is obsolete| | Attachment #160043|0 |1 is obsolete| | Attachment #160044|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160045&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160046&action=edit Bug 28530: Add Koha Object(s) for Float Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160047&action=edit Bug 28530: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160048&action=edit Bug 28530: Add float limits editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160049&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160050&action=edit Bug 28530: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I created a sandbox with these patches, but it doesn't seem to have the new table. I get the following error when I go to /cgi-bin/koha/admin/float_limits.pl: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_floatie.library_float_limits' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 317 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160045|0 |1 is obsolete| | Attachment #160046|0 |1 is obsolete| | Attachment #160047|0 |1 is obsolete| | Attachment #160048|0 |1 is obsolete| | Attachment #160049|0 |1 is obsolete| | Attachment #160050|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160053&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160054&action=edit Bug 28530: Add Koha Object(s) for Float Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160055&action=edit Bug 28530: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160056&action=edit Bug 28530: Add float limits editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160057&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160058&action=edit Bug 28530: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Note for testing: I confirmed that AutomaticItemReturn does control whether or not one can decline the transfers initiated by this feature. Issues: - Library float limits needs to be included in the admin nav sidebar - Allow value of zero -- currently, if you enter a zero it gets treated as a blank and no limit is saved. As described on the screen, a blank should mean float is not limited while a limit of zero would mean items of that type should always transfer away - rename "limit" field as it causes errors in writing reports unless you refer to the field with its full name (library_floating_limits.limit). Maybe "item_limit"? Transfer triggered for checkin that *meets* limit rather than exceeding it: - have a float limit set to 1 for Branch A - have 1 item of that item type at Branch A, giving ratio of 1 - check that item in at Branch A, get notified that this would put the library over its limit and the item will be transferred Ratio not correctly calculated for branches with zero items of type: - Have defined float limits for Branches: A = 1, B = 10, C = 100 - Have 1 item of limited type at Branch A, 1 at Branch B, zero at Branch C - Check 1 item in at Branch A - Koha directs the item to transfer to Branch B (ratio of .1) rather than Branch C (ratio of zero) Seems like we're only calculating a ratio where there is at least 1 item already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #24 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> ---
Transfer triggered for checkin that *meets* limit rather than exceeding it: - have a float limit set to 1 for Branch A - have 1 item of that item type at Branch A, giving ratio of 1 - check that item in at Branch A, get notified that this would put the library over its limit and the item will be transferred
Clarifying a little -- currently the patch *does* generate a transfer when a checked in item *meets* the floating limit. And I suppose that's what the text on screen says: "if the checkin library has reached its' limit for that type of item." That said, I feel like users may expect transfers to be generated only when the limits are *exceeded*. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160061&action=edit Bug 28530: (QA follow-up): Fix qa issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160053|0 |1 is obsolete| | Attachment #160054|0 |1 is obsolete| | Attachment #160055|0 |1 is obsolete| | Attachment #160056|0 |1 is obsolete| | Attachment #160057|0 |1 is obsolete| | Attachment #160058|0 |1 is obsolete| | Attachment #160061|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160062&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160063&action=edit Bug 28530: Add Koha Object(s) for Float Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160064&action=edit Bug 28530: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160065&action=edit Bug 28530: Add float limits editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160066&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160067&action=edit Bug 28530: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160068&action=edit Bug 28530: (QA follow-up) Fix QA issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160062|0 |1 is obsolete| | Attachment #160063|0 |1 is obsolete| | Attachment #160064|0 |1 is obsolete| | Attachment #160065|0 |1 is obsolete| | Attachment #160066|0 |1 is obsolete| | Attachment #160067|0 |1 is obsolete| | Attachment #160068|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160071&action=edit Bug 28530: Update database, add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160072&action=edit Bug 28530: Add Koha Object(s) for Float Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160073&action=edit Bug 28530: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160074&action=edit Bug 28530: Add float limits editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160075&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160076&action=edit Bug 28530: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #24) All issues should be fixed. All fixes merged into original patchset! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #24)
Transfer triggered for checkin that *meets* limit rather than exceeding it: - have a float limit set to 1 for Branch A - have 1 item of that item type at Branch A, giving ratio of 1 - check that item in at Branch A, get notified that this would put the library over its limit and the item will be transferred
Clarifying a little -- currently the patch *does* generate a transfer when a checked in item *meets* the floating limit. And I suppose that's what the text on screen says: "if the checkin library has reached its' limit for that type of item." That said, I feel like users may expect transfers to be generated only when the limits are *exceeded*.
I'll change to exceeding the limit. I think that's more natural and expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 160077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160077&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160071|0 |1 is obsolete| | --- Comment #42 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160078&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160072|0 |1 is obsolete| | --- Comment #43 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160079&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160073|0 |1 is obsolete| | --- Comment #44 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160080&action=edit Bug 28530: Update existing schema files Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160074|0 |1 is obsolete| | --- Comment #45 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160081&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160075|0 |1 is obsolete| | --- Comment #46 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160082&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160076|0 |1 is obsolete| | --- Comment #47 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160083&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160077|0 |1 is obsolete| | --- Comment #48 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 160084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160084&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Programming error - op 'set_float_limits' must start with 'cud-' for POST http://localhost:8081/intranet/admin/float_limits.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 163919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163919&action=edit Bug 28530: (QA follow-up): Implement CSRF cud op -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160078|0 |1 is obsolete| | Attachment #160079|0 |1 is obsolete| | Attachment #160080|0 |1 is obsolete| | Attachment #160081|0 |1 is obsolete| | Attachment #160082|0 |1 is obsolete| | Attachment #160083|0 |1 is obsolete| | Attachment #160084|0 |1 is obsolete| | Attachment #163919|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168343&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168344&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168345&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168346&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168347&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168348&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168349&action=edit Bug 28530: (QA follow-up): Implement CSRF cud op -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 168350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168350&action=edit Bug 28530: Update existing schema files Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Patch doesn't apply --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Sorry Kyle, this no longer applies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168343|0 |1 is obsolete| | --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178762&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168344|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178763&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168345|0 |1 is obsolete| | --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178764&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168346|0 |1 is obsolete| | --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178765&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168347|0 |1 is obsolete| | --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178766&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168348|0 |1 is obsolete| | --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178767&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168349|0 |1 is obsolete| | --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178768&action=edit Bug 28530: (QA follow-up): Implement CSRF cud op -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168350|0 |1 is obsolete| | --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178769&action=edit Bug 28530: Update existing schema files Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Patch doesn't apply |Failed QA --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased for current main, still some noticeable problems with both CSRF and Bootstrap 5 things. Setting to FQA for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178783&action=edit Bug 28530: Template adjustmentts for CSRF and Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178784&action=edit Bug 28530: Tidy admin-menu.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178785&action=edit Bug 28530: Fix remaining QA script failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think this is again ready for testing, resetting to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #73 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This doesn't seem to be enforcing limits correctly. I think it's checking the float limit against the total number of items of that item type in the whole system (rather than just at the current branch) and then prompting a transfer to the branch with the lowest items/limit ratio (unless that's your current branch, in which case no transfer is generated). To recreate: - set circ rules to everything floats - create 4 items of itemtype CF / Computer Files (this itype exists in the default data without any items, so it's easy to test with) - set float limit of 3 for CF items at Centerville and Fairfield branches, leave other branches without limits - play around checking your 4 items in at Centerville and Fairfield Koha should only generate a transfer when all 4 items end up at either Centerville or Fairfield. Instead, it seems to be generating a transfer whenever the branch at which you're checking in does not have the lowest ratio of items/limit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #74 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178934&action=edit Bug 28530: (QA follow-up) correct item count and limit enforcement Corrected the count of items to limit to the current branch. Also set the limit to trigger when the count of items at the branch is currently at the limit before the item to be checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178762|0 |1 is obsolete| | --- Comment #75 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178935&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178763|0 |1 is obsolete| | --- Comment #76 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178936&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178764|0 |1 is obsolete| | --- Comment #77 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178937&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178765|0 |1 is obsolete| | --- Comment #78 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178938&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178766|0 |1 is obsolete| | --- Comment #79 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178939&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178767|0 |1 is obsolete| | --- Comment #80 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178940&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178768|0 |1 is obsolete| | --- Comment #81 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178941&action=edit Bug 28530: (QA follow-up): Implement CSRF cud op Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178769|0 |1 is obsolete| | --- Comment #82 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178942&action=edit Bug 28530: Update existing schema files Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178783|0 |1 is obsolete| | --- Comment #83 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178943&action=edit Bug 28530: Template adjustmentts for CSRF and Bootstrap 5 Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178784|0 |1 is obsolete| | --- Comment #84 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178944&action=edit Bug 28530: Tidy admin-menu.inc Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178785|0 |1 is obsolete| | --- Comment #85 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178945&action=edit Bug 28530: Fix remaining QA script failures Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178934|0 |1 is obsolete| | --- Comment #86 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178946&action=edit Bug 28530: (QA follow-up) correct item count and limit enforcement Corrected the count of items to limit to the current branch. Also set the limit to trigger when the count of items at the branch is currently at the limit before the item to be checked in. Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #87 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Unit tests are failing here I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178935|0 |1 is obsolete| | --- Comment #88 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179943&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178936|0 |1 is obsolete| | --- Comment #89 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179944&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178937|0 |1 is obsolete| | --- Comment #90 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179945&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178938|0 |1 is obsolete| | --- Comment #91 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179946&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178939|0 |1 is obsolete| | --- Comment #92 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179947&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178940|0 |1 is obsolete| | --- Comment #93 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179948&action=edit Bug 28530: (QA follow-up) Require the item checkin to exceed the limit, rather than meet the limit Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178941|0 |1 is obsolete| | --- Comment #94 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179949&action=edit Bug 28530: (QA follow-up): Implement CSRF cud op Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178942|0 |1 is obsolete| | --- Comment #95 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179950&action=edit Bug 28530: Update existing schema files Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178943|0 |1 is obsolete| | --- Comment #96 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179951&action=edit Bug 28530: Template adjustmentts for CSRF and Bootstrap 5 Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178944|0 |1 is obsolete| | --- Comment #97 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179952&action=edit Bug 28530: Tidy admin-menu.inc Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178945|0 |1 is obsolete| | --- Comment #98 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179953&action=edit Bug 28530: Fix remaining QA script failures Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178946|0 |1 is obsolete| | --- Comment #99 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179954&action=edit Bug 28530: (QA follow-up) correct item count and limit enforcement Corrected the count of items to limit to the current branch. Also set the limit to trigger when the count of items at the branch is currently at the limit before the item to be checked in. Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #100 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179955&action=edit Bug 28530: Adjust number of tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #101 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize (ashimema) from comment #87)
Unit tests are failing here I'm afraid.
It seems like it was only the number of test, I have adjusted that. Nothing else was failing for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179955|0 |1 is obsolete| | --- Comment #102 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 180028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180028&action=edit Bug 28530: Adjust number of tests Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #103 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm afraid I'm seeing unit test failures still here.. I've reset_all etc and the tests still fail I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #104 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Comment on attachment 179944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179944 Bug 28530: Add Koha Object(s) for Float Limits Review of attachment 179944: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28530&attachment=179944) ----------------------------------------------------------------- ::: Koha/Library/FloatLimits.pm @@ +43,5 @@
+sub lowest_ratio_library { + my ( $self, $item, $branchcode ) = @_; + + my $field = C4::Context->preference('item-level_itypes') ? 'items.itype' : 'biblioitems.itemtype'; + my $query = qq{
Is it deliverate to continue using plain SQL here rather than constructing a DBIC query.. and should we perhaps be returning a Koha::Library object rather than a branchcode given this is a Koha:: object method? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #105 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- In fact.. I'd kinda be tempted to shift that filter method into Koha::Libraries... you're basically looking for the library with the lowest_ratio.. that feels like a `Koha::Libraries->find_library_with_lowest_float_ratio` method to me... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #106 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Is it deliverate to continue using plain SQL here rather than constructing a DBIC query.. and should we perhaps be returning a Koha::Library object rather than a branchcode given this is a Koha:: object method?
I'm not the original author but I tend to agree, let's use a DBIC query and return a library object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #107 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182931&action=edit Bug 28530: Use DBIC query and return library object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #108 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In testing this, I've run into some shortcomings in its logic. I suspect these are things that were not considered to begin with, rather than things introduced in the recent change to use DBIC and a library object. As these float limits are enforced, we count items based purely on their holdingbranch, regardless of other values. Most pointedly, we don't consider whether or not those items are either checked out or in transit to another library. The goal here is to govern floating based on how many items are actually on the shelf, so this isn't ideal. My pretend library has a branch with a floating limit of 10 for the itemtype DVD, because they're small. At this small branch: - there are 10 DVDs available -- they're at their float limit - a patron checks out 5 DVDs, leaving 5 available Per the current logic, this library is *still* at their float limit because those 5 checked-out DVDs haven't changed their holding branch, even though we have no expectation that those DVDs will come back to the same branch they were checked out from. ** When an item is checked out, it should not count toward the float limit at *any* branch. A new scenario at my pretend library, again at the small branch with the float limit of 10 DVDs: - there are 10 DVDs available -- they're at their float limit - take one of those 10 available DVDs and check it in for a local use - Koha tells you to transfer that item away to keep under your float limit. Accept that transfer - Check in one of your 9 remaining available DVDs for another local use. Koha tells you to transfer this one away, too. Because the holding branch on the previous one hasn't changed yet and we're not looking at whether or not it's in transit. ** When an item is in transit, it should count toward the float limit at the branch it is transferring to, even when it hasn't been received yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #109 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #108)
A new scenario at my pretend library, again at the small branch with the float limit of 10 DVDs: - there are 10 DVDs available -- they're at their float limit - take one of those 10 available DVDs and check it in for a local use - Koha tells you to transfer that item away to keep under your float limit.
This is another issue. Checkin an item in for a local use prompts that item to transfer away if the library is *at* its float limit. Seems like it's not considering that the item being checked in is already here and therefore will not push the library to *exceed* its limit, which is when a transfer should happen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #110 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184754&action=edit Bug 28530: Do not count onloan items towards the float limit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #111 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184755&action=edit Bug 28530: Count incoming transfers against the float limit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #112 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio 8) Confirm checked-out items are not counted for either float limits or float ratios 9) Confirm in-transit items are not counted for either float limits or float ratios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #113 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I found it helpful to have a query to count items per branch, taking into account how many are checked out or in transit. I've been resting using the Ref item type as there aren't any in the base KTD data so it's easy to set up tests. SELECT item_counts.*, transfer_incoming FROM ( SELECT i.holdingbranch, count(i.itemnumber) as count_by_holdingbranch_only, sum(if(t.branchtransfer_id is null and i.onloan is null,1,0)) as available, sum(if(i.onloan is not null,1,0)) as checked_out, sum(if(t.branchtransfer_id is not null,1,0)) as transfered_away FROM items i LEFT JOIN branchtransfers t ON (i.itemnumber=t.itemnumber and t.datesent is not null and t.datecancelled is null and t.datearrived is null) WHERE itype='ref' GROUP BY holdingbranch ) item_counts LEFT JOIN ( SELECT b.tobranch, count(b.branchtransfer_id) as transfer_incoming FROM branchtransfers b WHERE b.datesent is not null and b.datearrived is null and b.datecancelled is null GROUP BY tobranch ) incoming ON (item_counts.holdingbranch = incoming.tobranch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #114 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184917&action=edit Bug 28530: Subtract outgoing transfers from the branches float limit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #115 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184936&action=edit Bug 28530: Fix sorting and pick a random branch in the event of a tie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #116 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- New test plan: Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section, for example: 7) Create some float limits for a single itemtype, we are testing with REF itemtypes in k-t-d as there are none by default, so add these float limits for the REF itemtype: -CPL: 2 -FFL: 2 -FPL: 2 -FRL: 2 -ITP: 2 The rest should be set 0 or remain empty. 8) Create or have the following items: -CPL: 2 REF items -FFL: 2 REF items -FPL: 2 REF items -FRL: 2 REF items -ITP: 2 REF items 9) In Circulation rules set ‘Default checkout, hold and return policy’ to ‘item floats’. 10) Ensure you are logged in as CPL. 11) Check in a CPL REF item at CPL. It checks in normally. 12) Check in a FFL item at CPL, get a pop-up modal telling you that you have exceeded float limits, this item should return to FFL. 13). Login as FFL, they should have 1 REF item in-transit and 1 REF item on the shelves. 14) Check in a ITP item, since you have exceeded float limits you should get a pop-up telling to return this item to CPL. CPL has 1 on shelf REF item, 1 in transit away. CPL is the best option for this item. 15) Check out both items from FPL at FPL. Still logged in as FFL check in one of your own items. You should be told to return it to FPL, they have the lowest float limit now. 16) Reset all of your items transfers and holding branch data: -delete from branchtransfers; -update items set holdingbranch = homebranch; 17) Set the float limits to each branch to: -CPL: 1 -FFL: 1 -FPL: 1 -FRL: 1 -ITP: 1 18) Every library is now at its float limit. Checkin one of the checked out items for step 15. It should be send back to FPL, since it has the lowest ratio now. 19) Check all items in and reset transfers and holding branch data: -delete from branchtransfers; -update items set holdingbranch = homebranch; 20) Now as FFL, checkin an FFL item. Everyone is over their limit and the ratio is a tie. The item should go to a random branch among the tied candidates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #117 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Im setting this to FQA because this needs to follow the 'Floats by library group' return policy. If that policy is active we should only do float limit transfers to branches within the group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179943|0 |1 is obsolete| | Attachment #179944|0 |1 is obsolete| | Attachment #179945|0 |1 is obsolete| | Attachment #179946|0 |1 is obsolete| | Attachment #179947|0 |1 is obsolete| | Attachment #179948|0 |1 is obsolete| | Attachment #179949|0 |1 is obsolete| | Attachment #179950|0 |1 is obsolete| | Attachment #179951|0 |1 is obsolete| | Attachment #179952|0 |1 is obsolete| | Attachment #179954|0 |1 is obsolete| | Attachment #180028|0 |1 is obsolete| | Attachment #182931|0 |1 is obsolete| | Attachment #184754|0 |1 is obsolete| | Attachment #184755|0 |1 is obsolete| | Attachment #184917|0 |1 is obsolete| | Attachment #184936|0 |1 is obsolete| | --- Comment #118 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184951&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #119 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184952&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #120 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184953&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184954&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #122 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184955&action=edit Bug 28530: Implement float limits Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable UseLibraryFloatLimits 5) Verify items float correctly as per your circulation rules 6) Set some float limits from the Library Float Limits configuration page in the Administration section The simplest solution is to set the float limit from one branch to 1 item, a second to 100 items, and a third to 300 items for a single itemtype 7) Verify checked in items that should have floated at this branch are now transfered to the branch with the best float ratio Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184951|0 |1 is obsolete| | --- Comment #123 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184956&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184952|0 |1 is obsolete| | --- Comment #124 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184957&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184953|0 |1 is obsolete| | --- Comment #125 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184958&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184954|0 |1 is obsolete| | --- Comment #126 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184959&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184955|0 |1 is obsolete| | --- Comment #127 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184960&action=edit Bug 28530: Implement float limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #128 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184961&action=edit Bug 28530: DBIC changes DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #129 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184963&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184963|0 |1 is obsolete| | --- Comment #130 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184965&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184965|0 |1 is obsolete| | --- Comment #131 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184966&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184966|0 |1 is obsolete| | --- Comment #132 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184967&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #133 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185038&action=edit Bug 28530: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #134 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Still running into an issue here when all branches are *at* their float limit and an item moves from Branch A to Branch B. So, at step 12 of the test plan in comment 116, we've got 2 REF items at each branch and take one of the FFL items and check it in ay CPL. With these patches, Koha sees that moving this item would put CPL over its limit of 2, but declines to transfer the item because at that point in the transaction the item's holdingbranch hasn't yet changed and so Koha views all branches as being tied on their limit/item ratio. We should update the item's holdingbranch to the branch at which the checkin is happening *before* we check the float limits to see if it's acceptable for that item to stay at its new branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184956|0 |1 is obsolete| | --- Comment #135 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185836&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184957|0 |1 is obsolete| | --- Comment #136 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185837&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184958|0 |1 is obsolete| | --- Comment #137 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185838&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184959|0 |1 is obsolete| | --- Comment #138 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185839&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184960|0 |1 is obsolete| | --- Comment #139 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185840&action=edit Bug 28530: Implement float limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184961|0 |1 is obsolete| | --- Comment #140 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185841&action=edit Bug 28530: DBIC changes DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184967|0 |1 is obsolete| | --- Comment #141 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185842&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185038|0 |1 is obsolete| | --- Comment #142 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185843&action=edit Bug 28530: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #143 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187525&action=edit Bug 28530: Increment and decrement item count before calculation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #144 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I still need to adjust unit tests and make a few small QA fixes but I want to set this back to "Needs signoff" to get some people testing the float limits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #145 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187601&action=edit Bug 28530: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #146 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Please rebase for testing. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185836|0 |1 is obsolete| | --- Comment #147 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190501&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185837|0 |1 is obsolete| | --- Comment #148 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190502&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185838|0 |1 is obsolete| | --- Comment #149 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190503&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185839|0 |1 is obsolete| | --- Comment #150 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190504&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185840|0 |1 is obsolete| | --- Comment #151 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190505&action=edit Bug 28530: Implement float limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185841|0 |1 is obsolete| | --- Comment #152 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190506&action=edit Bug 28530: DBIC changes DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185842|0 |1 is obsolete| | --- Comment #153 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190507&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185843|0 |1 is obsolete| | --- Comment #154 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190508&action=edit Bug 28530: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187525|0 |1 is obsolete| | --- Comment #155 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190509&action=edit Bug 28530: Increment and decrement item count before calculation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187601|0 |1 is obsolete| | --- Comment #156 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190510&action=edit Bug 28530: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #157 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190511&action=edit Bug 28530: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #158 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190512&action=edit Bug 28530: Fix forbidden http pattern -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #159 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190513&action=edit Bug 28530: Fix spelling mistakes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #160 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- "Can't locate object method "find" via package "Koha::Library::FloatLimits" (perhaps you forgot to load "Koha::Library::FloatLimits"?) at /kohadevbox/koha/C4/Circulation.pm line 2337" I get this error when performing a checkin if my system contains items of an itemtype for which there are some float limits defined at a branch that does not have float limits for that item type. Phrased differently, test plan all worked while my float limits were set for CPL, FFL, FPL, FRL, and IPT and my only REF items were at those 5 branches. However, when I created a new item at LPL I started getting this error on every checkin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #161 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190547&action=edit Bug 28530: Add missing use statement for Koha::Library::FloatLimits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190501|0 |1 is obsolete| | --- Comment #162 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190594&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190502|0 |1 is obsolete| | --- Comment #163 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190595&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190503|0 |1 is obsolete| | --- Comment #164 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190596&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190504|0 |1 is obsolete| | --- Comment #165 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190597&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190505|0 |1 is obsolete| | --- Comment #166 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190598&action=edit Bug 28530: Implement float limits Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190506|0 |1 is obsolete| | --- Comment #167 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190599&action=edit Bug 28530: DBIC changes DO NOT PUSH Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190507|0 |1 is obsolete| | --- Comment #168 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190600&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190508|0 |1 is obsolete| | --- Comment #169 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190601&action=edit Bug 28530: Add more tests Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190509|0 |1 is obsolete| | --- Comment #170 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190602&action=edit Bug 28530: Increment and decrement item count before calculation Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190510|0 |1 is obsolete| | --- Comment #171 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190603&action=edit Bug 28530: Adjust tests Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190511|0 |1 is obsolete| | --- Comment #172 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190604&action=edit Bug 28530: Fix tests Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190512|0 |1 is obsolete| | --- Comment #173 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190605&action=edit Bug 28530: Fix forbidden http pattern Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190513|0 |1 is obsolete| | --- Comment #174 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190606&action=edit Bug 28530: Fix spelling mistakes Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190547|0 |1 is obsolete| | --- Comment #175 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190607&action=edit Bug 28530: Add missing use statement for Koha::Library::FloatLimits Signed-off-by: Kris Becker <kbecker@jcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190597|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190598|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190602|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #176 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192476&action=edit Bug 28530: Update database, add new schema file Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #177 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192477&action=edit Bug 28530: Add Koha Object(s) for Float Limits Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #178 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192478&action=edit Bug 28530: Add float limits editor Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #179 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192479&action=edit Bug 28530: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #180 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192480&action=edit Bug 28530: Implement float limits Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #181 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192481&action=edit Bug 28530: DBIC changes DO NOT PUSH Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #182 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192482&action=edit Bug 28530: If return policy is set to float in library group, remove non group branches Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #183 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192483&action=edit Bug 28530: Add more tests Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #184 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192484&action=edit Bug 28530: Increment and decrement item count before calculation Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #185 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192485&action=edit Bug 28530: Adjust tests Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #186 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192486&action=edit Bug 28530: Fix tests Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #187 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192487&action=edit Bug 28530: Fix forbidden http pattern Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #188 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192488&action=edit Bug 28530: Fix spelling mistakes Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #189 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192489&action=edit Bug 28530: Add missing use statement for Koha::Library::FloatLimits Signed-off-by: Kris Becker <kbecker@jcls.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #190 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192490&action=edit Bug 28530: (QA follow-up) Remove unused LibraryFloatLimitTransferRequest message handling The LibraryFloatLimitTransferRequest message was never set in C4::Circulation, making this code unreachable. Float limit transfers are already properly handled through the existing transfer message system (WasTransfered/NeedsTransfer) with TransferTrigger set to 'LibraryFloatLimit'. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #191 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192491&action=edit Bug 28530: (QA follow-up) Guard against divide by zero Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #192 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192492&action=edit Bug 28530: (QA follow-up) Use DBIC in controller Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #193 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192493&action=edit Bug 28530: (QA follow-up) Add POD documentation and database index - Add comprehensive POD documentation for lowest_ratio_library() method including parameter descriptions, return values, and algorithm explanation - Add database index on itemtype column in library_float_limits table to improve query performance when searching by itemtype Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #194 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192494&action=edit Bug 28530: (QA follow-up) Fix N+1 query performance issue Refactored lowest_ratio_library() to eliminate the N+1 query problem by using aggregated queries with GROUP BY instead of per-branch queries. Performance improvement: - Before: O(3n) queries where n = number of branches with float limits Example: 20 branches = 60 database queries - After: O(3) queries regardless of number of branches Example: 20 branches = 3 database queries The optimization uses three aggregated queries: 1. Single query with GROUP BY to get item counts at all branches 2. Single query with GROUP BY to get in-transit-to counts for all branches 3. Single query with GROUP BY to get in-transit-from counts for all branches Results are combined in memory to calculate ratios, maintaining identical logic and behavior while dramatically improving database efficiency. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #195 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192495&action=edit Bug 28530: (QA follow-up) Fix branch transfer limits not checking alternate libraries Fixed a pre-existing bug where branch transfer limits would prevent ANY transfer if the optimal library was blocked, instead of trying the next best candidate. Original behavior: - Sort candidates by best ratio - Check if transfer to best candidate is allowed - If not allowed: exit loop immediately (bug!) and return undef - Result: No transfer created even if other valid candidates exist Fixed behavior: - Sort candidates by best ratio - Check if transfer to best candidate is allowed - If allowed: use that library and exit loop - If not allowed: continue to next candidate - Result: Uses the best ALLOWED candidate This fix ensures that when branch transfer limits block the optimal destination, the system will try the next-best option instead of giving up entirely. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds the release notes| |ability to define and | |enforce a maximum number of | |items per item type to be | |held at each library when | |items are allowed to float. | |This feature is enabled | |with the | |UseLibraryFloatLimits | |system preference. Float | |limits are defined within | |Administration. Items | |checked in at a library | |that has met its float | |limit for that item type | |will be transferred to the | |branch with the lowest | |ratio of held items to | |allowed items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #196 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192918&action=edit Bug 28530: (RM follow-up) Move kohastructure update to right place alphabetically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #197 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #198 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192954&action=edit Bug 28530: (follow-up) Place system pref in corret order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 --- Comment #199 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #200 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43247 [Bug 43247] Transfer reason doesn't show in Checked-in items table for float limit transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43248 [Bug 43248] Lost, not for loan, withdrawn, and damaged statuses not considered in library float limits ratio calculations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43250 [Bug 43250] Library float limits feature should have its own permission -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org